Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/ --- (Updated Okt. 17, 2016, 5:30 vorm.) Review request for Baloo. Changes -

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/ --- (Updated Nov. 5, 2016, 11:37 vorm.) Review request for Baloo and Vishesh

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100621 --- I wouldn't discard it, I'm afraid nobody really wants to tak

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100622 --- src/codecs/coding.cpp (line 151)

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

> On Nov. 6, 2016, 5:40 a.m., Michael Stemle wrote: > > src/codecs/coding.cpp, line 186 > > > > > > PEDANTIC QUESTION: Why do we `resize()` rather than just using > > `QByteArray((values.size() + 1) * 5, '\0')`?

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100638 --- src/codecs/coding.cpp (line 114)

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/ --- (Updated Nov. 6, 2016, 12:58 p.m.) Review request for Baloo, KDE Framewor

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100652 --- Ship it! Ship It! - Michael Stemle On Nov. 6, 2016, 12

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100660 --- Fix it, then Ship it! src/codecs/coding.cpp (line 160) <

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

> On Nov. 6, 2016, 7:36 p.m., David Faure wrote: > > src/codecs/coding.cpp, line 177 > > > > > > remove space before auto; make it "const auto" while at it? ignore the const bit, that was nonsense. - David -

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/ --- (Updated Nov. 7, 2016, 6:44 p.m.) Status -- This change has been mar

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/#review100694 --- Ship it! Ship It! - Michael Stemle On Nov. 7, 2016, 6: