Re: Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2017-08-23 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129378/ --- (Updated Aug. 24, 2017, 7:06 a.m.) Status -- This change has been ma

Re: Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2017-08-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129378/#review103641 --- Ship it! Ship It! - Kai Uwe Broulik On Nov. 11, 2016,

Re: Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2017-08-23 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129378/#review103640 --- Anyone interested? Otherwise I'll discard this review in the

Re: Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2016-12-11 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129378/#review101361 --- Ping, no interest anyone? - Christian Ehrlicher On Nov. 1

Re: Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2016-11-11 Thread Christian Ehrlicher
> On Nov. 11, 2016, 11:42 nachm., Aleix Pol Gonzalez wrote: > > I don't think this is saving anything, the move constructor should be > > taking care of it. > > http://en.cppreference.com/w/cpp/language/move_constructor I'm sorry but where do you see move ctors here in the first place? it.next(

Re: Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2016-11-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129378/#review100797 --- I don't think this is saving anything, the move constructor

Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2016-11-11 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129378/ --- Review request for Baloo. Repository: baloo Description --- No fun