[smb4k] doc: Fix minor typo

2019-02-16 Thread Yuri Chornoivan
Git commit e6e2f81ea1eb28e6c3768e466754703cf56d574d by Yuri Chornoivan. Committed on 17/02/2019 at 06:17. Pushed by yurchor into branch 'master'. Fix minor typo M +1-1doc/index.docbook https://commits.kde.org/smb4k/e6e2f81ea1eb28e6c3768e466754703cf56d574d diff --git

D18744: Add action in Edit menu to select the text on current page

2019-02-16 Thread Nathaniel Graham
ngraham added a comment. Double-click in the margins can't be used for this since there would be too many accidental activations. Here's my proposal - Double-click in the margins: select whole line - Triple-click in the margins or on a word: select whole paragraph -

D18744: Add action in Edit menu to select the text on current page

2019-02-16 Thread Shubham
shubham added a comment. > 2. Quadruple-click to select whole page What do other folks think? In my view quadruple click does not make sense because it is seldom the user can think it cam result in some kind of action or behaviour. Secondly, this feature then would remain hidden or

[k3b] /: Use more https in links

2019-02-16 Thread Friedrich W . H . Kossebau
Git commit e02be166a78d8cea499b9062d081f470525f0992 by Friedrich W. H. Kossebau. Committed on 16/02/2019 at 21:14. Pushed by kossebau into branch 'master'. Use more https in links M +9-9CMakeLists.txt M +2-2doc/index.docbook M +1-1

[khelpcenter] [Bug 404439] khelpcenter doesn't find unix man pages

2019-02-16 Thread Ardith Metz
https://bugs.kde.org/show_bug.cgi?id=404439 Ardith Metz changed: What|Removed |Added Resolution|--- |NOT A BUG Status|REPORTED

D18744: Add action in Edit menu to select the text on current page

2019-02-16 Thread David Hurka
davidhurka added a comment. In D18744#413768 , @aacid wrote: > Do not use Alt+Letter for a shortcut, it's bad. Because Alt is used for Access Keys (Mnemonics), right? In D18744#413776 ,

[smb4k] /: Revert changes made to the CMakeLists.txt files.

2019-02-16 Thread Alexander Reinholdt
Git commit b4a80245b5cb4d5433bc17db34f83bd7459386cb by Alexander Reinholdt. Committed on 16/02/2019 at 20:35. Pushed by areinholdt into branch 'master'. Revert changes made to the CMakeLists.txt files. M +2-9core/CMakeLists.txt M +16 -132 doc/index.docbook M +6-34

D18744: Add action in Edit menu to select the text on current page

2019-02-16 Thread Nathaniel Graham
ngraham added a comment. To be honest, I just don't feel great about this. The original bug (select whole page's text on double-click) was a bad idea, and we've tried to torture this patch into implementing the requested feature in a sort of awkward way, with a top-level menu item in the

D18744: Add action in Edit menu to select the text on current page

2019-02-16 Thread Albert Astals Cid
aacid added a comment. Do not use Alt+Anything for a shortcut it's bad REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella,

[audiocd-kio] /: Use more https in links

2019-02-16 Thread Friedrich W . H . Kossebau
Git commit ed0e7941da6548c0474a1d8afb86785191620d6e by Friedrich W. H. Kossebau. Committed on 16/02/2019 at 16:18. Pushed by kossebau into branch 'master'. Use more https in links M +1-1CMakeLists.txt M +1-1kcmaudiocd/doc/index.docbook M +1-1plugins/flac/encoderflac.h

D18744: Add action in Edit menu to select the text on current page

2019-02-16 Thread Shubham
shubham added a comment. In D18744#412143 , @ngraham wrote: > OK, works for me now. I'm not thrilled about the Alt-P shortcut since it's the only one in the menu that uses only the Alt modifier. But I won't block on that. I'll hand this back to

[khelpcenter] [Bug 404439] khelpcenter doesn't find unix man pages

2019-02-16 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=404439 --- Comment #3 from Luigi Toscano --- (In reply to Ardith Metz from comment #2) > (In reply to Luigi Toscano from comment #1) > > Is kio-extras installed? > > Yes, it is. I will investigate, but can you please check on Arch forums to check if it's a

[khelpcenter] [Bug 404439] khelpcenter doesn't find unix man pages

2019-02-16 Thread Ardith Metz
https://bugs.kde.org/show_bug.cgi?id=404439 --- Comment #2 from Ardith Metz --- (In reply to Luigi Toscano from comment #1) > Is kio-extras installed? Yes, it is. > (khelpcenter is released as part of a bundle called KDE Applications; > 18.12.2 is the version number of the bundle, not the

[khelpcenter] [Bug 404439] khelpcenter doesn't find unix man pages

2019-02-16 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=404439 Luigi Toscano changed: What|Removed |Added CC||luigi.tosc...@tiscali.it --- Comment #1 from

[khelpcenter] [Bug 404439] New: khelpcenter doesn't find unix man pages

2019-02-16 Thread Ardith Metz
https://bugs.kde.org/show_bug.cgi?id=404439 Bug ID: 404439 Summary: khelpcenter doesn't find unix man pages Product: khelpcenter Version: 18.12 Platform: Archlinux Packages OS: Linux Status: REPORTED

D19054: Port cross-compilation support to KF5_HOST_TOOLING

2019-02-16 Thread Volker Krause
vkrause added a comment. In D19054#413147 , @ltoscano wrote: > I trust @vkrause that this complicated part works, but I need to ask @habacker too, as he contributed part of the cross-compiling code. > > If anyone else from the #windows

D18744: Add action in Edit menu to select the text on current page

2019-02-16 Thread Shubham
shubham updated this revision to Diff 51829. shubham edited the test plan for this revision. shubham added a comment. Correct shortcut in documentation Fix coding style REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=51685=51829 BRANCH