KF5 Update Meeting Reminder 2013-w23

2013-06-03 Thread David Faure
> Next meeting will be Tuesday 4 June. Exact time to be announced later (I > won't be available at the usual 4pm CEST). Let's say 6pm CEST, I hope we'll be done by then. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 _

Re: Phonon4Qt5 & Phonon5 Branches

2013-06-03 Thread David Faure
On Wednesday 29 May 2013 16:13:23 Harald Sitter wrote: > As you may be aware phonon supports building the phonon4 API against Qt5 by > building the phonon4qt5 branch. > > Due to consolidation efforts at the Phonon sprint last weekend the > phonon4qt5 transitional library is now merged into the mas

Jenkins build is back to normal : kdelibs_frameworks_qt5 #654

2013-06-03 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #653

2013-06-03 Thread KDE CI System
See Changes: [faure+bluesystems] Fix compilation (I was wrong in the review request). -- [...truncated 14057 lines...] -- Installing:

Build failed in Jenkins: kdelibs_frameworks_qt5 #652

2013-06-03 Thread KDE CI System
See Changes: [kde] Move KPasswordDialog to tier1/kwidgetaddons -- [...truncated 4101 lines...] Generating moc_xml_tokenizer.cpp Building CXX object tier1/kcoreaddons/autotests/CMakeFiles/kautos

Re: Review Request 110760: Port time_t to QDateTime in KLauncher

2013-06-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110760/#review33708 --- Ship it! Ship It! - David Faure On June 3, 2013, 9:02 p.m.,

Re: Review Request 110643: Move KPasswordDialog to tier1/kwidgetaddons

2013-06-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110643/#review33707 --- This review has been submitted with commit 15d373190ceeb41742c

Re: Review Request 110643: Move KPasswordDialog to tier1/kwidgetaddons

2013-06-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110643/ --- (Updated June 3, 2013, 9:49 p.m.) Status -- This change has been mark

Re: Bad rpath/LD_LIBRARY_PATH settings in kdelibs build scripts?

2013-06-03 Thread Alexander Neundorf
On Tuesday 21 May 2013, Alex Merry wrote: > I'm getting issues with building kdelibs-frameworks where I have either > kdelibs4 installed in /usr or a sufficiently old version of > kdelibs-frameworks installed somewhere referenced by LD_LIBRARY_PATH. > > The issue seems to be that executables built

Re: Review Request 110764: Port time_t to QDateTime in Slave (KIO)

2013-06-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110764/#review33706 --- Ship it! Ship It! - David Faure On June 3, 2013, 8:50 p.m.,

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

2013-06-03 Thread David Faure
> On May 29, 2013, 4:02 p.m., David Faure wrote: > > staging/knotifications/src/kstatusnotifieritem.cpp, line 42 > > > > > > doesn't look portable to Windows? > > Marco Martin wrote: > what would be a way to m

Re: Review Request 110760: Port time_t to QDateTime in KLauncher

2013-06-03 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110760/ --- (Updated June 3, 2013, 9:02 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 110760: Port time_t to QDateTime in KLauncher

2013-06-03 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110760/ --- (Updated June 3, 2013, 8:58 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 110764: Port time_t to QDateTime in Slave (KIO)

2013-06-03 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110764/ --- (Updated June 3, 2013, 8:50 p.m.) Review request for KDE Frameworks. Cha

Re: KF5 Update Meeting 2013-w20

2013-06-03 Thread Alexander Neundorf
On Monday 03 June 2013, Christophe Giboudeaux wrote: > On Monday 03 June 2013 12:34:46 David Faure wrote: > > On Monday 20 May 2013 11:53:18 Alexander Neundorf wrote: > > > there was a review request for a find-module for libusb1 here a few > > > days ago, which we have already in e-c-m, but he ca

Re: KF5 Update Meeting 2013-w20

2013-06-03 Thread Alexander Neundorf
On Monday 03 June 2013, Christophe Giboudeaux wrote: > On Monday 03 June 2013 12:34:46 David Faure wrote: > > On Monday 20 May 2013 11:53:18 Alexander Neundorf wrote: > > > there was a review request for a find-module for libusb1 here a few > > > days ago, which we have already in e-c-m, but he ca

Re: Review Request 109524: Remove some compile warnings

2013-06-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/ --- (Updated June 3, 2013, 8:08 p.m.) Status -- This change has been mark

Re: Review Request 109524: Remove some compile warnings

2013-06-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109524/#review33695 --- This review has been submitted with commit 8ad8d7239efc502fe99

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

2013-06-03 Thread Marco Martin
> On May 29, 2013, 4:02 p.m., David Faure wrote: > > staging/knotifications/src/kstatusnotifieritem.cpp, line 42 > > > > > > doesn't look portable to Windows? what would be a way to make it portable? it's basicall

Re: Review Request 110482: Move KStatusNotifierItem in KNotifications

2013-06-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110482/ --- (Updated June 3, 2013, 7:29 p.m.) Review request for KDE Frameworks. Cha

Review Request 110820: Move KActionSelector to KWidgetAddons

2013-06-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110820/ --- Review request for KDE Frameworks. Description --- Moved KActionSelec

Re: Bad rpath/LD_LIBRARY_PATH settings in kdelibs build scripts?

2013-06-03 Thread Alexander Neundorf
On Monday 03 June 2013, David Faure wrote: > I've been wondering the same. > > Alex? Stephen? I'll have a look RSN. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 110815: Move KPassivePopup to KWidgetAddons

2013-06-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110815/ --- (Updated June 3, 2013, 4:19 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

2013-06-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/ --- (Updated June 3, 2013, 4:08 p.m.) Review request for KDE Frameworks. Cha

Review Request 110815: Move KPassivePopup to KWidgetAddons

2013-06-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110815/ --- Review request for KDE Frameworks. Description --- Moved kpassivepopu

Re: Review Request 110674: Moving KToolBarSpacerAction to kde4support

2013-06-03 Thread David Faure
> On May 27, 2013, 11:02 p.m., David Faure wrote: > > staging/kde4support/src/kdeui/ktoolbarspaceraction.h, line 31 > > > > > > @deprecated since 5.0, use XXX instead. > > > > What should the k3b, amarok,

Re: Review Request 110674: Moving KToolBarSpacerAction to kde4support

2013-06-03 Thread Aleix Pol Gonzalez
> On May 27, 2013, 11:02 p.m., David Faure wrote: > > staging/kde4support/src/kdeui/ktoolbarspaceraction.h, line 31 > > > > > > @deprecated since 5.0, use XXX instead. > > > > What should the k3b, amarok,

Re: Review Request 110674: Moving KToolBarSpacerAction to kde4support

2013-06-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/ --- (Updated June 3, 2013, 2:17 p.m.) Review request for KDE Frameworks. Des

Re: Review Request 110674: Moving KToolBarSpacerAction to kde4support

2013-06-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110674/ --- (Updated June 3, 2013, 2:14 p.m.) Review request for KDE Frameworks. Cha

Re: KF5 Update Meeting 2013-w20

2013-06-03 Thread Christophe Giboudeaux
On Monday 03 June 2013 12:34:46 David Faure wrote: > On Monday 20 May 2013 11:53:18 Alexander Neundorf wrote: > > there was a review request for a find-module for libusb1 here a few days > > ago, which we have already in e-c-m, but he can't use it because it is > > not > > released > > Could we m

Re: Review Request 110643: Move KPasswordDialog to tier1/kwidgetaddons

2013-06-03 Thread David Faure
> On June 3, 2013, 10:15 a.m., David Faure wrote: > > Ship It! > > David Edmundson wrote: > Is the lineedit clear button a problem? No, there is work going on in Qt so that QLineEdit will provide this. You should add a #pragma message("KF5 TODO: enable clear button in QLineEdit once avail

Re: KF5 Update Meeting 2013-w20

2013-06-03 Thread David Faure
On Monday 20 May 2013 11:53:18 Alexander Neundorf wrote: > there was a review request for a find-module for libusb1 here a few days > ago, which we have already in e-c-m, but he can't use it because it is not > released Could we maybe release a first version of ECM with only find modules, and wi

Re: Simplifying KConfigDialogManager

2013-06-03 Thread David Faure
On Thursday 16 May 2013 08:13:55 David Edmundson wrote: > KConfigDialogManager currently contains a map of every possible widget > along with the name of the signal to connect to to know when a widget > changes. > > Can we kill this entire map and replace it with monitoring > widget->metaObject()-

Re: Bad rpath/LD_LIBRARY_PATH settings in kdelibs build scripts?

2013-06-03 Thread David Faure
I've been wondering the same. Alex? Stephen? On Tuesday 21 May 2013 14:56:29 Alex Merry wrote: > I'm getting issues with building kdelibs-frameworks where I have either > kdelibs4 installed in /usr or a sufficiently old version of > kdelibs-frameworks installed somewhere referenced by LD_LIBRARY_

Re: Review Request 110674: Moving KToolBarSpacerAction to kde4support

2013-06-03 Thread David Faure
> On May 27, 2013, 11:02 p.m., David Faure wrote: > > staging/kde4support/src/kdeui/ktoolbarspaceraction.h, line 31 > > > > > > @deprecated since 5.0, use XXX instead. > > > > What should the k3b, amarok,

Re: Review Request 110643: Move KPasswordDialog to tier1/kwidgetaddons

2013-06-03 Thread David Faure
> On May 29, 2013, 4:22 p.m., David Faure wrote: > > kdeui/dialogs/kpassworddialog.cpp, line 347 > > > > > > comboboxes are editable by default, so this line can be removed > > David Edmundson wrote: > Qt doc

Re: Review Request 110643: Move KPasswordDialog to tier1/kwidgetaddons

2013-06-03 Thread David Edmundson
> On June 3, 2013, 10:15 a.m., David Faure wrote: > > Ship It! Is the lineedit clear button a problem? - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110643/#review33631

Re: Review Request 110418: Move KNumInput to KDE4Support

2013-06-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110418/#review33632 --- kdeui/dialogs/kconfigdialogmanager.cpp

Re: Review Request 110643: Move KPasswordDialog to tier1/kwidgetaddons

2013-06-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110643/#review33631 --- Ship it! Ship It! - David Faure On June 2, 2013, 1:24 p.m.,

Re: Review Request 110764: Port time_t to QDateTime in Slave (KIO)

2013-06-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110764/#review33629 --- kio/kio/slave.cpp

Re: Review Request 110757: Port use of time_t to QDateTime in KImageCache

2013-06-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110757/#review33627 --- Ship it! Perfect. AFAICS you don't have a KDE contributor acc

Re: Review Request 110760: Port time_t to QDateTime in KLauncher

2013-06-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110760/#review33626 --- Ship it! Looks good, just one detail to fix, then commit. ki

Re: Review Request 109527: Use QStyle::styleHint(SH_Widget_Animate) instead of KGlobalSettings::graphicEffectLevel

2013-06-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109527/#review33625 --- For the record, this is waiting for an updated version of http