On June 10, 2013, 8:30 a.m., David Faure wrote:
khtml/xml/dom_docimpl.cpp, line 2007
http://git.reviewboard.kde.org/r/110876/diff/1/?file=149046#file149046line2007
This isn't about two QDateTimes.
It's about one QDateTime (m_creationDate) and one number of seconds,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110945/#review34110
---
kioslave/http/http.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110939/#review34114
---
Ship it!
Ship It!
- Kevin Ottens
On June 10, 2013, 5:33
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110833/#review34115
---
Ship it!
This change go in. Note that I disagree with the aim
On June 11, 2013, 9:01 a.m., Kevin Ottens wrote:
kioslave/http/http.cpp, line 4668
http://git.reviewboard.kde.org/r/110945/diff/1/?file=149512#file149512line4668
It's a QDataStream so we could use a QDateTime in there (would require
adjusting deserialize too... means we can get
On June 9, 2013, 10:25 a.m., Albert Astals Cid wrote:
Have we confirmed that Qt5 print dialog provides the options we have here?
Otherwise it shouldn't go to kde4support, no?
Yes it should, it shouldn't be in our API. Of course, someone should fix Qt5 or
our QPA plugin if it doesn't
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110907/#review34118
---
Ship it!
Ship It!
- Kevin Ottens
On June 9, 2013, 1:54
On June 11, 2013, 9:15 a.m., Kevin Ottens wrote:
Ship It!
Ooops... I validated by mistake. :-)
This diff is fine, but it looks incomplete, I don't see the CMakeLists.txt
changes or the kthml and kdeui changes you referred to in your comment.
- Kevin
On May 21, 2013, 10:35 a.m., Kevin Ottens wrote:
Hm for the kcupsoptionspageswidget.ui don't we need to also introduce a
QButtonGroup on the C++ side? So that the radio buttons keep being mutually
exclusive.
Anne-Marie Mahfouf wrote:
Radio buttons are autoExclusive by default
On June 9, 2013, 10:25 a.m., Albert Astals Cid wrote:
Have we confirmed that Qt5 print dialog provides the options we have here?
Otherwise it shouldn't go to kde4support, no?
Kevin Ottens wrote:
Yes it should, it shouldn't be in our API. Of course, someone should fix
Qt5 or our
On Monday, April 29, 2013 16:46:12 Sebastian Kügler wrote:
Current tip of Qt5's dev branch crashes with Plasma Frameworks, hitting an
ASSERT in qquicktextedit.cpp. I've filed a bug against Qt, so it's on the
radar of those who are hopefully able to fix it.
In the meantime, if you're
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110815/#review34123
---
Ship it!
Ship It!
- Kevin Ottens
On June 5, 2013, 2:12
On June 3, 2013, 9:59 a.m., David Faure wrote:
For the record, this is waiting for an updated version of
https://codereview.qt-project.org/#change,51166
Which is still not seeing any activity... Alex do you need help there?
- Kevin
On June 9, 2013, 10:25 a.m., Albert Astals Cid wrote:
Have we confirmed that Qt5 print dialog provides the options we have here?
Otherwise it shouldn't go to kde4support, no?
Kevin Ottens wrote:
Yes it should, it shouldn't be in our API. Of course, someone should fix
Qt5 or our
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110945/#review34135
---
kioslave/http/http.cpp
On June 11, 2013, 9:01 a.m., Kevin Ottens wrote:
kioslave/http/http.cpp, line 4668
http://git.reviewboard.kde.org/r/110945/diff/1/?file=149512#file149512line4668
It's a QDataStream so we could use a QDateTime in there (would require
adjusting deserialize too... means we can get
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110939/
---
(Updated June 11, 2013, 10:29 a.m.)
Status
--
This change has been
Le lundi 3 juin 2013 22:24:48 Alexander Neundorf a écrit :
On Monday 03 June 2013, Christophe Giboudeaux wrote:
On Monday 03 June 2013 12:34:46 David Faure wrote:
On Monday 20 May 2013 11:53:18 Alexander Neundorf wrote:
there was a review request for a find-module for libusb1 here a few
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108495/#review34138
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108389/#review34139
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108495/
---
(Updated June 11, 2013, 11 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108389/
---
(Updated June 11, 2013, 11 a.m.)
Status
--
This change has been
See http://build.kde.org/job/kdelibs_frameworks_qt5/698/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110478/
---
(Updated June 11, 2013, 1:30 p.m.)
Status
--
This change has been
See http://build.kde.org/job/kdelibs_frameworks_qt5/701/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Hello everyone,
This is the minutes of the Week 24 KF5 meeting. As usual it has been held on
#kde-devel at 4ppm Paris time.
Announcements:
* I'm back and sebas too :-)
* On June 22nd, a KF5 mini-sprint will be held in the Blue Systems Barcelona
office
Were present: annma, apol, ben2367,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110858/#review34151
---
The perl stuff looks mostly ok, but I found some issues that
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110957/
---
Review request for KDE Frameworks.
Description
---
Fix compilation
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110957/#review34159
---
staging/kde4support/src/kdecore/kgenericfactory.h
Le mercredi 5 juin 2013 23:30:31 Alexander Neundorf a écrit :
On Wednesday 05 June 2013, Alex Merry wrote:
On 04/06/13 23:01, David Faure wrote:
Hm, but why doesn't it work then? I see builddir/libkdeqt5staging/src in
both the RPATH and the RUNPATH, and one of these has priority over the
On June 9, 2013, 10:25 a.m., Albert Astals Cid wrote:
Have we confirmed that Qt5 print dialog provides the options we have here?
Otherwise it shouldn't go to kde4support, no?
Kevin Ottens wrote:
Yes it should, it shouldn't be in our API. Of course, someone should fix
Qt5 or our
On June 11, 2013, 9:07 a.m., Kevin Ottens wrote:
This change go in. Note that I disagree with the aim though: KWidgets
should *not* depend on KIconThemes. Now having KIconThemes not use
KGlobalSettings is completely welcome (aim being to have KGlobalSettings in
kde4support at some
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110957/
---
(Updated June 11, 2013, 6:30 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110815/#review34172
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110815/
---
(Updated June 11, 2013, 6:37 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110963/
---
(Updated June 11, 2013, 6:38 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110963/
---
(Updated June 11, 2013, 6:38 p.m.)
Review request for KDE Frameworks.
Hi,
2013/6/11 Kevin Ottens:
[...]
* ItemViews will be tier 2 until we contribute the natural compare to Qt;
I thought that Qt 5.1 will have the QCollator class, which can perform
natural comparison of strings if you use numeric mode?
Cheers,
Frank
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110957/#review34181
---
Ship it!
- David Faure
On June 11, 2013, 6:30 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110957/#review34182
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110957/
---
(Updated June 11, 2013, 8 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110874/
---
(Updated June 11, 2013, 9:11 p.m.)
Status
--
This change has been
See http://build.kde.org/job/kdelibs_frameworks_qt5/705/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110876/
---
(Updated June 11, 2013, 10:10 p.m.)
Review request for KDE Frameworks.
44 matches
Mail list logo
