Re: kde_file.h vs POSIX headers vs qplatformdefs.h

On Thursday 08 August 2013 18:48:36 Aurélien Gâteau wrote: > Le jeudi 8 août 2013 18:27:00 Kevin Ottens a écrit : > > In fact that's more my worry with the current introductions of > > qplatformdefs.h... Maybe we'd be better off using QFile/QFileInfo in most > > case and use qplatformdefs.h only wh

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- (Updated Aug. 9, 2013, 7:20 a.m.) Review request for KDE Frameworks, Plasm

Build failed in Jenkins: plasma-framework_master_qt5 #569

See Changes: [sebas] Reduce KDE4 usage in cmake setup -- [...truncated 487 lines...] Generating moc_declarativeappletscript.cpp [ 13%] Built target plasma_appletscript_declarative_automoc S

Build failed in Jenkins: plasma-framework_master_qt5 #568

See Changes: [sebas] plasma_add_plugin macro to simplify plugin installation [sebas] Refined porting scripts [sebas] remove last remains of kdebug -- [...truncated 486 lines...] Generatin

Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #999

On Thursday 08 August 2013 09:52:08 KDE CI System wrote: > See * kptyprocesstest is unstable in test_shared_pty. I can reproduce that by running the test in a loop in the master branch too, though, so it's not introduced by Qt5 nor KF5. FAIL!

Re: Review Request 111877: desktop_to_json cmake macro

> On Aug. 8, 2013, 3:18 p.m., Kevin Ottens wrote: > > staging/kservice/KServiceMacros.cmake, line 33 > > > > > > Typo, should be ".json" and not "Json" I think. This is just for sanitizing the target, not for the

Re: Review Request 111877: desktop_to_json cmake macro

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111877/ --- (Updated Aug. 8, 2013, 10:26 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111912/ --- (Updated Aug. 9, 2013, 12:03 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111912/ --- (Updated Aug. 8, 2013, 11:46 p.m.) Review request for KDE Frameworks. Ch

Build failed in Jenkins: kdelibs_frameworks_qt5 #1006

See Changes: [sebas] Fix build after filemetadata move -- [...truncated 3986 lines...] Scanning dependencies of target openurltest Scanning dependencies of target kmodifierkeyinfotest [ 40%] Bu

[kdelibs/frameworks] staging/kde4support/src: Fix build after filemetadata move

Git commit f570c881ede5a08c11ea6f4d656c6575abaa7e0e by Sebastian Kügler. Committed on 08/08/2013 at 21:36. Pushed by sebas into branch 'frameworks'. Fix build after filemetadata move - replace KIO_EXPORT with KDE4SUPPORT_EXPORT - replace KIO_DEPRECATED with KDE4SUPPORT_EXPORT - add strigi libs to

Build failed in Jenkins: kdelibs_frameworks_qt5 #1005

See Changes: [dhaumann] remove KTextEditor images for API documentation, will move them to kate.git -- [...truncated 3972 lines...] [ 38%] Scanning dependencies of target kwordwraptest Buildin

Build failed in Jenkins: plasma-framework_master_qt5 #567

See Changes: [notmart] remove view::init -- [...truncated 570 lines...] :257:63: warning: ‘KPluginInfo:

Build failed in Jenkins: kdelibs_frameworks_qt5 #1004

See Changes: [aleixpol] KFileMetaData (and friends) to kde4support -- [...truncated 4016 lines...] In file included from

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/ --- (Updated Aug. 8, 2013, 5:33 p.m.) Status -- This change has been mark

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/#review37368 --- This review has been submitted with commit 8864e2a0426e3f1c053

Re: kde_file.h vs POSIX headers vs qplatformdefs.h

Le jeudi 8 août 2013 18:27:00 Kevin Ottens a écrit : > Hello, > > On Thursday 08 August 2013 16:56:23 Aurélien Gâteau wrote: > > I started working on a kdelibs cleanup task: > > > > "Make use of qplatformdefs.h definitions instead of using the POSIX > > versions directly. Partly revert that commi

Re: kde_file.h vs POSIX headers vs qplatformdefs.h

On Thu, Aug 8, 2013 at 4:56 PM, Aurélien Gâteau wrote: > Hi, > > I started working on a kdelibs cleanup task: > > "Make use of qplatformdefs.h definitions instead of using the POSIX > versions > directly. Partly revert that commit, that would port to QFile::Permissions: > b03e81a61311ae1b64b0d374

Jenkins build became unstable: kdelibs_frameworks_qt5 #1003

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kdelibs-frameworks i386 build failiures

> kdecore/CMakeLists.txt says > target_compile_definitions(kdecore PUBLIC -D_FILE_OFFSET_BITS=64) > Maybe you want to move that to kioslave/file? It's the only user of off_t. > Moving it to kioslave/file/CMakeLists.txt did indeed fix this issue. Should I go ahead and commit the patch [1] ? Maybe

Re: kde_file.h vs POSIX headers vs qplatformdefs.h

Hello, On Thursday 08 August 2013 16:56:23 Aurélien Gâteau wrote: > I started working on a kdelibs cleanup task: > > "Make use of qplatformdefs.h definitions instead of using the POSIX versions > directly. Partly revert that commit, that would port to QFile::Permissions: > b03e81a61311ae1b64b0d37

Re: Review Request 111895: Fix Sonnet failing to load its plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111895/ --- (Updated Aug. 8, 2013, 4:19 p.m.) Status -- This change has been mark

Re: Review Request 111895: Fix Sonnet failing to load its plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111895/#review37364 --- This review has been submitted with commit 143d3b0db3412aebf84

Re: Review Request 111943: Port to qplatformdefs.h: stat() and fopen() calls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111943/ --- (Updated Aug. 8, 2013, 6:16 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/#review37363 --- Ship it! - Kevin Ottens On Aug. 8, 2013, 11:59 a.m., Aleix P

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111945/ --- (Updated Aug. 8, 2013, 4:09 p.m.) Review request for KDE Frameworks. Des

Build failed in Jenkins: plasma-framework_master_qt5 #566

See Changes: [notmart] load the wallpaper before setting the screen -- [...truncated 570 lines...] In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/in

Re: Review Request 111943: Port to qplatformdefs.h: stat() and fopen() calls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111943/#review37361 --- staging/kde4support/src/kdecore/k3resolvermanager.cpp

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review37360 --- Totally makes sense to have that in KConfigGui. Still the issue

Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111945/ --- Review request for KDE Frameworks. Description --- Task from kdelibs

Re: Review Request 111942: Return removed config includes from file kioslave

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111942/ --- (Updated Aug. 8, 2013, 3:48 p.m.) Status -- This change has been mark

Re: Review Request 111942: Return removed config includes from file kioslave

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111942/#review37359 --- This review has been submitted with commit c873fb384d21137b235

Re: Review Request 111942: Return removed config includes from file kioslave

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111942/#review37358 --- Ship it! Ship It! - Kevin Ottens On Aug. 8, 2013, 12:06 p.m

Re: Review Request 111916: Port khtml_part away from kde_file.h

> On Aug. 7, 2013, 4:12 p.m., David Faure wrote: > > This code should be made portable (to Windows), please use QFileInfo. As far as I know the QT_* macros would work on windows too. Using QFileInfo would be way nicer though. - Kevin -

Re: Review Request 111906: Update QToolbar's when icon changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111906/#review37354 --- staging/frameworkintegration/src/platformtheme/kdeplatformthem

Build failed in Jenkins: plasma-framework_master_qt5 #565

See Changes: [notmart] make really sure the wallpaper is loaded only once -- [...truncated 571 lines...] from

Re: Review Request 111895: Fix Sonnet failing to load its plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111895/#review37352 --- Ship it! Ship It! - Kevin Ottens On Aug. 5, 2013, 4:11 p.m.

Re: Review Request 111877: desktop_to_json cmake macro

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111877/#review37351 --- staging/kservice/KServiceMacros.cmake

Re: Review Request 111675: Port away from kde_file in KRecentDocument (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111675/#review37350 --- Hello David, any chance for a second revision of that patch? -

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/#review37349 --- Hello David, any chance for a second revision of that patch? -

kde_file.h vs POSIX headers vs qplatformdefs.h

Hi, I started working on a kdelibs cleanup task: "Make use of qplatformdefs.h definitions instead of using the POSIX versions directly. Partly revert that commit, that would port to QFile::Permissions: b03e81a61311ae1b64b0d37415477f9c08fe6142" I have a few questions however: 1. I am not exact

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/#review37348 --- Ship it! seems good to me, but it would be nice if someone els

Review Request 111943: Port to qplatformdefs.h: stat() and fopen() calls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111943/ --- Review request for KDE Frameworks. Description --- This patch ports s

Build failed in Jenkins: plasma-framework_master_qt5 #564

See Changes: [notmart] the scriptengine has an uiReady property -- [...truncated 571 lines...] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:434:70

Build failed in Jenkins: plasma-framework_master_qt5 #563

See Changes: [notmart] remove include() -- [...truncated 571 lines...] In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/qtest_kde.h:30:0,

Build failed in Jenkins: plasma-framework_master_qt5 #562

See Changes: [notmart] remove loadui/loadservice -- [...truncated 570 lines...] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:995:40: warning: ‘KUrl’ is d

Build failed in Jenkins: plasma-framework_master_qt5 #561

See Changes: [notmart] remove configChanged() -- [...truncated 572 lines...] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1150:1: warning: ‘List’ is depr

Build failed in Jenkins: plasma-framework_master_qt5 #560

See Changes: [notmart] port to new connect syntax -- [...truncated 571 lines...] :0: Note: No releva

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- (Updated Aug. 8, 2013, 2:56 p.m.) Review request for KDE Frameworks, Plasm

Review Request 111942: Return removed config includes from file kioslave

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111942/ --- Review request for KDE Frameworks. Description --- While porting away

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/ --- (Updated Aug. 8, 2013, 11:59 a.m.) Review request for KDE Frameworks and V

Build failed in Jenkins: plasma-framework_master_qt5 #559

See Changes: [notmart] convert a bunch of connects to new syntax -- [...truncated 572 lines...] Linking CXX shared library ../../../lib/libdirmodelplugin.so [ 21%] Building CXX object src/

Build failed in Jenkins: plasma-framework_master_qt5 #558

See Changes: [notmart] remove relkeaseVisualFocus, was unused and not belonging to Applet -- [...truncated 571 lines...] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/inc

Re: KFileItem (Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982)

Hi David, 2013/8/7 David Faure: > On Tuesday 06 August 2013 20:53:05 Frank Reininghaus wrote: >> OK, I see now that it uses pointers to be able to modify the actual >> KFileItems in KDirListerCache (if it would just keep KFileItems and >> modify these, I guess that they would just detach from the

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/#review37335 --- You're moving kfilemetainfo but not predicateproperties? Isn't

Re: Review Request 111886: Stop using kde_file.h in kdesu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111886/#review37331 --- This review has been submitted with commit 1eff5a6734b4a7b820b

Re: Review Request 111886: Stop using kde_file.h in kdesu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111886/ --- (Updated Aug. 8, 2013, 10:45 a.m.) Status -- This change has been mar

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1000

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kdelibs_frameworks_qt5 #999

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kdelibs_frameworks_qt5 #998

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #997

See Changes: [faure] QUrlPathInfo::equals -> QUrl::matches (recently added to QUrl) -- [...truncated 4054 lines...] [ 33%] Building C object staging/kcrash/src/CMakeFiles/KCrash.dir/strlcpy-fak

Re: kdelibs-frameworks i386 build failiures

On Thursday 08 August 2013 10:39:25 Rohan Garg wrote: > Hi > It seems like the frameworks branch of kdelibs is currently failing on > i386 with the following failure : > > /build/buildd/project-neon5-kdelibs-0.0+git20130808+r96198~736598e+neon11~sa > ucy1/kioslave/file/file_unix.cpp: In member fun

Build failed in Jenkins: kdelibs_frameworks_qt5 #996

See Changes: [mklapetek] Deprecate unused methods + enum values in KEMailSettings -- [...truncated 4044 lines...] [ 33%] [ 33%] [ 33%] Building CXX object staging/kguiaddons/tests/CMakeFiles/km

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

> On Aug. 7, 2013, 3:41 p.m., David Faure wrote: > > tier1/kconfig/autotests/kconfigloadertest.cpp, line 56 > > > > > > I have trouble understanding the purpose of this class. How is this > > different from > >

Re: Review Request 111910: Deprecate unused methods + enum values in KEMailSettings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111910/#review37319 --- This review has been submitted with commit 98966d12125c8414ce7

Re: Review Request 111910: Deprecate unused methods + enum values in KEMailSettings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111910/ --- (Updated Aug. 8, 2013, 8:20 a.m.) Status -- This change has been mark

Re: Notes from Frameworks5 Promo BoF at Akademy

On Wednesday 07 August 2013 14:03:54 Jos Poortvliet wrote: > On Wednesday 31 July 2013 12:54:53 Jos Poortvliet wrote: > > Heya, > > > > I know it's late and perhaps somebody already send these, but if not, here > > they are: the notes of the Frameworks5Communication BoF at Akademy 2013. > > > > I

Re: Review Request 111910: Deprecate unused methods + enum values in KEMailSettings

> On Aug. 7, 2013, 4:25 p.m., David Faure wrote: > > Thanks for that review. > > > > So, profiles() and setProfile() are used? For which purpose? > > Martin Klapetek wrote: > profiles() is used quite extensively in kdepim, it iterates over profiles > looking for an email address (aka "is t

Re: Notes from Frameworks5 Promo BoF at Akademy

On Wednesday 31 July 2013 12:54:53 Jos Poortvliet wrote: > Heya, > > I know it's late and perhaps somebody already send these, but if not, here > they are: the notes of the Frameworks5Communication BoF at Akademy 2013. > > I will just link to the notes, as that's the easiest for all - and it can

Re: RFC: spell checking for QTextEdit

On Wed, Aug 7, 2013 at 10:13 AM, Aurélien Gâteau wrote: > Hi, > > I'd like to reach a decision regarding spell checking for QTextEdit. > > It was initially a Qt5 task: > > "Allow to register a default syntax highlighter type for QTextEdit, the KDE > backend would register the spell checking one c