Re: Concerns about deprecating KFileDialog

2013-08-23 Thread Martin Graesslin
On Saturday 24 August 2013 00:12:09 Andrius da Costa Ribas wrote: > Hello, > > (crosspost between kde-frameworks-devel and kde-windows) > > I've posted a question in a recent review request that deprecates > KFileDialog in favor of QFileDialog for KF5, however this question got > probably unnotic

Concerns about deprecating KFileDialog

2013-08-23 Thread Andrius da Costa Ribas
Hello, (crosspost between kde-frameworks-devel and kde-windows) I've posted a question in a recent review request that deprecates KFileDialog in favor of QFileDialog for KF5, however this question got probably unnoticed (as no one responded and later the review got submitted). My concern about d

Re: Review Request 112175: Implement Ctrl+Enter dialog acceptation in KStyle::polish()

2013-08-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112175/ --- (Updated Aug. 23, 2013, 11:27 p.m.) Review request for KDE Frameworks. C

Review Request 112229: Port bunch of POSIX calls to qplatformdefs.h calls

2013-08-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112229/ --- Review request for KDE Frameworks. Description --- Removes more of di

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1068

2013-08-23 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 112225: Port ::mmap to QT_MMAP

2013-08-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112225/ --- Review request for KDE Frameworks. Description --- Simple port of ::m

Re: Smart D-Ptr in KCoreAddons

2013-08-23 Thread Ivan Čukić
> > P1, P2 are your preference. Why do you even need to care about access > to the raw pointer. The d_ptr/make_unique pointer is stored as private > class member anyway. I don't see the need for those but that might > also be because i just don't know enough in that area. If you could > explain t

Re: Smart D-Ptr in KCoreAddons

2013-08-23 Thread Ivan Čukić
> The few cases where I have needed d-ptr hierachies, I didn't know about > it in advance but was happy than I could extend my classes without having > to use a different smartpointer (with possibly a different size). Exactly. The *few* cases. Most of our higher-level code do not use and do not

Re: Smart D-Ptr in KCoreAddons

2013-08-23 Thread Sune Vuorela
On 2013-08-23, Ivan Čukić wrote: >> oh. and I think it also looks a bit like your d-ptr gets in the way when >> you need a d-ptr hierachy. > > As I said, this is for non-inherited privates. That alone is - I think - a reason to not have it. The few cases where I have needed d-ptr hierachies,

Re: Smart D-Ptr in KCoreAddons

2013-08-23 Thread Mark
On Fri, Aug 23, 2013 at 8:49 AM, Ivan Čukić wrote: > >> The paper that describes make_unique - and contains an implementation >> - can be found here [1]. For reference, the full code to have >> make_unique ready to paste in any file is here [2]. > > Make unique is only a method to create a std::un

K_PLUGIN_FACTORY changes explained

2013-08-23 Thread Sebastian Kügler
Hey, I've written a somewhat lengthy and detailed article about the changes to our plugin system: http://vizzzion.org/blog/2013/08/kde-frameworks-5-plugin-factory-guts/ Thought it might be interesting for many people here. :) Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Ke

Re: KFileItem (Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982)

2013-08-23 Thread Frank Reininghaus
Hi, 2013/8/22 David Faure: > On Thursday 08 August 2013 13:17:18 Frank Reininghaus wrote: >> Hi David, >> >> 2013/8/7 David Faure: >> > On Tuesday 06 August 2013 20:53:05 Frank Reininghaus wrote: >> >> OK, I see now that it uses pointers to be able to modify the actual >> >> KFileItems in KDirList

Re: Smart D-Ptr in KCoreAddons

2013-08-23 Thread Ivan Čukić
> I honestly don't see what it actually brings us over using > QScopedPointer. It gives safety and convenience - and they are actually > also spiffy. QSP is as spiffy as a unique_ptr: > std::unique_ptr with make_unique does not provide P1, P2, P5 and P4. > P1 - safety: no access to the raw poin

Re: Review Request 112217: copy KStyle as K4Style in KDE4Support

2013-08-23 Thread Wojciech Kapuscinski
> On Aug. 23, 2013, 12:39 a.m., Aleix Pol Gonzalez wrote: > > You can use "git diff -M80%" instead of --find-copies-harder, then > > reviewboard doesn't complain. The semantics are a bit different but it will > > work for you, hopefully. > > > > Cheers! It doesn't :( Without --find-copies-har

Re: Review Request 112079: Add utility function to paint icon overlays

2013-08-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/ --- (Updated Aug. 23, 2013, 9:25 a.m.) Review request for KDE Frameworks. Ch

kfiledialog.h references non-existent kfile.h

2013-08-23 Thread Treeve Jelbert
#ifndef KFILEDIALOG_H #define KFILEDIALOG_H #include #include #include #include #include In file included from /opt/qt5/include/KDE/KFileDialog:1:0, from /var/git/kwin5/plasma/generic/wallpapers/image/image.cpp:27: /opt/qt5/include/KDE/../kfiledialog.h:32:19: fatal error:

Re: Review Request 112079: Add utility function to paint icon overlays

2013-08-23 Thread Martin Klapetek
> On Aug. 17, 2013, 8:39 p.m., Nicolás Alvarez wrote: > > staging/kguiaddons/src/util/qiconoverlay.h, line 31 > > > > > > What about calling this one "AddOverlays", in plural? Dunno, I never much liked different m

Re: Review Request 112079: Add utility function to paint icon overlays

2013-08-23 Thread Martin Klapetek
> On Aug. 14, 2013, 3 p.m., Aurélien Gâteau wrote: > > staging/kguiaddons/src/util/qiconoverlay.cpp, line 33 > > > > > > Should be const The virtual engine method is not const (nor is QIcon::actualSize()), so that

Re: Smart D-Ptr in KCoreAddons

2013-08-23 Thread Sune Vuorela
On 2013-08-22, Ivan Čukić wrote: > We had some discussions on plasma-devel regarding the use of a smart non- > inherited D-Pointer[1] and Kevin proposed moving the pointer into KCoreAddons. > The only listed downside of including it into plasma is that it is too low > level and generic to belong

Re: Smart D-Ptr in KCoreAddons

2013-08-23 Thread Ivan Čukić
> The paper that describes make_unique - and contains an implementation > - can be found here [1]. For reference, the full code to have > make_unique ready to paste in any file is here [2]. Make unique is only a method to create a std::unique_ptr, and it doesn't provide (or, rather, inhibit) the

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-23 Thread Martin Graesslin
On Friday 23 August 2013 09:14:05 David Faure wrote: > On Friday 23 August 2013 06:51:23 Martin Graesslin wrote: > > Given that it's already lots of work to keep up with the constant breakage > > due to changes in frameworks the outlook of also having breakage in cmake > > is nothing I look forwar

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-23 Thread Ben Cooksley
On Fri, Aug 23, 2013 at 7:14 PM, David Faure wrote: > On Friday 23 August 2013 06:51:23 Martin Graesslin wrote: >> Given that it's already lots of work to keep up with the constant breakage >> due to changes in frameworks the outlook of also having breakage in cmake >> is nothing I look forward t

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-23 Thread David Faure
On Friday 23 August 2013 06:51:23 Martin Graesslin wrote: > Given that it's already lots of work to keep up with the constant breakage > due to changes in frameworks the outlook of also having breakage in cmake > is nothing I look forward to. FWIW, I've been using cmake master for many years, and