Build failed in Jenkins: plasma-framework_master_qt5 #781

2013-10-04 Thread KDE CI System
See Changes: [sebas] Reenable tests in declarativeimports [sebas] Port Plasma::Svg away from KGlobalSettings [sebas] Port theme away from KGlobalSettings [sebas] Port declarative theme away from KGlobalSettings` [sebas] remove

Jenkins build is back to normal : plasma-framework_master_qt5 #780

2013-10-04 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #779

2013-10-04 Thread KDE CI System
See Changes: [sebas] lower case headers [sebas] Port away from KStandardDirs [sebas] lower case headers [sebas] lower case headers [sebas] find KDELibs4 -- [...truncated 669 lines...] [

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

2013-10-04 Thread Casian Andrei
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113091/ --- (Updated Oct. 5, 2013, 1:59 a.m.) Status -- This change has been mark

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113091/#review41264 --- This review has been submitted with commit 346e174285032486545

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

2013-10-04 Thread Kurt Hindenburg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113091/#review41263 --- Thanks - it appears to fix the kbookmark build - I'm getting th

Re: Review Request 113112: Notify about palette changes

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/#review41262 --- Uh, just realized ingenuous doesn't mean what I thought, I gues

Re: Review Request 113112: Notify about palette changes

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/ --- (Updated Oct. 5, 2013, 12:14 a.m.) Review request for KDE Frameworks, Àlex

Re: Review Request 113110: Move KNotifyConfig to staging

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113110/#review41260 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 4, 2013, 8:3

Re: Review Request 113112: Notify about fonts and palette changes

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/#review41259 --- staging/frameworkintegration/src/platformtheme/kfontsettingsda

Review Request 113112: Notify about fonts and palette changes

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/ --- Review request for KDE Frameworks, Àlex Fiestas and Sebastian Kügler. Repo

Jenkins build is back to normal : plasma-framework_master_qt5 #776

2013-10-04 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt 5.2, test failures and rebuilds

2013-10-04 Thread Aurélien Gâteau
On Saturday 05 October 2013 08:52:27 you wrote: > On Sat, Oct 5, 2013 at 2:12 AM, Aurélien Gâteau wrote: > > Hi, > > Hi Aurélien, > > > I spent a bit of time this morning investigating why the khtmlparttest was > > failing on build.kde.org after its Qt copy was switched to 5.2 [1]. > > > > Erro

Review Request 113110: Move KNotifyConfig to staging

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113110/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113105: Move KWallet to tier2

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113105/#review41252 --- Ship it! Ship It! - David Edmundson On Oct. 4, 2013, 6:17 p

Re: Qt 5.2, test failures and rebuilds

2013-10-04 Thread Ben Cooksley
On Sat, Oct 5, 2013 at 2:12 AM, Aurélien Gâteau wrote: > Hi, Hi Aurélien, > > I spent a bit of time this morning investigating why the khtmlparttest was > failing on build.kde.org after its Qt copy was switched to 5.2 [1]. > > Error looked very strange: > > QMetaType::registerType: Binary compat

Review Request 113105: Move KWallet to tier2

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113105/ --- Review request for KDE Frameworks and Valentin Rusu. Repository: kdelibs

Re: kio-related build error in plasma-framework

2013-10-04 Thread Sebastian Kügler
On Friday, October 04, 2013 17:56:52 Sebastian Kügler wrote: > Hi, > > I'm getting a build error in a few places in plasma-framework, kio isn't > found. I can't seem to figure out why, maybe someone who has a better > overview of what in KIO is where, and what I need to tell cmake to figure > this

Re: Review Request 113008: Clean up KWallet before moving to its own tier

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113008/ --- (Updated Oct. 4, 2013, 5:29 p.m.) Status -- This change has been mark

Re: Review Request 113008: Clean up KWallet before moving to its own tier

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113008/#review41236 --- This review has been submitted with commit 4e534c2961b7190bc3d

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Oct. 4, 2013, 5:26 p.m.) Review request for KDE Frameworks, Frank

Build failed in Jenkins: plasma-framework_master_qt5 #775

2013-10-04 Thread KDE CI System
See Changes: [sebas] cmake fixes -- [...truncated 603 lines...] /srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:316:71: warning: ‘List’ is deprecated (decla

Review Request 113100: Move KDESu to tier3

2013-10-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113100/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Build failed in Jenkins: plasma-framework_master_qt5 #774

2013-10-04 Thread KDE CI System
See Changes: [hein] Adapt to kdelibs ab56e2f. -- [...truncated 510 lines...] Generating moc_panelshadows_p.cpp Generating moc_panelview.cpp Generating appinterface.moc

Build failed in Jenkins: kdelibs_frameworks_qt5 #1346

2013-10-04 Thread KDE CI System
See Changes: [aleixpol] KDeclarative cleanup -- [...truncated 64701 lines...] -- Installing:

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/ --- (Updated Oct. 4, 2013, 4:26 p.m.) Status -- This change has been mark

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41235 --- This review has been submitted with commit ab56e2f383b4e55a7af

kio-related build error in plasma-framework

2013-10-04 Thread Sebastian Kügler
Hi, I'm getting a build error in a few places in plasma-framework, kio isn't found. I can't seem to figure out why, maybe someone who has a better overview of what in KIO is where, and what I need to tell cmake to figure this out? The error is: /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x

Review Request 113097: KInit splitting

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113097/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

2013-10-04 Thread Casian Andrei
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113091/ --- (Updated Oct. 4, 2013, 2:35 p.m.) Review request for KDE Frameworks and Da

Build failed in Jenkins: kdelibs_frameworks_qt5 #1344

2013-10-04 Thread KDE CI System
See Changes: [mklapetek] Prepare CMakeLists.txt for moving KDESu -- [...truncated 64686 lines...] -- Installing:

Build failed in Jenkins: kdelibs_frameworks_qt5 #1343

2013-10-04 Thread KDE CI System
See Changes: [kde] Prepare kpty for moving -- [...truncated 16909 lines...] from

Re: Review Request 113094: Last CMake changes for KDESu

2013-10-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113094/ --- (Updated Oct. 4, 2013, 1:46 p.m.) Status -- This change has been mark

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/#review41229 --- This review has been submitted with commit ebbf43004f9874c25d5

Re: Review Request 113094: Last CMake changes for KDESu

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113094/#review41230 --- This review has been submitted with commit 75321bcb9d146b0e362

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/ --- (Updated Oct. 4, 2013, 1:46 p.m.) Status -- This change has been mark

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/#review41228 --- Ship it! Ship It! - Martin Klapetek On Oct. 4, 2013, 1:43 p

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/ --- (Updated Oct. 4, 2013, 1:43 p.m.) Review request for KDE Frameworks. Rep

Qt 5.2, test failures and rebuilds

2013-10-04 Thread Aurélien Gâteau
Hi, I spent a bit of time this morning investigating why the khtmlparttest was failing on build.kde.org after its Qt copy was switched to 5.2 [1]. Error looked very strange: QMetaType::registerType: Binary compatibility break -- Size mismatch for type 'QtMetaTypePrivate::QSequentialIterableImp

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Sebastian Kügler
> On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote: > > Looking good, lots of incremental improvements, too. > > > > I suppose we need to adjust the linker targets in plasma-framework and > > kde-workspace, too? If you don't have a patch for that as well, let me > > know, and I'll change it

CMake templates

2013-10-04 Thread Aurélien Gâteau
Hi, In case you missed them, CMake templates for frameworks were merged into the frameworks branch yesterday. You can now find a "template" dir in "kdelibs", with all the necessary scaffolding to create a new framework. These template files can be used for two things: - To create new framework

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aleix Pol Gonzalez
> On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote: > > Looking good, lots of incremental improvements, too. > > > > I suppose we need to adjust the linker targets in plasma-framework and > > kde-workspace, too? If you don't have a patch for that as well, let me > > know, and I'll change it

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aleix Pol Gonzalez
> On Oct. 4, 2013, 12:08 p.m., Marco Martin wrote: > > experimental/kdeclarative/bindings/backportglobal.h, line 24 > > > > > > backportglobal should be not needed anymore since we don't have > > qscriptengine any

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/#review41223 --- kpty/CMakeLists.txt

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/ --- (Updated Oct. 4, 2013, 12:14 p.m.) Review request for KDE Frameworks. Re

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41220 --- Ship it! +1 for taking care of this. I'm noticing now there a

Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

2013-10-04 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113095/ --- (Updated Oct. 4, 2013, 12:02 p.m.) Status -- This change has been mar

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/#review41218 --- kpty/tests/CMakeLists.txt

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/#review41217 --- kpty/CMakeLists.txt

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113088/ --- (Updated Oct. 4, 2013, 11:52 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Sebastian Kügler
> On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote: > > Looking good, lots of incremental improvements, too. > > > > I suppose we need to adjust the linker targets in plasma-framework and > > kde-workspace, too? If you don't have a patch for that as well, let me > > know, and I'll change it

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41215 --- Ship it! Looking good, lots of incremental improvements, too.

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41214 --- Nothing serious, just some nitpicking. experimental/kdeclarat

Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

2013-10-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113095/#review41213 --- Ship it! Ship It! - David Faure On Oct. 4, 2013, 11:25 a.m.

Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

2013-10-04 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113095/ --- (Updated Oct. 4, 2013, 11:25 a.m.) Review request for KDE Frameworks, Davi

Re: Review Request 113090: Move kcmutils to tier4

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113090/ --- (Updated Oct. 4, 2013, 11:18 a.m.) Status -- This change has been mar

Re: Review Request 113090: Move kcmutils to tier4

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113090/#review41211 --- This review has been submitted with commit f290ee6dcdb6ce89475

Re: Review Request 113094: Last CMake changes for KDESu

2013-10-04 Thread Martin Klapetek
> On Oct. 4, 2013, 10:54 a.m., Aleix Pol Gonzalez wrote: > > staging/kdesu/src/CMakeLists.txt, line 36 > > > > > > I think now it's "kpty". Does it build? It does not build yet, I'll wait for David to push his cha

Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113095/#review41205 --- staging/kde4support/src/kssl/kcm/cacertificatespage.cpp

Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

2013-10-04 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113095/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Repositor

Re: Review Request 113090: Move kcmutils to tier4

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113090/#review41203 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 4, 2013, 9:1

Re: Review Request 113094: Last CMake changes for KDESu

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113094/#review41201 --- Ship it! staging/kdesu/src/CMakeLists.txt

Review Request 113094: Last CMake changes for KDESu

2013-10-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113094/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

2013-10-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113091/#review41200 --- src/BookmarkHandler.h

Review Request 113090: Move kcmutils to tier4

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113090/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

2013-10-04 Thread Casian Andrei
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113091/ --- Review request for KDE Frameworks and David Faure. Repository: konsole D

Re: Review Request 113045: Prepare KCMUtils for move to tier3

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/ --- (Updated Oct. 4, 2013, 9:01 a.m.) Status -- This change has been mark

Re: Review Request 113045: Prepare KCMUtils for move to tier3

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/#review41199 --- This review has been submitted with commit 23782b73ef829d9b07d

Re: EcmQt4To5Porting

2013-10-04 Thread Martin Klapetek
On Fri, Oct 4, 2013 at 9:22 AM, David Faure wrote: > On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote: > > There were 2 files recently removed from ECM which broke attica's build, > > this puts the removed files as local cmake modules. > > > > > > Diffs > > - > > > > CMakeLists.t

Re: Review Request 113045: Prepare KCMUtils for move to tier3

2013-10-04 Thread David Edmundson
> On Oct. 4, 2013, 7 a.m., David Faure wrote: > > Looks good, but why don't we replace KCategoryDrawer with > > KCategoryDrawerV3, in itemviews? I.e. getting rid of the two oldest ones? > > It should be SC since v3 derives from v2 derives from v1. It's not entirely source compatible since the c

Re: EcmQt4To5Porting

2013-10-04 Thread Stephen Kelly
David Faure wrote: > On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote: >> There were 2 files recently removed from ECM which broke attica's build, >> this puts the removed files as local cmake modules. >> >> >> Diffs >> - >> >> CMakeLists.txt e0efb9b >> cmake/modules/ECMQt4To

EcmQt4To5Porting

2013-10-04 Thread David Faure
On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote: > There were 2 files recently removed from ECM which broke attica's build, > this puts the removed files as local cmake modules. > > > Diffs > - > > CMakeLists.txt e0efb9b > cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION >

Re: Review Request 113045: Prepare KCMUtils for move to tier3

2013-10-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/#review41196 --- Ship it! Looks good, but why don't we replace KCategoryDrawer