Re: Review Request 113426: Adjust API in KEmoticons framework: createNew method

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113426/ --- (Updated Oct. 24, 2013, 9:54 p.m.) Review request for KDE Frameworks. Re

KDirWatch vs QFileSystemWatcher

Hi If your KDirWatch backend is QFileSystemWatcher, one of the testcases fails. The last QVERIFY in testMoveTo never receives the signal dirty-signal it is looking for. Apparantly, the watch.removeFile apparantly somehow turns off the QFSW to not do any further notifications for what happens in

Review Request 113426: Adjust API in KEmoticons framework: createNew method

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113426/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113426: Adjust API in KEmoticons framework: createNew method

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113426/ --- (Updated Oct. 24, 2013, 9:54 p.m.) Review request for KDE Frameworks. Re

Re: Review Request 113424: Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec()

> On Oct. 24, 2013, 7:25 p.m., Alex Merry wrote: > > whoami is part of coreutils, so should be available everywhere. The only > > possible issue I see is that we've gone from a test that doesn't depend on > > PATH to one that does. This isn't necessarily a problem, but it will test > > sligh

Re: Review Request 113424: Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec()

> On Oct. 24, 2013, 4:25 p.m., Alex Merry wrote: > > whoami is part of coreutils, so should be available everywhere. The only > > possible issue I see is that we've gone from a test that doesn't depend on > > PATH to one that does. This isn't necessarily a problem, but it will test > > sligh

extra-cmake-modules: remove ECMPrintVariables.cmake

Hi, e-c-m has a macro ecm_print_variables() >From the documentation: # Example: # ecm_print_variables(CMAKE_C_COMPILER # CMAKE_MAJOR_VERSION THIS_ONE_DOES_NOT_EXIST) # Gives: # -- CMAKE_C_COMPILER="/usr/bin/gcc" ; CMAKE_MAJOR_VERSION="2" ; # THIS_ONE_DOES_NOT_EXIST=

Re: Review Request 113373: Enable C++11 support by default.

> On Oct. 21, 2013, 8:06 p.m., Stephen Kelly wrote: > > As far as I know, only threadweaver and karchive will be released in > > December. The rest of the frameworks won't be released until summer. > > > > By summer, CMake 3.0.0 will most likely be out. > > Volker Krause wrote: > while th

Re: Review Request 113424: Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113424/#review42320 --- Ship it! whoami is part of coreutils, so should be available e

Re: Review Request 113402: Fix KI18n standalone build

> On Oct. 23, 2013, 4:40 p.m., Chusslove Illich wrote: > > I can only say that whatever is the proper fix here, it is fine with me. > > Since non-installed headers are being used, maybe ki18n is using KJS in a > > way which became deprecated somewhere along the way? If so, I've nothing > > agains

Re: Review Request 113406: Add a macro to automatically generate forward headers

> On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 29 > > > > > > This variable shouldn't be needed at all. > > Aleix Pol Gonzalez wrote: > Variable? Or argument? Wh

Re: Review Request 113373: Enable C++11 support by default.

> On Oct. 21, 2013, 8:06 p.m., Stephen Kelly wrote: > > As far as I know, only threadweaver and karchive will be released in > > December. The rest of the frameworks won't be released until summer. > > > > By summer, CMake 3.0.0 will most likely be out. > > Volker Krause wrote: > while th

Re: Review Request 113406: Add a macro to automatically generate forward headers

> On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 11 > > > > > > I really think the answers to my questions here need to be found first: > > > > http://thread.

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Porting away from KLocale

El Dijous, 24 d'octubre de 2013, a les 17:44:01, Kevin Ottens va escriure: > On Thursday 24 October 2013 16:56:47 John Layt wrote: > > On 24 October 2013 07:33, Kevin Ottens wrote: > > > On Wednesday 23 October 2013 20:40:19 John Layt wrote: > > >> * The obviously place to move it is k18n, as eith

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113402: Fix KI18n standalone build

> On Oct. 23, 2013, 4:40 p.m., Chusslove Illich wrote: > > I can only say that whatever is the proper fix here, it is fine with me. > > Since non-installed headers are being used, maybe ki18n is using KJS in a > > way which became deprecated somewhere along the way? If so, I've nothing > > agains

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113373: Enable C++11 support by default.

> On Oct. 21, 2013, 8:06 p.m., Stephen Kelly wrote: > > As far as I know, only threadweaver and karchive will be released in > > December. The rest of the frameworks won't be released until summer. > > > > By summer, CMake 3.0.0 will most likely be out. > > Volker Krause wrote: > while th

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113402: Fix KI18n standalone build

> On Oct. 23, 2013, 4:40 p.m., Chusslove Illich wrote: > > I can only say that whatever is the proper fix here, it is fine with me. > > Since non-installed headers are being used, maybe ki18n is using KJS in a > > way which became deprecated somewhere along the way? If so, I've nothing > > agains

Re: Review Request 113423: Fix KConfigCompiler_Test::testRunning() on Windows

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113423/#review42298 --- Ship it! Ship It! tier1/kconfig/autotests/kconfig_compiler/k

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

> On Oct. 24, 2013, 4:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

> On Oct. 24, 2013, 6:17 p.m., Fredrik Höglund wrote: > > What's the cold startup time like for KSplashQML compared to KSplashX? > > > > Let's not forget that the reason KPlash was rewritten to only depend on > > X + libjpeg + libpng was so that the startup time would be limited by > > the time

Re: Review Request 113422: Port kconfigtest and kconfignokdehometest to QStandardPaths

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113422/#review42297 --- tier1/kconfig/autotests/kconfignokdehometest.cpp

Review Request 113423: Fix KConfigCompiler_Test::testRunning() on Windows

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113423/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113415/#review42299 --- What's the cold startup time like for KSplashQML compared to KS

Review Request 113424: Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113424/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113422: Port kconfigtest and kconfignokdehometest to QStandardPaths

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113422/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Porting away from KLocale

On Thursday 24 October 2013 16:56:47 John Layt wrote: > On 24 October 2013 07:33, Kevin Ottens wrote: > > On Wednesday 23 October 2013 20:40:19 John Layt wrote: > >> * The obviously place to move it is k18n, as either part of > >> KLocalizedString or in a new KByteFormatter class? > > > > Hm, wou

Re: Review Request 113406: Add a macro to automatically generate forward headers

> On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 29 > > > > > > This variable shouldn't be needed at all. Variable? Or argument? Why? > On Oct. 24, 2013, 1:54 p.m.,

Re: Porting away from KLocale

On 24 October 2013 07:33, Kevin Ottens wrote: > On Wednesday 23 October 2013 20:40:19 John Layt wrote: >> * The obviously place to move it is k18n, as either part of >> KLocalizedString or in a new KByteFormatter class? > > Hm, wouldn't that fit in KCoreAddons? >> * No locale file overrides the d

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113415/ --- (Updated Oct. 24, 2013, 2:19 p.m.) Status -- This change has been mar

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113415/#review42283 --- This review has been submitted with commit 90e2c0b65cce3f899d4

Re: Keep the Things You Forgot

On 24 October 2013 14:54, Mario Fux KDE ML wrote: >> You probably mean dot.kde.org/2013/09/25/frameworks-5 > > And this: > http://dot.kde.org/2013/09/04/kde-release-structure-evolves Yes, that explains Frameworks and Workspaces, albeit a little fuzzy on Workspaces vs Plasma, but it kinda leaves

Re: Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113415/#review42281 --- Ship it! Looks ok. It will need testing with the startkde/star

Review Request 113415: Port KSplashQML to Qt5 + remove XLib stuff + replace x11eventFilter with DBus interface (Wayland++)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113415/ --- Review request for kde-workspace and KDE Frameworks. Repository: kde-works

Re: Review Request 113406: Add a macro to automatically generate forward headers

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42280 --- modules/ECMGenerateHeaders.cmake

Re: Review Request 113373: Enable C++11 support by default.

> On Oct. 21, 2013, 8:06 p.m., Stephen Kelly wrote: > > As far as I know, only threadweaver and karchive will be released in > > December. The rest of the frameworks won't be released until summer. > > > > By summer, CMake 3.0.0 will most likely be out. > > Volker Krause wrote: > while th

Re: Review Request 113406: Add a macro to automatically generate forward headers

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 24, 2013, 1:40 p.m.) Review request for Build System, KDE Fr

Re: Keep the Things You Forgot

Am Donnerstag, 24. Oktober 2013, 14.02:16 schrieb Mark: Morning [snip] > You probably mean dot.kde.org/2013/09/25/frameworks-5 And this: http://dot.kde.org/2013/09/04/kde-release-structure-evolves > That would work but not if that's it. This kind of change is one that has > to sink in over ti

Some changes to buildsystem files

Hello, I've just pushed some changes to the buildsystem files. KF5 CMake config files no longer define a Foo_LIBRARIES variable. Instead the KF5::Foo should be used in target_link_libraries. I tested the build of plasma-frameworks, kactivities, konsole and kde- workspace after my changes and t

Re: Review Request 113402: Fix KI18n standalone build

> On Oct. 23, 2013, 2:40 p.m., Chusslove Illich wrote: > > I can only say that whatever is the proper fix here, it is fine with me. > > Since non-installed headers are being used, maybe ki18n is using KJS in a > > way which became deprecated somewhere along the way? If so, I've nothing > > agains

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- (Updated Oct. 24, 2013, 12:22 p.m.) Review request for KDE Frameworks. C

Re: Review Request 113402: Fix KI18n standalone build

> On Oct. 23, 2013, 4:40 p.m., Chusslove Illich wrote: > > I can only say that whatever is the proper fix here, it is fine with me. > > Since non-installed headers are being used, maybe ki18n is using KJS in a > > way which became deprecated somewhere along the way? If so, I've nothing > > agains

Re: Review Request 113402: Fix KI18n standalone build

> On Oct. 23, 2013, 4:40 p.m., Chusslove Illich wrote: > > I can only say that whatever is the proper fix here, it is fine with me. > > Since non-installed headers are being used, maybe ki18n is using KJS in a > > way which became deprecated somewhere along the way? If so, I've nothing > > agains

Re: Config files naming policy

On Wednesday 23 October 2013 19:37:21 Ivan Čukić wrote: > I guess I'll rename my config file then. I've been using activitymanagerrc, > while the binary was actually prefixed with a 'k' and suffixed with a 'd'. Hmm, if you use KGlobal::config() (in kde4) or KSharedConfig::openConfig() (in KF5), t

Re: Keep the Things You Forgot

Am Mittwoch, 23. Oktober 2013, 21.49:27 schrieb Mark: Morning [snip] > A blog post that i'd very much like from you (Aaron) is about the next > big KDE version, the naming and how the complete collection is going > to be called or if there even will be a collection release (what KDE > SC is now)

Re: kio kfilewidget.h problem

On Wednesday 23 October 2013 11:10:17 Treeve Jelbert wrote: > kio installs kfilewidget.h which references kio/kiofilewidgets_export.h > which is not installed Fixed, thanks for the report. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___

Re: Review Request 113370: move KDED to Tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113370/#review42261 --- kded/CMakeLists.txt