Re: KHTML Icons

2013-10-28 Thread Kevin Ottens
On Monday 28 October 2013 19:20:36 David Edmundson wrote: > KHtml tries to install icons in src/java/images and src/pics of the > khtml src directory. > > As far as I can tell this has been broken throughout all of KDE4. > kde4_install_icons simply ignores .xpm files, so they're just skipped. > My

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-28 Thread Stephen Kelly
> On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 32 > > > > > > I recommend not putting this in the API of the function, and instead > > users should use > > > >

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-10-28 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/#review42568 --- Looks much better, but it doesn't handle depth 30 pixmaps. ti

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 29, 2013, 12:32 a.m.) Review request for Build System, KDE F

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 29, 2013, 12:28 a.m.) Review request for Build System, KDE F

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-28 Thread Aleix Pol Gonzalez
> On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 32 > > > > > > I recommend not putting this in the API of the function, and instead > > users should use > > > >

Re: Review Request 113422: Port kconfigtest and kconfignokdehometest to QStandardPaths

2013-10-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113422/#review42554 --- This review has been submitted with commit de19c9f9cee8bc11df1

Re: Review Request 113424: Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec()

2013-10-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113424/#review42555 --- This review has been submitted with commit 9a1390c2b53415b7bef

Re: Review Request 113424: Use "whoami" as the command in KDesktopFileTest::testSuccessfulTryExec()

2013-10-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113424/ --- (Updated Oct. 28, 2013, 8:32 p.m.) Status -- This change has been mar

Re: Review Request 113423: Fix KConfigCompiler_Test::testRunning() on Windows

2013-10-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113423/ --- (Updated Oct. 28, 2013, 8:32 p.m.) Status -- This change has been mar

Re: Review Request 113422: Port kconfigtest and kconfignokdehometest to QStandardPaths

2013-10-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113422/ --- (Updated Oct. 28, 2013, 8:32 p.m.) Status -- This change has been mar

Re: Review Request 113423: Fix KConfigCompiler_Test::testRunning() on Windows

2013-10-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113423/#review42556 --- This review has been submitted with commit 0d44382caa78e3e17db

Re: Review Request 113479: fix kshareddatacache on windows

2013-10-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113479/#review42552 --- This review has been submitted with commit 23e1b357115cc3b5eb6

Re: Review Request 113479: fix kshareddatacache on windows

2013-10-28 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113479/ --- (Updated Oct. 28, 2013, 8:08 p.m.) Status -- This change has been mar

Review Request 113483: Copy KDE4 macro to install all icons in the current source dir

2013-10-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113483/ --- Review request for KDE Frameworks. Repository: extra-cmake-modules Descr

KHTML Icons

2013-10-28 Thread David Edmundson
KHtml tries to install icons in src/java/images and src/pics of the khtml src directory. As far as I can tell this has been broken throughout all of KDE4. kde4_install_icons simply ignores .xpm files, so they're just skipped. My main KDE4 install does not have these files. Given it's been broken

Re: Flaky kcodecs test depending on qt configuration

2013-10-28 Thread John Layt
On Thursday 24 Oct 2013 07:35:48 Kevin Ottens wrote: > Hello, > > On Wednesday 23 October 2013 21:43:59 Sune Vuorela wrote: > > Depending on the Qt configuration (built with or without ICU), the > > KCharsetsTest::testEncodingNames() test fails (in the #if) block. > > > > If Qt built with ICU, th

Re: Build failed in Jenkins: plasma-framework_master_qt5 #862

2013-10-28 Thread Sebastian Kügler
On Monday, October 28, 2013 17:27:14 Marco Martin wrote: > On Monday 28 October 2013 17:12:20 Kevin Ottens wrote: > > On Monday 28 October 2013 16:07:08 KDE CI System wrote: > > > See > > > > If someone has an idea about that failure on bu

Re: Review Request 113402: Fix KI18n standalone build

2013-10-28 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113402/ --- (Updated Oct. 28, 2013, 6:28 p.m.) Status -- This change has been mar

Re: Build failed in Jenkins: plasma-framework_master_qt5 #862

2013-10-28 Thread Marco Martin
On Monday 28 October 2013 17:12:20 Kevin Ottens wrote: > On Monday 28 October 2013 16:07:08 KDE CI System wrote: > > See > > If someone has an idea about that failure on build.kde.org that would be > welcome. I can't seem to reproduce it

Re: Build failed in Jenkins: plasma-framework_master_qt5 #862

2013-10-28 Thread Kevin Ottens
On Monday 28 October 2013 16:07:08 KDE CI System wrote: > See If someone has an idea about that failure on build.kde.org that would be welcome. I can't seem to reproduce it here, and I did a completely clean build... It's as if it was b

Build failed in Jenkins: plasma-framework_master_qt5 #862

2013-10-28 Thread KDE CI System
See -- [...truncated 345 lines...] Generating qiconitem.moc :0: Note: No relevant cla

Jenkins build became unstable: kdelibs_stable #875

2013-10-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113479: fix kshareddatacache on windows

2013-10-28 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113479/#review42533 --- Ship it! Looks good from here, the test you added even has a m

Review Request 113480: Move KnotifyConfig to tier 3

2013-10-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113480/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113402: Fix KI18n standalone build

2013-10-28 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113402/#review42531 --- Ship it! We need to move forward. Proper fix can be done later

Build failed in Jenkins: plasma-framework_master_qt5 #861

2013-10-28 Thread KDE CI System
See Changes: [ervin] Use the target now that KDE4Support exports one -- [...truncated 879 lines...] [ 12%] Automatic moc for target plasma-shell Generating dialog.moc

Re: Review Request 113402: Fix KI18n standalone build

2013-10-28 Thread Aurélien Gâteau
> On Oct. 23, 2013, 4:40 p.m., Chusslove Illich wrote: > > I can only say that whatever is the proper fix here, it is fine with me. > > Since non-installed headers are being used, maybe ki18n is using KJS in a > > way which became deprecated somewhere along the way? If so, I've nothing > > agains

Re: Review Request 113479: fix kshareddatacache on windows

2013-10-28 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113479/ --- (Updated Oct. 28, 2013, 10:07 a.m.) Review request for KDE Frameworks, kde

Re: Use of the WIN32 executable property

2013-10-28 Thread Sune Vuorela
On 2013-10-27, David Faure wrote: > I withdraw my objection then, I guess. Let them have a console, for easier > debugging. \o/ Let's get all windows test apps to get a console. /Sune ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.or

Re: Google Code-In

2013-10-28 Thread Sune Vuorela
On 2013-10-25, Kevin Ottens wrote: > Excellent! Could you get in touch with Lydia about it? I'd rather have = > a=20 > support role, but we need someone to keep track of things and you seem = > like a=20 > good candidate. :-) >=20 I've scrolled over kdeexamples and added 4 tasks. Ensure kdeexamp

Re: KDirWatch vs QFileSystemWatcher

2013-10-28 Thread Sune Vuorela
On 2013-10-28, David Faure wrote: > On Sunday 27 October 2013 22:02:18 Sune Vuorela wrote: >> Seems to still consistently failing here on windows :/ > > Good, consistency is good, we can debug that :) > > Can you apply this patch and try again, so I get more debug output? > > http://www.davidfaure

Re: KDirWatch vs QFileSystemWatcher

2013-10-28 Thread David Faure
On Sunday 27 October 2013 22:02:18 Sune Vuorela wrote: > Seems to still consistently failing here on windows :/ Good, consistency is good, we can debug that :) Can you apply this patch and try again, so I get more debug output? http://www.davidfaure.fr/2013/kcoreaddons_debug.diff > Yes. lines a