Review Request 113503: make dbus dependency optional in JobWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113503/ --- Review request for KDE Frameworks, kdelibs and Stephen Kelly. Repository:

Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir

On 2013-10-29, Alexander Neundorf wrote: > Good point. > As it is, IMO for being "ECM", it needs way more documentation. > It needs to be documented so that it can be used by people who know nothing > about KDE or KDE's icon scheme. > > Or should that be in the framework which deals with icon loa

Review Request 113500: make KNewStuff build on its own

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113500/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: KF5 Update Meeting Minutes 2013-w44

On Tue, Oct 29, 2013 at 4:59 PM, Kevin Ottens wrote: * dfaure is making progress toward killing libkio; > * he's waiting on mck182 to deal with KImageIO; > That's probably not me, I've not been doing anything around KImageIO :) Cheers -- Martin Klapetek | KDE Developer

Re: Review Request 113436: Deprecate KEmoticonsTheme methods

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113436/ --- (Updated Oct. 29, 2013, 7:06 p.m.) Status -- This change has been mar

Re: Review Request 113436: Deprecate KEmoticonsTheme methods

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113436/#review42660 --- This review has been submitted with commit 542693fff431af62bc1

Re: Review Request 113426: Adjust API in KEmoticons framework: createNew method

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113426/ --- (Updated Oct. 29, 2013, 7:01 p.m.) Status -- This change has been mar

Re: Review Request 113426: Adjust API in KEmoticons framework: createNew method

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113426/#review42659 --- This review has been submitted with commit 89d2b298dfe4b97b2e5

Re: Review Request 113498: Fix KCompletion standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113498/#review42651 --- Ship it! Ship It! - Kevin Ottens On Oct. 29, 2013, 2:37 p.m

Re: Review Request 113496: Move Kross from staging to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113496/#review42650 --- Ship it! Ship It! - Kevin Ottens On Oct. 29, 2013, 11:25 a.

Re: Review Request 113373: Enable C++11 support by default.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113373/#review42649 --- Ship it! As discussed earlier today on IRC. This patch will do

Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir

On Tuesday 29 October 2013 18:36:03 Alexander Neundorf wrote: > On Tuesday 29 October 2013, Stephen Kelly wrote: > > Kevin Ottens wrote: > > > Ship it! > > > > > > > > > Looks fine to me and is aligned with prior discussions. > > > > Note that it is named ECM_foo, but it contains hardcoded KDE i

Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir

On Tuesday 29 October 2013, Stephen Kelly wrote: > Kevin Ottens wrote: > > Ship it! > > > > > > Looks fine to me and is aligned with prior discussions. > > Note that it is named ECM_foo, but it contains hardcoded KDE icon theme > names. Good point. As it is, IMO for being "ECM", it needs way mo

Jenkins build is back to normal : plasma-framework_master_qt5 #863

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113370: move KDED to Tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113370/ --- (Updated Oct. 29, 2013, 4:39 p.m.) Status -- This change has been mar

Re: Review Request 113370: move KDED to Tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113370/#review42645 --- This review has been submitted with commit 43d5b1724f490cf31bf

KF5 Update Meeting Minutes 2013-w44

Hello everyone, This is the minutes of the Week 43 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, arichardson, d_ed, dfaure, dMaggot, jpwhiting, sebas, svuorela, teo, vHanda and myself. Announcement: * dfaure's and my sponsoring

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1532

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113370: move KDED to Tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113370/#review42638 --- Ship it! kded/CMakeLists.txt

Review Request 113498: Fix KCompletion standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113498/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Using KSSLSettings from KHTML

Currently KHTMLPart uses KSSLSettings from KIOCore It uses the methods: warnOnUnencrypted setWarnOnUnencrypted This class does not have the header exported in KIOCore, so whilst it builds now it will fail when we split. The CMakeLists.txt file of KIOCore has a comment kssl/ksslsettings.cpp

Build failed in Jenkins: kdelibs_frameworks_qt5 #1531

See Changes: [kde] KTHML: Remove unused icons -- [...truncated 8693 lines...] Building CXX object khtml/src/CMakeFiles/KHtml.dir/JSHTMLVideoElement.cpp.o Building CXX object khtml/src/CMakeFile

Re: Review Request 113497: Install kiofilewidgets_export.h in /kio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113497/ --- (Updated Oct. 29, 2013, 1:41 p.m.) Status -- This change has been mar

Re: Review Request 113497: Install kiofilewidgets_export.h in /kio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113497/#review42633 --- This review has been submitted with commit b3f1919205946fc72de

Re: Review Request 113328: Fix standalone build of kdoctools

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/ --- (Updated Oct. 29, 2013, 1:12 p.m.) Status -- This change has been mar

Re: Review Request 113328: Fix standalone build of kdoctools

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/#review42632 --- This review has been submitted with commit 7582c2b341c97362aab

Re: Review Request 113370: move KDED to Tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113370/ --- (Updated Oct. 29, 2013, 1:10 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113395: Enable KConfig on Windows

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/ --- (Updated Oct. 29, 2013, 12:58 p.m.) Status -- This change has been ma

Re: Review Request 113395: Enable KConfig on Windows

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42630 --- This review has been submitted with commit e91aa4ba3e6e5f3ca93

Re: Review Request 113497: Install kiofilewidgets_export.h in /kio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113497/#review42629 --- Ship it! Looks right to me. if correct test ing is done, shipi

Re: Review Request 113497: Install kiofilewidgets_export.h in /kio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113497/#review42628 --- This fixes the kde-workspace build for me, which has been other

Re: Review Request 113398: Make KNotifications build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113398/ --- (Updated Oct. 29, 2013, 12:54 p.m.) Status -- This change has been ma

Re: Review Request 113398: Make KNotifications build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113398/#review42627 --- This review has been submitted with commit 96419bf6f6041ba80fa

Review Request 113497: Install kiofilewidgets_export.h in /kio

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113497/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113496: Move Kross from staging to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113496/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113406: Add a macro to automatically generate forward headers

> On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 32 > > > > > > I recommend not putting this in the API of the function, and instead > > users should use > > > >

Re: Review Request 113371: Kross: Remove the KJs backened

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113371/#review42618 --- This review has been submitted with commit 636c8c614bca05d05a3

Re: Review Request 113371: Kross: Remove the KJs backened

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113371/ --- (Updated Oct. 29, 2013, 11:13 a.m.) Status -- This change has been ma

Undefined reference to udevqt::*

Hello. I've been trying to compile the Frameworks using kdesrc-build for ~a week, but everytime it fails because it cannot ld to UdevQt::somestuff[1]. I tried to cleanly build everything several times with no success. It could be a problem with my env vars[2], but I did just what I was told by the

Re: Review Request 113406: Add a macro to automatically generate forward headers

> On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 32 > > > > > > I recommend not putting this in the API of the function, and instead > > users should use > > > >

Re: Review Request 113406: Add a macro to automatically generate forward headers

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 29, 2013, 10:52 a.m.) Review request for Build System, KDE F

Re: Review Request 113406: Add a macro to automatically generate forward headers

> On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 32 > > > > > > I recommend not putting this in the API of the function, and instead > > users should use > > > >

Re: Review Request 113393: Get KPassivePopup positioning in a semi-working state

> On Oct. 29, 2013, 8:09 a.m., Kevin Ottens wrote: > > Wouldn't moving this class in KNotifications and from there use > > KWindowSystem be a better fix then? > > Alex Merry wrote: > That would certainly be the easiest way to get a correct implementation, > and it would fit conceptually.

Re: Review Request 113480: Move KnotifyConfig to tier 3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113480/#review42602 --- This review has been submitted with commit 0689af56dca6b57c580

Re: Review Request 113480: Move KnotifyConfig to tier 3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113480/ --- (Updated Oct. 29, 2013, 9:44 a.m.) Status -- This change has been mar

Re: Review Request 113406: Add a macro to automatically generate forward headers

> On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 32 > > > > > > I recommend not putting this in the API of the function, and instead > > users should use > > > >

Re: Review Request 113393: Get KPassivePopup positioning in a semi-working state

> On Oct. 29, 2013, 8:09 a.m., Kevin Ottens wrote: > > Wouldn't moving this class in KNotifications and from there use > > KWindowSystem be a better fix then? That would certainly be the easiest way to get a correct implementation, and it would fit conceptually. The only downside I see is tha

Re: Review Request 113430: More warnings fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/#review42597 --- This review has been submitted with commit f2359ab49fa3311f36a

Re: Review Request 113430: More warnings fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/ --- (Updated Oct. 29, 2013, 8:52 a.m.) Status -- This change has been mar

Re: Review Request 113430: More warnings fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/#review42596 --- This review has been submitted with commit 73048bfeb8df8014697

Re: Review Request 113430: More warnings fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/#review42595 --- This review has been submitted with commit 339363c4ef02f1f64fe

Re: Review Request 113430: More warnings fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/#review42594 --- This review has been submitted with commit df8269544cafbe4a31b

Re: Review Request 113430: More warnings fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/#review42593 --- This review has been submitted with commit 2e3cf98a87484946948

Re: Review Request 113399: Fix KAuthActionReply copy constructor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113399/ --- (Updated Oct. 29, 2013, 8:52 a.m.) Status -- This change has been mar

Re: Review Request 113399: Fix KAuthActionReply copy constructor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113399/#review42592 --- This review has been submitted with commit a49f9e12cae8e576ec8

Re: Review Request 113406: Add a macro to automatically generate forward headers

> On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 32 > > > > > > I recommend not putting this in the API of the function, and instead > > users should use > > > >

Re: Review Request 113155: Port all kde4_add_unit_test uses

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/ --- (Updated Oct. 29, 2013, 8:46 a.m.) Status -- This change has been dis

Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir

Kevin Ottens wrote: > Ship it! > > > Looks fine to me and is aligned with prior discussions. Note that it is named ECM_foo, but it contains hardcoded KDE icon theme names. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@

Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113483/ --- (Updated Oct. 29, 2013, 8:28 a.m.) Status -- This change has been mar

Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113483/#review42589 --- This review has been submitted with commit 4be8dbfedb9d8865730

Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113483/#review42587 --- Ship it! Looks fine to me and is aligned with prior discussion

Re: Review Request 113480: Move KnotifyConfig to tier 3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113480/#review42586 --- Ship it! Ship It! - Kevin Ottens On Oct. 28, 2013, 2:21 p.m

Re: Review Request 113436: Deprecate KEmoticonsTheme methods

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113436/#review42585 --- Ship it! Ship It! - Kevin Ottens On Oct. 25, 2013, 8:39 p.m

Re: Review Request 113430: More warnings fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113430/#review42584 --- Ship it! Ship It! - Kevin Ottens On Oct. 25, 2013, 2:08 p.m

Re: Review Request 113395: Enable KConfig on Windows

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113395/#review42583 --- Ship it! Looks good to me too. The owner id issue can be fixed

Re: Review Request 113426: Adjust API in KEmoticons framework: createNew method

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113426/#review42582 --- Ship it! Ship It! - Kevin Ottens On Oct. 24, 2013, 9:54 p.m

Re: Review Request 113399: Fix KAuthActionReply copy constructor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113399/#review42581 --- Ship it! Ship It! - Kevin Ottens On Oct. 23, 2013, 10:41 a.

Re: Review Request 113398: Make KNotifications build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113398/#review42579 --- Ship it! Ship It! - Kevin Ottens On Oct. 23, 2013, 10:24 a.

Re: Review Request 113393: Get KPassivePopup positioning in a semi-working state

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113393/#review42578 --- Wouldn't moving this class in KNotifications and from there use

Re: Review Request 113328: Fix standalone build of kdoctools

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113328/#review42576 --- Ship it! Ship It! - Kevin Ottens On Oct. 21, 2013, 1:32 p.m

Re: Review Request 113155: Port all kde4_add_unit_test uses

> On Oct. 21, 2013, 11:23 a.m., Kevin Ottens wrote: > > Any chance to see Alexander comments addressed? Any news? Is it abandoned? - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/

Re: Review Request 112367: Include the icon's theme in the cache key

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/ --- (Updated Oct. 29, 2013, 8:04 a.m.) Status -- This change has been dis

Re: Review Request 112032: Convert tier1/kwidgetaddons to the new Qt5 signal/slot syntax

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112032/ --- (Updated Oct. 29, 2013, 8:03 a.m.) Status -- This change has been dis