Re: kdelibs/interfaces/khexedit

2013-11-10 Thread David Faure
On Sunday 10 November 2013 04:32:12 Friedrich W. H. Kossebau wrote: Input welcome. Once upon a time those interfaces were invented to enable KPilot (yes, those times) to be able to use the hexedit widget I did then, without having these rather specific widget in kdelibs or having kdepim

Re: Review Request 113670: Only link to Qt5::X11Extras and ${X11_LIBRARIES} if X11 was found

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/#review43321 --- tier4/kde4support/src/CMakeLists.txt

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

2013-11-10 Thread David Faure
On Nov. 9, 2013, 12:47 a.m., David Faure wrote: staging/kio/CMakeLists.txt, line 34 http://git.reviewboard.kde.org/r/113723/diff/1/?file=212052#file212052line34 Why? KDED doesn't provide a library. Àlex Fiestas wrote: It provides a DBus interface (.xml) that is installed and

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review43323 --- Ship it! OK. I only meant don't remove existing code that

Re: KModifierKeyInfo usage and API

2013-11-10 Thread David Faure
Aaron? Anyone from the plasma team? I would appreciate input on this (see precise question at the end), it's preventing KF5 from moving forward with KModifierKeyInfo. Please CC kde-frameworks-devel, I'm not on plasma-devel. On Wednesday 16 October 2013 09:56:03 David Faure wrote: We are still

Re: kdelibs/interfaces/khexedit

2013-11-10 Thread Dominik Haumann
On Sunday 10 November 2013 09:47:41 David Faure wrote: On Sunday 10 November 2013 04:32:12 Friedrich W. H. Kossebau wrote: Input welcome. Once upon a time those interfaces were invented to enable KPilot (yes, those times) to be able to use the hexedit widget I did then, without having

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-10 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review43331 --- Ship it! Ship It! - John Layt On Oct. 22, 2013, 4:49 p.m.,

Re: Review Request 113696: Rename knewstuff private headers to _p.h

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113696/#review43332 --- Ship it! No change was needed in CMakeLists.txt, therefore

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43334 --- tier1/kguiaddons/src/plugins/imageformats/eps.cpp

Re: Review Request 113705: Remove unused TIFF kimgio code

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113705/#review43335 --- Ship it! I trust that you compared them and they had the same

Re: Review Request 113708: Make kcmutils build standalone

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113708/#review43336 --- Ship it! Ship It! - David Faure On Nov. 7, 2013, 3:36

Re: KModifierKeyInfo usage and API

2013-11-10 Thread Bhushan Shah
Hello! It looks like keystate applet which was removed from KDE4 was(?) the user of keystate dataengine. If we bring back this applet in Plasma2 then this DataEngine will be used. And this applet is necessary for disabled people, See https://bugs.kde.org/show_bug.cgi?id=165402 Thanks! On Sun,

Re: Review Request 113730: Fix kpty standalone build

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113730/#review43337 --- Ship it! Ship It! - David Faure On Nov. 9, 2013, 10:54

Re: Review Request 113705: Remove unused TIFF kimgio code

2013-11-10 Thread Alex Merry
On Nov. 10, 2013, 11:33 a.m., David Faure wrote: I trust that you compared them and they had the same features? Qt's version is better in every way, as far as I can tell. - Alex --- This is an automatically generated e-mail. To

Re: Review Request 113705: Remove unused TIFF kimgio code

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113705/#review43342 --- This review has been submitted with commit

Re: Review Request 113705: Remove unused TIFF kimgio code

2013-11-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113705/ --- (Updated Nov. 10, 2013, 1:51 p.m.) Status -- This change has been

Re: Review Request 113731: Fix kdesu standalone build.

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113731/#review43344 --- Ship it! Ship It! - David Faure On Nov. 9, 2013, 11:18

Re: the kspeech interface

2013-11-10 Thread Kevin Ottens
On Saturday 09 November 2013 11:47:16 David Faure wrote: On Friday 08 November 2013 22:45:33 Jeremy Whiting wrote: Could we move the dbus interface into kdeaccessibility/jovie and install it only when jovie is installed, This would create a compile-time dependency on kdeaccessibility, in

Re: kdesrc-build build failures

2013-11-10 Thread Kevin Ottens
On Saturday 09 November 2013 15:18:36 Ivan Čukić wrote: On Friday 08 November 2013 18:04:08 Stefanie Dargel wrote: kde-workspace fails, because it requires QImageBlitz, which is not being compiled. I didn't manage to add the Subversion repo to kf5-qt5-build-include. Ho can I do it? You

Re: kdelibs/interfaces/khexedit

2013-11-10 Thread Kevin Ottens
On Sunday 10 November 2013 11:15:58 Dominik Haumann wrote: On Sunday 10 November 2013 09:47:41 David Faure wrote: On Sunday 10 November 2013 04:32:12 Friedrich W. H. Kossebau wrote: So from my point of view, especially given the idea of KF5, I see no more need for interfaces/khexedit.

Re: Review Request 113670: Only link to Qt5::X11Extras and ${X11_LIBRARIES} if X11 was found

2013-11-10 Thread Alexander Richardson
On Nov. 10, 2013, 9:50 a.m., David Faure wrote: tier4/kde4support/src/CMakeLists.txt, line 293 http://git.reviewboard.kde.org/r/113670/diff/3/?file=212165#file212165line293 Why was this line removed? Everything else looks fine to me, this remove seems unrelated though.

Re: Getting ecm files from the ECM package

2013-11-10 Thread Alexander Neundorf
On Sunday 10 November 2013, David Faure wrote: On Sunday 03 November 2013 14:05:32 Alexander Neundorf wrote: To build karchive itself, they would need cmake + tier0-kf5 + ECM Which is exactly what I want to avoid. You wrote To build software using karchive with cmake, they still need

Re: Getting ecm files from the ECM package

2013-11-10 Thread Alexander Neundorf
On Sunday 10 November 2013, Alexander Neundorf wrote: On Sunday 10 November 2013, David Faure wrote: On Sunday 03 November 2013 14:05:32 Alexander Neundorf wrote: To build karchive itself, they would need cmake + tier0-kf5 + ECM Which is exactly what I want to avoid. You wrote To

Re: Getting ecm files from the ECM package

2013-11-10 Thread Kevin Ottens
On Sunday 10 November 2013 16:27:06 Alexander Neundorf wrote: On Sunday 10 November 2013, Alexander Neundorf wrote: On Sunday 10 November 2013, David Faure wrote: On Sunday 03 November 2013 14:05:32 Alexander Neundorf wrote: To build karchive itself, they would need cmake + tier0-kf5 +

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-10 Thread Kevin Ottens
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative. Any chance for an update? - Kevin --- This is an automatically generated

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-11-10 Thread Kevin Ottens
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote: I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least partly. Jeremy Whiting wrote: well, qt5_wrap_ui wasn't around when this was created (as kde4_add_ui_files iirc). All I did was copy it and rename it.

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

2013-11-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113631/ --- (Updated Nov. 10, 2013, 3:46 p.m.) Review request for KDE Frameworks,

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/#review43351 --- Ship it! I think that's fine to keep the modules private,

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/#review43353 --- Please someone with more cmake-fu than myself look at it. It's

Re: Review Request 113731: Fix kdesu standalone build.

2013-11-10 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113731/ --- (Updated Nov. 10, 2013, 3:53 p.m.) Status -- This change has been

Re: Review Request 113730: Fix kpty standalone build

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113730/#review43354 --- This review has been submitted with commit

Re: Review Request 113730: Fix kpty standalone build

2013-11-10 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113730/ --- (Updated Nov. 10, 2013, 3:53 p.m.) Status -- This change has been

Re: Review Request 113731: Fix kdesu standalone build.

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113731/#review43355 --- This review has been submitted with commit

Re: Review Request 113711: Clean up API of KPassivePopup

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113711/#review43357 --- Ship it! Ship It! - Kevin Ottens On Nov. 7, 2013, 6:57

Re: Review Request 113695: Fix KDEWebKit standalone build

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113695/#review43360 --- Ship it! Ship It! - Kevin Ottens On Nov. 7, 2013, 12:38

Re: Review Request 113693: Fix KNotifyConfig standalone build

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113693/#review43361 --- Ship it! After adjusting the comment it can go in indeed. -

Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/#review43362 --- Ship it! Ship It! - Kevin Ottens On Nov. 8, 2013, 12:12

Re: Review Request 113694: Fix KNewStuff standalone build

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113694/#review43363 --- Ship it! Ship It! - Kevin Ottens On Nov. 7, 2013, 1:04

Re: Review Request 113696: Rename knewstuff private headers to _p.h

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113696/#review43364 --- Ship it! Ship It! - Kevin Ottens On Nov. 6, 2013, 7:17

Re: Review Request 113708: Make kcmutils build standalone

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113708/#review43365 --- Ship it! Ship It! - Kevin Ottens On Nov. 7, 2013, 3:36

Re: Review Request 113670: Only link to Qt5::X11Extras and ${X11_LIBRARIES} if X11 was found

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/#review43366 --- Ship it! Ship It! - Kevin Ottens On Nov. 8, 2013, 9:04

Re: Getting ecm files from the ECM package

2013-11-10 Thread Alexander Neundorf
On Sunday 10 November 2013, Kevin Ottens wrote: On Sunday 10 November 2013 16:27:06 Alexander Neundorf wrote: On Sunday 10 November 2013, Alexander Neundorf wrote: On Sunday 10 November 2013, David Faure wrote: On Sunday 03 November 2013 14:05:32 Alexander Neundorf wrote: To build

Re: RFC Rules for installation of header files

2013-11-10 Thread Kevin Ottens
Hello, On Wednesday 06 November 2013 08:52:29 Aurélien Gâteau wrote: Yesterday frameworks meeting spawned a discussion regarding folders in header files. I think there's an aspect missing in your proposal. There's the convention we want for #include and where we install. That's in the end two

Having a Tier 0 for cmake and git submodules

2013-11-10 Thread Kevin Ottens
Hello, Since there's been several times discussions about having a kind of Tier 0 for building our frameworks containing what is right now in ECM kde-modules directory, but the idea was never really on the table because of the extra dependency it'd bring, I looked a bit at the git submodule

Re: Getting ecm files from the ECM package

2013-11-10 Thread Kevin Ottens
On Sunday 10 November 2013 17:30:23 Alexander Neundorf wrote: On Sunday 10 November 2013, Kevin Ottens wrote: Now I guess we could do it for both, but it looks tricky for something which would have a separate release cycle like ECM. While for the tier0 the release cycle would be tied to the

Re: Having a Tier 0 for cmake and git submodules

2013-11-10 Thread Sune Vuorela
On 2013-11-10, Kevin Ottens er...@kde.org wrote: Since there's been several times discussions about having a kind of Ti= er 0=20 for building our frameworks containing what is right now in ECM kde-mod= ules=20 directory, but the idea was never really on the table because of the ex= tra=20

Re: Review Request 113711: Clean up API of KPassivePopup

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113711/#review43370 --- This review has been submitted with commit

Re: Review Request 113711: Clean up API of KPassivePopup

2013-11-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113711/ --- (Updated Nov. 10, 2013, 5:23 p.m.) Status -- This change has been

Re: Review Request 113713: Solid UDisks2 backend: fixes to propertiesChanged signal handling

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113713/#review43371 --- This review has been submitted with commit

Re: Review Request 113713: Solid UDisks2 backend: fixes to propertiesChanged signal handling

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113713/#review43373 --- This review has been submitted with commit

Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/#review43372 --- This review has been submitted with commit

Re: Review Request 113713: Solid UDisks2 backend: fixes to propertiesChanged signal handling

2013-11-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113713/ --- (Updated Nov. 10, 2013, 5:23 p.m.) Status -- This change has been

Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest

2013-11-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/ --- (Updated Nov. 10, 2013, 5:23 p.m.) Status -- This change has been

Re: Having a Tier 0 for cmake and git submodules

2013-11-10 Thread Kevin Ottens
On Sunday 10 November 2013 17:12:02 Sune Vuorela wrote: Why move it out of e-c-m ? To make e-c-m a neutral ground again, not something purely for KDE needs. I can understand that positioning. And if a distribution need to patch whatever is in the 'submodule', they have a enormous useless

Re: Review Request 112880: Added KColorSchemeToken class.

2013-11-10 Thread Denis Kuplyakov
On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative. Kevin Ottens wrote: Any chance for an update? Yes I will finish it, when have time. There are many pre-exams in university. -

Re: Having a Tier 0 for cmake and git submodules

2013-11-10 Thread David Faure
On Sunday 10 November 2013 17:57:00 Kevin Ottens wrote: Now back to the submodules sha-1 update... The only thing I see to easily overcome that for our developers, is to have a hook, which would update the submodules for all the frameworks every time someone pushes in the tier 0 repository.

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/ --- (Updated Nov. 10, 2013, 6:16 p.m.) Review request for KDE Frameworks.

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Alex Merry
On Nov. 10, 2013, 11:20 a.m., David Faure wrote: tier1/kguiaddons/src/plugins/imageformats/eps.cpp, line 300 http://git.reviewboard.kde.org/r/113704/diff/1/?file=211396#file211396line300 isn't there a better method to call than pid()? You're right; I missed the state() method last

Re: Having a Tier 0 for cmake and git submodules

2013-11-10 Thread Sune Vuorela
On 2013-11-10, Kevin Ottens er...@kde.org wrote: --===3596639883239406900== Content-Type: multipart/signed; boundary=nextPart1424144.VkBYIHTjbs; micalg=pgp-sha1; protocol=application/pgp-signature --nextPart1424144.VkBYIHTjbs Content-Transfer-Encoding: quoted-printable

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43380 --- Ship it! One more thing, but if this isn't possible, then

Re: Having a Tier 0 for cmake and git submodules

2013-11-10 Thread Alexander Neundorf
On Sunday 10 November 2013, David Faure wrote: On Sunday 10 November 2013 17:57:00 Kevin Ottens wrote: Now back to the submodules sha-1 update... The only thing I see to easily overcome that for our developers, is to have a hook, which would update the submodules for all the frameworks

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Alex Merry
On Nov. 10, 2013, 6:39 p.m., David Faure wrote: tier1/kguiaddons/src/plugins/imageformats/eps.cpp, line 246 http://git.reviewboard.kde.org/r/113704/diff/2/?file=212428#file212428line246 My suggestion was simply QImageReader ppmReader(io, ppm), to let it read directly from the

Re: Having a Tier 0 for cmake and git submodules

2013-11-10 Thread David Faure
On Sunday 10 November 2013 18:23:33 Sune Vuorela wrote: DCMAKE_BUILD_TYPE=Debug is building with -O2 Oh wow, I always thought this was cmake's doing, but you're right, it's not. This is an historical bit from the automake/unsermake times. We had debug (-O2 -g) and debugfull (no optimization,

Re: Having a Tier 0 for cmake and git submodules

2013-11-10 Thread David Faure
On Sunday 10 November 2013 19:42:46 Alexander Neundorf wrote: this would mean that the 3 KDE* files from ecm plus the KF5 umbrella Config.cmake file would be used within KF5 as a git submodule. Users of KF5 can get access to it via using the installed KF5 umbrella package, or not if they

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43386 --- This review has been submitted with commit

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43385 --- This review has been submitted with commit

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/ --- (Updated Nov. 10, 2013, 7:05 p.m.) Status -- This change has been

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43387 --- This review has been submitted with commit

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43388 --- This review has been submitted with commit

Re: Review Request 113704: Fix EPS plugin

2013-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113704/#review43389 --- Ship it! tier1/kguiaddons/src/plugins/imageformats/eps.cpp

Re: Having a Tier 0 for cmake and git submodules

2013-11-10 Thread Michael Pyne
On Sun, November 10, 2013 17:57:00 Kevin Ottens wrote: Now back to the submodules sha-1 update... The only thing I see to easily overcome that for our developers, is to have a hook, which would update the submodules for all the frameworks every time someone pushes in the tier 0 repository. Is

Re: Having a Tier 0 for cmake and git submodules

2013-11-10 Thread David Faure
On Sunday 10 November 2013 13:44:09 Michael Pyne wrote: I would highly recommend doing something similar to what was done for strigi when it was split into 5 git modules. I think you misunderstood the issue? A super-repo might help automating building all of KF5, but it doesn't solve the

List of Frameworks

2013-11-10 Thread Dominik Haumann
Hi, currently, http://community.kde.org/Frameworks/Epics/Modularization shows a list of modules in the respective Tiers. It does not, however, show whether it's functional, integration or a solution. Imo if would be good to have this as column, too. Since then a quick look allows us (for

Re: Having a Tier 0 for cmake and git submodules

2013-11-10 Thread Dominik Haumann
On Sunday 10 November 2013 17:57:00 Kevin Ottens wrote: Hello, Since there's been several times discussions about having a kind of Tier 0 for building our frameworks containing what is right now in ECM kde-modules directory, but the idea was never really on the table because of the extra

Re: Review Request 113670: Only link to Qt5::X11Extras and ${X11_LIBRARIES} if X11 was found

2013-11-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/ --- (Updated Nov. 10, 2013, 11:42 p.m.) Status -- This change has been

Re: Review Request 113670: Only link to Qt5::X11Extras and ${X11_LIBRARIES} if X11 was found

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/#review43394 --- This review has been submitted with commit

Re: Review Request 113670: Only link to Qt5::X11Extras and ${X11_LIBRARIES} if X11 was found

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/#review43395 --- This review has been submitted with commit

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

2013-11-10 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- (Updated Nov. 11, 2013, 12:21 a.m.) Review request for KDE Frameworks,

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/#review43396 --- This review has been submitted with commit

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

2013-11-10 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- (Updated Nov. 11, 2013, 12:25 a.m.) Status -- This change has been

Re: List of Frameworks

2013-11-10 Thread Aleix Pol
On Sun, Nov 10, 2013 at 9:58 PM, Dominik Haumann dhaum...@kde.org wrote: Hi, currently, http://community.kde.org/Frameworks/Epics/Modularization shows a list of modules in the respective Tiers. It does not, however, show whether it's functional, integration or a solution. Imo if would be

Review Request 113792: Fix Build of KDNSSD with DNSSD Backend

2013-11-10 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113792/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

2013-11-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113723/ --- (Updated Nov. 11, 2013, 3:23 a.m.) Review request for KDE Frameworks.

Re: Review Request 113723: Fix KIO to build standalone, prepare for moving into its tier

2013-11-10 Thread Aleix Pol Gonzalez
On Nov. 9, 2013, 12:47 a.m., David Faure wrote: staging/kio/CMakeLists.txt, line 30 http://git.reviewboard.kde.org/r/113723/diff/1/?file=212052#file212052line30 already listed 6 lines above I had to add it because it's a dependency-of-a-dependency. I'll add a comment about that.

Re: Having a Tier 0 for cmake and git submodules

2013-11-10 Thread Michael Pyne
On Sun, November 10, 2013 20:11:07 David Faure wrote: On Sunday 10 November 2013 13:44:09 Michael Pyne wrote: I would highly recommend doing something similar to what was done for strigi when it was split into 5 git modules. I think you misunderstood the issue? A super-repo might help

Re: Re: List of Frameworks

2013-11-10 Thread Dominik Haumann
On Monday, November 11, 2013 02:22:43 Aleix Pol wrote: On Sun, Nov 10, 2013 at 9:58 PM, Dominik Haumann dhaum...@kde.org wrote: Hi, currently, http://community.kde.org/Frameworks/Epics/Modularization shows a list of modules in the respective Tiers. It does not, however, show whether