Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Stephen Kelly
Chusslove Illich wrote: [: Stephen Kelly :] If such calls are generated by uic, then that is a bug in Qt (which should have been reported years ago), and should be fixed in Qt, right? Maybe, I'm not sure of the conventions of Qt Linguist. I created a .ui file with a QLabel with an empty

Build failed in Jenkins: kdelibs_frameworks_qt5 #1692

2013-11-18 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1692/changes Changes: [steveire] Add missing file. -- [...truncated 3843 lines...] [ 24%] Building CXX object tier3/kservice/src/CMakeFiles/KService.dir/sycoca/ksycocadict.cpp.o [ 25%] Building CXX

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113685/ --- (Updated Nov. 18, 2013, 8:44 a.m.) Status -- This change has been

Build failed in Jenkins: kdelibs_frameworks_qt5 #1693

2013-11-18 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1693/changes Changes: [mgraesslin] New KColorSchemeManager to support changing color scheme in app -- [...truncated 4763 lines...] [ 48%] Built target fixx11h_test [ 48%] Building CXX object

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113685/#review43872 --- This review has been submitted with commit

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

2013-11-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- (Updated Nov. 18, 2013, 8:58 a.m.) Status -- This change has been

Build failed in Jenkins: kdelibs_frameworks_qt5 #1694

2013-11-18 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1694/ -- [...truncated 4642 lines...] Scanning dependencies of target kdirwatchtest_gui [ 41%] Building CXX object tier1/kcoreaddons/tests/CMakeFiles/kdirwatchtest_gui.dir/kdirwatchtest_gui.cpp.o Scanning

Build failed in Jenkins: kdelibs_frameworks_qt5 #1695

2013-11-18 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1695/changes Changes: [mgraesslin] Reimplement KXUtils::createPixmapFromHandle with XCB -- [...truncated 3844 lines...] [ 36%] [ 36%] Building CXX object

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-18 Thread Albert Astals Cid
On Nov. 15, 2013, 7:42 p.m., Kevin Ottens wrote: tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 124 http://git.reviewboard.kde.org/r/113685/diff/3/?file=213999#file213999line124 Would make sense to change the lambda so that you'd pass 16 and 24 instead. It feels kinda

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-18 Thread Boudewijn Rempt
On Monday 18 November 2013 Nov 09:17:07 Albert Astals Cid wrote: So you're saying Boud's and Christoph comments are wrong? My comment was meant to convey that color palettes have nothing to do with this patch -- they're a red herring here. -- Boudewijn Rempt http://www.valdyas.org,

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-18 Thread Martin Gräßlin
On Nov. 15, 2013, 8:42 p.m., Kevin Ottens wrote: tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 124 http://git.reviewboard.kde.org/r/113685/diff/3/?file=213999#file213999line124 Would make sense to change the lambda so that you'd pass 16 and 24 instead. It feels kinda

Jenkins build is back to normal : plasma-framework_master_qt5 #906

2013-11-18 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/906/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Kevin Ottens
On Sunday 17 November 2013 18:53:36 Stephen Kelly wrote: Kevin Ottens wrote: On Friday 15 November 2013 16:28:10 Stephen Kelly wrote: Aleix Pol wrote: I see that Stephen Kelly has been doing some work on Qt and cmake to make it possible to integrate these properly, but also those

Build failed in Jenkins: kdelibs_frameworks_qt5 #1696

2013-11-18 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/1696/changes Changes: [agateau] Hackish fix for build failure in kde-runtime -- [...truncated 3943 lines...] [ 32%] Building CXX object

Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Stephen Kelly
Stephen Kelly wrote: It'd need to be released quite a bit before us to be something we can consider as a dependency. At that point I'm considering having 2.8.12 as dependency for the release (so that it got time to spread, sounds less likely with CMake 3). I don't understand. Why is CMake

Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Stephen Kelly
Kevin Ottens wrote: 10% chance? 50%? 80%? Basically what's the time frame for CMake 3. I'll be 90% surprised if it is not released in January, or maybe February. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Aleix Pol
On Mon, Nov 18, 2013 at 12:50 PM, Stephen Kelly steve...@gmail.com wrote: Kevin Ottens wrote: 10% chance? 50%? 80%? Basically what's the time frame for CMake 3. I'll be 90% surprised if it is not released in January, or maybe February. Thanks, Steve.

Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Kevin Ottens
On Monday 18 November 2013 12:49:39 Stephen Kelly wrote: Stephen Kelly wrote: It'd need to be released quite a bit before us to be something we can consider as a dependency. At that point I'm considering having 2.8.12 as dependency for the release (so that it got time to spread, sounds

Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Stephen Kelly
Kevin Ottens wrote: You have enough credibility that people would believe it and spread it, but it is not true. That's not how backward compatibility works in CMake. I know, I was more thinking about the natural spreading of new version in distros. The time they package stuff and that ends

Re: Review Request 112913: Move KModifierKeyInfo from GuiAddons to KWindowSystem

2013-11-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112913/ --- (Updated Nov. 18, 2013, 2:19 p.m.) Status -- This change has been

Re: Review Request 112896: Rework NETWM classes

2013-11-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112896/ --- (Updated Nov. 18, 2013, 1:21 p.m.) Status -- This change has been

Re: Review Request 112896: Rework NETWM classes

2013-11-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112896/#review43888 --- This review has been submitted with commit

applications assert when no sycoca was generated before start

2013-11-18 Thread Harald Sitter
ahoy, I just noticed that frameworks applications explode when started without a sycoca: Trying to open ksycoca from /home/me/.project-neon5-kde//cache/ksycoca5 Trying to open global ksycoca from /home/me/.project-neon5-kde//local/share/kde5/services/ksycoca5 Still no database... ASSERT: str in

Re: Review Request 113883: Rename translation catalogue kfileaudiopreview4 to kfileaudiopreview

2013-11-18 Thread Alex Merry
On Nov. 15, 2013, 12:32 p.m., Aleix Pol Gonzalez wrote: Why do you need to drop the version? In similar cases we've been bumping to 5... Kevin Ottens wrote: Yeah I'm surprised as well... OTOH that's a regular library, we don't mention the version name for those (unlike for

Re: Review Request 113887: Deprecate KDE4_* KAuth macros

2013-11-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113887/ --- (Updated Nov. 18, 2013, 2:22 p.m.) Status -- This change has been

Re: Review Request 113887: Deprecate KDE4_* KAuth macros

2013-11-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113887/#review43891 --- This review has been submitted with commit

Re: Review Request 113863: Remove WINCE specific cmake code paths

2013-11-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113863/ --- (Updated Nov. 18, 2013, 2:34 p.m.) Review request for Build System and

Re: Review Request 113863: Remove WINCE specific cmake code paths

2013-11-18 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113863/#review43892 --- Ship it! Ship It! - Stephen Kelly On Nov. 18, 2013, 2:34

Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Aleix Pol
On Mon, Nov 18, 2013 at 4:17 PM, Kevin Ottens er...@kde.org wrote: On Monday 18 November 2013 13:27:19 Aleix Pol wrote: So would it be that bad to have a macro of ours that ends up being just a wrapper to qt5_wrap_ui? Otherwise, this delays the possibility to help the ongoing porting

error: KF5::KDBusAddons-NOTFOUND

2013-11-18 Thread Sebastian Kügler
It seems subject broke over the weekend. kactivities fails to compile: c++: error: KF5::KDBusAddons-NOTFOUND: No such file or directory kactivities uses: find_package (KF5 CONFIG REQUIRED KDBusAddons) so it's pretty bare-bones. Could someone have a look or suggest a fix? Thanks, -- sebas

Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Kevin Ottens
On Monday 18 November 2013 17:41:49 Aleix Pol wrote: On Mon, Nov 18, 2013 at 4:17 PM, Kevin Ottens er...@kde.org wrote: Right, we need to cater to that need too. Since that's tied to ki18n use, what about putting that wrapper macro in ki18n for the time being? Of course it should be

Re: error: KF5::KDBusAddons-NOTFOUND

2013-11-18 Thread Martin Klapetek
On Mon, Nov 18, 2013 at 5:53 PM, Aleix Pol aleix...@kde.org wrote: On Mon, Nov 18, 2013 at 5:43 PM, Sebastian Kügler se...@kde.org wrote: It seems subject broke over the weekend. kactivities fails to compile: c++: error: KF5::KDBusAddons-NOTFOUND: No such file or directory kactivities

Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Stephen Kelly
Chusslove Illich wrote: [: Stephen Kelly :] This depends on Qt 5.3 and CMake master plus some trivial new generator expressions. Aside from bikeshedding names of things and defaults, can you see any problem with this? Other than bikeshedding about the defaults (which I will do a bit

Re: Review Request 113887: Deprecate KDE4_* KAuth macros

2013-11-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113887/#review43910 --- ${KAUTH_POLICY_FILES_INSTALL_DIR} This is bogus (but e.g.

Re: Wrapping up about KI18n and UIC

2013-11-18 Thread Aleix Pol
On Mon, Nov 18, 2013 at 9:10 PM, Chusslove Illich caslav.i...@gmx.netwrote: [: Kevin Ottens :] Of course it should be removed when we get a proper fix via CMake 3 around. But in the meantime it'll do the trick and allow removing dependencies on KDE4Support just for that. [: Aleix Pol