Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

> On Feb. 6, 2014, 2:14 a.m., Alexander Richardson wrote: > > src/kwindowsystem.cpp, line 342 > > > > > > The non-MSVC macro has a return statement, I think this one needs it as > > well > > Andrius da Costa

Re: kf5 alpha 1 : attica?

On Thursday 06 February 2014 01:15:15 David Faure wrote: > Some issues left: > - who do we write down as maintainer for attica? Good question, let's mark it "TBD" until someone dares to step up for it. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

> On Feb. 6, 2014, 1:14 a.m., Alexander Richardson wrote: > > src/kwindowsystem.cpp, line 342 > > > > > > The non-MSVC macro has a return statement, I think this one needs it as > > well Why is this condition

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/#review49088 --- src/kwindowsystem.cpp

Re: kf5 alpha 1 : attica?

[resent with Frederik's correct email address] On Thursday 06 February 2014 00:53:53 Frederik Gladhorn wrote: > Thanks a lot, I really appreciate it. Some issues left: - who do we write down as maintainer for attica? - can I run "astyle" on the code to make it consistent with all other framework

Jenkins build is back to normal : knewstuff_master_qt5 #27

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: knewstuff_master_qt5 #26

See -- Started by user dfaure Building remotely on LinuxSlave - 4 in workspace Running Prebuild steps [knewstuff_master_qt5] $ /bin/sh -xe /tmp/hudson779

Re: kf5 alpha 1 : attica?

On Thursday 06 February 2014 00:53:53 Frederik Gladhorn wrote: > On Thursday 6. February 2014 00.29.45 David Faure wrote: > > Frederik wrote: > > > From my point of view, please just go ahead and change it as you think > > > is > > > sensible. > > > > OK, thanks for the green lights, I went ahead:

Re: kf5 alpha 1 : attica?

On Thursday 6. February 2014 00.29.45 David Faure wrote: > Frederik wrote: > > From my point of view, please just go ahead and change it as you think is > > sensible. > > OK, thanks for the green lights, I went ahead: > > * Qt4 support for attica is now in the "qt4" branch > > * Attica master is

Build failed in Jenkins: knewstuff_master_qt5 #25

See Changes: [faure] Port to attica-as-a-proper-kf5-framework. Needs current attica master. -- Started by user Ben Cooksley Building remotely on LinuxSlave - 4 in workspace

Re: kf5 alpha 1 : attica?

Frederik wrote: > From my point of view, please just go ahead and change it as you think is > sensible. OK, thanks for the green lights, I went ahead: * Qt4 support for attica is now in the "qt4" branch * Attica master is now qt5 only, and requires ECM. * It gained all the bells and whistles of

Build failed in Jenkins: knewstuff_master_qt5 #24

See -- Started by user Ben Cooksley Building remotely on LinuxSlave - 1 in workspace Running Prebuild steps [knewstuff_master_qt5] $ /bin/sh -xe /tmp/hud

Build failed in Jenkins: knewstuff_master_qt5 #23

See Changes: [faure] Port to attica-as-a-proper-kf5-framework. Needs current attica master. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

On Wednesday 05 February 2014 22:18:54 Chusslove Illich wrote: > I don't see significant benefit in ki18n being tier 1 Maybe not significant, but looking at ever-appearing difficulties with providing proper translations of Qt applications in KDE repositories, the porting effort is worth it. Chr

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 5, 2014, 4:51 p.m., Aurélien Gâteau wrote: > > Wow, great work! I attempted doing this some time ago, and all I managed to > > produce was two unit tests :). Looks good to me and works fine here. Just > > two (really minor) nitpicks. > > Kevin Krammer wrote: > Thanks :) > Goo

Re: Review Request 115494: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/ --- (Updated Feb. 5, 2014, 8:38 p.m.) Status -- This change has been mar

Re: Review Request 115502: Fix math function checks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115502/#review49074 --- Ship it! Fixes the signbit issue also on Mac OS X :) - Haral

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/ --- (Updated Feb. 5, 2014, 8:10 p.m.) Status -- This change has been dis

Re: Review Request 115440: Rename KDE4_SERIALIZE_TOOL to KDOCTOOLS_SERIALIZE_TOOL And Add Setter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115440/ --- (Updated Feb. 5, 2014, 8:10 p.m.) Status -- This change has been mar

Re: Review Request 115440: Rename KDE4_SERIALIZE_TOOL to KDOCTOOLS_SERIALIZE_TOOL And Add Setter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115440/#review49071 --- This review has been submitted with commit 6763850e3abe08448c

Re: kf5 alpha 1 : attica?

On Wednesday 05 February 2014 18:39:51 David Faure wrote: > On Wednesday 05 February 2014 09:55:08 Jeremy Whiting wrote: > > I can do the changes if needed. It just needs the changes here: > > http://community.kde.org/Frameworks/Porting_Notes under "Build System" > > ? > > No, it should follow all

Re: Review Request 115502: Fix math function checks

> On Feb. 5, 2014, 7:37 p.m., Bernd Buschinski wrote: > > Ship It! and btw good catch for the math vs. cmake undef, seems like I overlooked it :) - Bernd --- This is an automatically generated e-mail. To reply, visit: https://git.review

Re: Review Request 115494: Build on Mac OS X

> On Feb. 5, 2014, 5:04 p.m., Alex Merry wrote: > > Nope, still breaks on Linux. I think it's because undefs the > > signbit macro. > > > > I propose https://git.reviewboard.kde.org/r/115502/ as the proper fix for > > this part of your request. I would also prefer https://git.reviewboard.kd

Re: Review Request 115502: Fix math function checks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115502/#review49067 --- Ship it! Ship It! - Bernd Buschinski On Feb. 5, 2014, 5:03

Re: kf5 alpha 1 : attica?

On Tuesday 4. February 2014 23.40.22 David Faure wrote: > On Monday 03 February 2014 11:34:44 Kevin Ottens wrote: > > On Monday 03 February 2014 10:17:49 David Faure wrote: > > > Any new module that should be added to this release, compared to TP1? > > > > > > Should I include attica? > > > > Since

Re: Review Request 115504: Only perform tests for plugins that are built

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/#review49066 --- CMakeLists.txt

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

> On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote: > > Any particular reason for not using an abstract class? The D macro makes > > the code a bit surprising to read. > > Martin Gräßlin wrote: > see discussion of https://git.reviewboard.kde.org/r/115225/ (comment > thread started by Aaro

Review Request 115504: Only perform tests for plugins that are built

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/ --- Review request for KDE Frameworks. Repository: kimageformats Descriptio

Re: kf5 alpha 1 : attica?

On Wednesday 05 February 2014 09:55:08 Jeremy Whiting wrote: > I can do the changes if needed. It just needs the changes here: > http://community.kde.org/Frameworks/Porting_Notes under "Build System" > ? No, it should follow all the things that other frameworks do. Compare with e.g. kcoreaddons o

Re: Review Request 115472: fix test for icon path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115472/ --- (Updated Feb. 5, 2014, 5:27 p.m.) Status -- This change has been mar

Re: Review Request 115472: fix test for icon path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115472/#review49059 --- This review has been submitted with commit d74fb909e2c89d869a

Re: Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115496/ --- (Updated Feb. 5, 2014, 5:26 p.m.) Review request for Build System, Extra

Re: Review Request 115387: rename dbus interface file for kinit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115387/#review49056 --- This review has been submitted with commit 42e68ce5e8eaf54b35

Re: Review Request 115387: rename dbus interface file for kinit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115387/ --- (Updated Feb. 5, 2014, 5:16 p.m.) Status -- This change has been mar

Re: Review Request 115494: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/#review49051 --- Nope, still breaks on Linux. I think it's because undefs the

Review Request 115502: Fix math function checks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115502/ --- Review request for KDE Frameworks, Bernd Buschinski and Harald Fernengel.

Re: Review Request 115387: rename dbus interface file for kinit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115387/#review49054 --- Ship it! Ship It! - Alex Merry On Jan. 29, 2014, 4:27 p.m.

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/ --- (Updated Feb. 5, 2014, 5:55 p.m.) Review request for KDE Frameworks, kdew

Re: kf5 alpha 1 : attica?

I can do the changes if needed. It just needs the changes here: http://community.kde.org/Frameworks/Porting_Notes under "Build System" ? I believe attica currently builds with both qt4 or qt5 based on cmake options (if QT4_BUILD is set it builds with qt4). Is the qt4 branch supposed to not use ECM

Re: Review Request 115442: Change NET* classes and KWindoInfo/KWindowSystem to use declared flag types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115442/#review49052 --- This review has been submitted with commit 346d153a52588d9bdb

Re: Review Request 115442: Change NET* classes and KWindoInfo/KWindowSystem to use declared flag types

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115442/ --- (Updated Feb. 5, 2014, 4:44 p.m.) Status -- This change has been mar

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

> On Feb. 5, 2014, 3:51 p.m., Aurélien Gâteau wrote: > > Wow, great work! I attempted doing this some time ago, and all I managed to > > produce was two unit tests :). Looks good to me and works fine here. Just > > two (really minor) nitpicks. Thanks :) Good to hear that it works properly, I g

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

> On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote: > > Any particular reason for not using an abstract class? The D macro makes > > the code a bit surprising to read. > > Martin Gräßlin wrote: > see discussion of https://git.reviewboard.kde.org/r/115225/ (comment > thread started by Aaro

Re: Review Request 115493: Make CMakeLists.txt respect DESTDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115493/ --- (Updated Feb. 5, 2014, 4:08 p.m.) Status -- This change has been mar

Jenkins build is back to normal : kapidox_master_qt5 #6

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/ --- (Updated Feb. 5, 2014, 4:08 p.m.) Review request for KDE Frameworks and C

Re: Review Request 115493: Make CMakeLists.txt respect DESTDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115493/#review49046 --- This review has been submitted with commit 8777b38285695196a2

Re: Review Request 115494: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/ --- (Updated Feb. 5, 2014, 4:06 p.m.) Review request for KDE Frameworks and B

Re: Review Request 115493: Make CMakeLists.txt respect DESTDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115493/#review49045 --- Ship it! Ship It! - Aurélien Gâteau On Feb. 5, 2014, 4:50

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

> On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote: > > Any particular reason for not using an abstract class? The D macro makes > > the code a bit surprising to read. > > Martin Gräßlin wrote: > see discussion of https://git.reviewboard.kde.org/r/115225/ (comment > thread started by Aaro

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review49036 --- Wow, great work! I attempted doing this some time ago, and all

Re: Review Request 115493: Make CMakeLists.txt respect DESTDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115493/ --- (Updated Feb. 5, 2014, 3:50 p.m.) Review request for KDE Frameworks and A

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115459/ --- (Updated Feb. 5, 2014, 4:46 p.m.) Review request for KDE Frameworks, kdew

Re: Review Request 115459: Introduce runtime platform support in KWindowSystem

> On Feb. 4, 2014, 5:19 p.m., Aurélien Gâteau wrote: > > Any particular reason for not using an abstract class? The D macro makes > > the code a bit surprising to read. see discussion of https://git.reviewboard.kde.org/r/115225/ (comment thread started by Aaron) - I wanted to keep the same pat

Re: Review Request 115493: Make CMakeLists.txt respect DESTDIR

> On Feb. 5, 2014, 3:31 p.m., Aurélien Gâteau wrote: > > CMakeLists.txt, line 13 > > > > > > I think this can be simplified to: > > > > if (\$ENV{DESTDIR}) No, it can't. Tried that, it didn't work.

Re: Review Request 115493: Make CMakeLists.txt respect DESTDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115493/#review49034 --- Looks good, just an inline nitpick. I would also suggest addin

Re: Review Request 115355: Import the WebP image I/O code from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115355/ --- (Updated Feb. 5, 2014, 3:31 p.m.) Review request for KDE Frameworks and A

Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115496/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Review Request 115495: Make kgenframeworksapidox generate dependency diagrams

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115495/ --- Review request for KDE Frameworks, Alex Merry and Aurélien Gâteau. Reposi

Re: Review Request 115494: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/#review49027 --- src/kjs/ConfigureChecks.cmake

Re: Review Request 115494: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/ --- (Updated Feb. 5, 2014, 1:42 p.m.) Review request for KDE Frameworks and B

Re: Review Request 115476: Defer to CMake's find_dependency macro if it exists

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115476/ --- (Updated Feb. 5, 2014, 1:26 p.m.) Status -- This change has been dis

Re: Review Request 115472: fix test for icon path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115472/#review49019 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 5, 2014, 11

Re: Review Request 115481: Improve knotifyconfig dependencies

> On Feb. 5, 2014, 11:58 a.m., Alex Merry wrote: > > tests/CMakeLists.txt, lines 7-20 > > > > > > These should all be PURPOSE, not DESCRIPTION. Also, Qt5Test should > > have its PURPOSE set as well. It looks lik

Re: Review Request 115481: Improve knotifyconfig dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115481/ --- (Updated Feb. 5, 2014, 1:04 p.m.) Review request for KDE Frameworks and D

Review Request 115494: Build on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115494/ --- Review request for KDE Frameworks. Repository: kjs Description ---

Re: Review Request 115481: Improve knotifyconfig dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115481/#review49017 --- tests/CMakeLists.txt

Re: Review Request 115477: Remove commands that just set variables to their defaults

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115477/#review49016 --- This review has been submitted with commit c5cec3d1f695fa17dd

Re: Review Request 115477: Remove commands that just set variables to their defaults

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115477/ --- (Updated Feb. 5, 2014, 11:56 a.m.) Status -- This change has been ma

Review Request 115493: Make CMakeLists.txt respect DESTDIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115493/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapido

Re: kf5 alpha 1 : modules, versions

On 02/03/2014 08:17 PM, David Faure wrote: > Any new module that should be added to this release, compared to TP1? > > Should I include attica? > > > Any version number that should be upgraded in the modules themselves? I > realize now that it's all called 5.0.0 everywhere already. The packages

Re: Review Request 115472: fix test for icon path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115472/ --- (Updated Feb. 5, 2014, 11:32 a.m.) Review request for KDE Frameworks and

Re: Review Request 115450: Fix build without KWINDOWSYSTEM_HAVE_X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115450/#review49009 --- QX11Extras is found unconditionally on non-win32 platforms. Bu

Build failed in Jenkins: kapidox_master_qt5 #5

See Changes: [kde] Never use an "-apidocs" suffix with kgenframeworksapidox -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Re: Review Request 115480: Never use an "-apidocs" suffix with kgenframeworksapidox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115480/ --- (Updated Feb. 5, 2014, 11:13 a.m.) Status -- This change has been ma

Re: Review Request 115480: Never use an "-apidocs" suffix with kgenframeworksapidox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115480/#review49007 --- This review has been submitted with commit abbf15f629fdad110a

Re: Review Request 115481: Improve knotifyconfig dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115481/ --- (Updated Feb. 5, 2014, 10:48 a.m.) Review request for KDE Frameworks and

Re: Review Request 115483: Improve kmediaplayer dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115483/ --- (Updated Feb. 5, 2014, 10:24 a.m.) Status -- This change has been ma

Re: Review Request 115483: Improve kmediaplayer dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115483/#review49005 --- This review has been submitted with commit 3bace26eddf52d6e7e

Re: Review Request 115480: Never use an "-apidocs" suffix with kgenframeworksapidox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115480/#review49003 --- Ship it! Ship It! - Aurélien Gâteau On Feb. 4, 2014, 6:38