Review Request 117075: Fix build breakage due to change in kcookiejar dbus interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117075/ --- Review request for KDE Frameworks. Repository: khtml Description --

Re: Review Request 117052: Add ECMSetupQtTranslations

> On March 25, 2014, 3:33 p.m., Alex Merry wrote: > > The docs need cleaning up, but I'd like to concentrate on the API first. > > > > I'd rather this followed the convention of other file-generating macros in > > getting the user to provide a variable name to store the file(s) in, rather > >

Re: Final kde-runtime splitting plan

On Tuesday 25 March 2014 20:00:51 Albert Astals Cid wrote: > Can you give a rationale of why we're removing the following things? > > kfile4 kfile4 is only useful to test a library that is right now on kde4support. Maybe we can move it there if you want. > kio_cgi Who needs to execute a cgi scri

Review Request 117078: Allow compiling kio on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117078/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 117078: Allow compiling kio on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117078/ --- (Updated March 26, 2014, 11:50 a.m.) Review request for KDE Frameworks an

Re: Final kde-runtime splitting plan

On Tuesday 25 March 2014 23:01:39 Luigi Toscano wrote: > Why kreadconfig (which includes kreadconfig and kwriteconfig) is going to be > in plasma-workspace? Isn't it useful for every KConfig-based > component/application? Maybe kde cli tools could be the target... I thought there was another tool

Re: Review Request 117078: Allow compiling kio on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117078/ --- (Updated March 26, 2014, 12:16 p.m.) Review request for KDE Frameworks.

Jenkins build is back to stable : kde4support_master_qt5 #93

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KLibrary to KDE4Support

I'd like to move KLibrary to KDE4Support. From my investigations, I think this will break two things: KWin and Oxygen, both of which use KLibrary but do not link against KDE4Support. Those should be ported to QLibrary + KPluginLoader::findPlugin(), which I'll sort out today. Any objections? Ale

Re: KLibrary to KDE4Support

On Wed, Mar 26, 2014 at 12:46 PM, Alex Merry wrote: > I'd like to move KLibrary to KDE4Support. From my investigations, I > think this will break two things: KWin and Oxygen, both of which use > KLibrary but do not link against KDE4Support. > > Those should be ported to QLibrary + KPluginLoader:

Fwd: [Development] Qt Contributors' Summit 2014 in Berlin 10-11th June

Hello, we will have a Qt Contributors' Summit again. The event is invite only, but I think many people on these lists qualify for the event. Especially if you have lately been submitting patches through gerrit or otherwise been involved with Qt developement consider joining. This is a great ch

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

On Monday 17 March 2014 18:15:09 Kevin Ottens wrote: > Hello, > > Thanks for the feedback! > > Adding kde-promo in CC since it might have implications on future > communication. Ok, reading the whole thing - it seems a simple dot story would be useful to explain that we've made some decisions t

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

Hi! El 26/03/2014 13:04, "Jos Poortvliet" escribió: > > On Monday 17 March 2014 18:15:09 Kevin Ottens wrote: > > Hello, > > > > Thanks for the feedback! > > > > Adding kde-promo in CC since it might have implications on future > > communication. > > Ok, reading the whole thing - it seems a simple

Review Request 117080: cleanup KDirModelTest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117080/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 117080: cleanup KDirModelTest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117080/#review54177 --- autotests/kdirmodeltest.cpp

Build failed in Jenkins: kcoreaddons_master_qt5 #48

See Changes: [agateau] Redefining tr() does *not* work [agateau] Add Messages.sh -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER

Re: Review Request 117078: Allow compiling kio on windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117078/#review54179 --- src/widgets/kpropertiesdialog.cpp

Re: Review Request 117080: cleanup KDirModelTest

> On March 26, 2014, 1:39 p.m., Mark Gaiser wrote: > > autotests/kdirmodeltest.cpp, lines 55-56 > > > > > > Do you really have to make defines for those signals? Sure, it looks > > fancy in the connect lines, but

Re: Review Request 117078: Allow compiling kio on windows

> On March 26, 2014, 1:57 p.m., Mark Gaiser wrote: > > src/widgets/kpropertiesdialog.cpp, line 1618 > > > > > > camelCase. > > > > I would probably just name it as the function is named: "isSuperUser"

Build failed in Jenkins: kcoreaddons_master_qt5 #49

See Changes: [agateau] Update to latest extract-tr-strings signature -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) i

Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117087/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: kde4s

Re: Review Request 117078: Allow compiling kio on windows

> On March 26, 2014, 12:57 p.m., Mark Gaiser wrote: > > src/widgets/kpropertiesdialog.cpp, line 3444 > > > > > > If you change it anyway, you might as well go for C++11: > > for(const QString& userName : use

Re: Review Request 117080: cleanup KDirModelTest

> On March 26, 2014, 12:39 p.m., Mark Gaiser wrote: > > autotests/kdirmodeltest.cpp, lines 55-56 > > > > > > Do you really have to make defines for those signals? Sure, it looks > > fancy in the connect lines, bu

Re: Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117049/#review54198 --- Looks sensible, but can you re-work the unittest to be integra

Re: Review Request 117040: Remove FIXME in KCompletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117040/#review54195 --- Ship it! Yeah, I don't see what the TODO is complaining about

Re: Review Request 117058: plasma-nm CMake fixes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117058/#review54201 --- Ship it! Ship It! - Alex Merry On March 25, 2014, 3:48 p.m

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #194

See Changes: [lueck] move to proper place to get picked up by scripty [luigi.toscano] Use DocBookXML 4.5 for documentation [aleixpol] Port the cmake scripts with regards to documentation [notmart

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #194

See Changes: [lueck] move to proper place to get picked up by scripty [luigi.toscano] Use DocBookXML 4.5 for documentation [aleixpol] Port the cmake scripts with regards to documentation [notma

Re: Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117049/ --- (Updated March 26, 2014, 3:35 p.m.) Review request for KDE Frameworks and

Build failed in Jenkins: kbookmarks_master_qt5 #38

See Changes: [agateau] Use Class::tr() where possible -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace

Build failed in Jenkins: kdeclarative_master_qt5 #42

See Changes: [bhush94] Add KCoreAddons plugin, moved from PlasmaCore -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER)

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #195

See Changes: [bhush94] Formats are now part of KDeclarative repo -- Started by upstream project "plasma-framework_master_qt5" build number 195 originally cau

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #195

See Changes: [bhush94] Formats are now part of KDeclarative repo -- Started by upstream project "plasma-framework_master_qt5" build number 195 originally c

Re: Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117049/#review54211 --- Ship it! Ship It! - Alex Merry On March 26, 2014, 2:35 p.m

Jenkins build is back to normal : kbookmarks_master_qt5 #39

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #196

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 » NoX11,LINBUILDER #196

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kdeclarative_master_qt5 #43

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117089: Use Q_DECL_EXPORT instread of KSERVICE_EXPORT in K_EXPORT_PLUGIN_VERSION

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117089/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 117089: Use Q_DECL_EXPORT instread of KSERVICE_EXPORT in K_EXPORT_PLUGIN_VERSION

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117089/ --- (Updated March 26, 2014, 5:05 p.m.) Review request for KDE Frameworks.

Jenkins build became unstable: kio_master_qt5 #119

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117089: Use Q_DECL_EXPORT instread of KSERVICE_EXPORT in K_EXPORT_PLUGIN_VERSION

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117089/#review54215 --- Ship it! I think it makes sense, it's not linking with KServi

Re: Review Request 117089: Use Q_DECL_EXPORT instread of KSERVICE_EXPORT in K_EXPORT_PLUGIN_VERSION

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117089/#review54216 --- This review has been submitted with commit 9935b5accd8e2447fd

Re: Review Request 117089: Use Q_DECL_EXPORT instread of KSERVICE_EXPORT in K_EXPORT_PLUGIN_VERSION

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117089/ --- (Updated March 26, 2014, 4:28 p.m.) Status -- This change has been m

Re: Review Request 117080: cleanup KDirModelTest

> On March 26, 2014, 1:39 p.m., Mark Gaiser wrote: > > autotests/kdirmodeltest.cpp, lines 55-56 > > > > > > Do you really have to make defines for those signals? Sure, it looks > > fancy in the connect lines, but

Re: Jenkins build became unstable: kio_master_qt5 #119

On Wed, Mar 26, 2014 at 5:14 PM, KDE CI System wrote: > See > > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel >

Re: Jenkins build became unstable: kio_master_qt5 #119

On 26/03/14 16:19, Aleix Pol wrote: > On Wed, Mar 26, 2014 at 5:14 PM, KDE CI System > wrote: > > See > > ___ > Kde-frameworks-devel mailing list > Kde-framework

Build failed in Jenkins: kio_master_qt5 #120

See Changes: [aleixpol] kpasswdserver as KDED module. [aleixpol] compile fix by Nick Katsamas [aleixpol] Shut the compiler up. (DA) [aleixpol] Make all members protected. [aleixpol] Change in the sequence number returned. This fixes some

Build failed in Jenkins: kio_master_qt5 #121

See Changes: [nicolas.alvarez] Fix typos in DESIGN doc for kpasswdserver. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in

Re: Build failed in Jenkins: kio_master_qt5 #120

On 26/03/14 18:50, Aleix Pol wrote: > FWIW, I added the new dependency in dependency-data-kf5-qt5 after > pushing, I don't know how to trigger the build again. You ask someone with sufficient Jenkins karma :-) I think the dependency info updates on the hour, so I'll trigger it when the hour ticks

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

Hello, On Tuesday 25 March 2014 16:41:12 Jos Poortvliet wrote: > On Monday 17 March 2014 18:15:09 Kevin Ottens wrote: > > Adding kde-promo in CC since it might have implications on future > > communication. > > Ok, reading the whole thing - it seems a simple dot story would be useful to > explain

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

On 26 March 2014 20:08, Kevin Ottens wrote: > Hello, > > On Tuesday 25 March 2014 16:41:12 Jos Poortvliet wrote: >> Just imagine what header would you like to see on an announcement/article: >> * Frameworks 5 To Not Include Deprecated Technologies >> * KDE Porting Aids To Have Three Releases >> *

Re: Final kde-runtime splitting plan

El Dimecres, 26 de març de 2014, a les 11:42:01, Àlex Fiestas va escriure: > On Tuesday 25 March 2014 20:00:51 Albert Astals Cid wrote: > > Can you give a rationale of why we're removing the following things? > > > > kfile4 > > kfile4 is only useful to test a library that is right now on kde4supp

Re: Review Request 117042: Make KLineEdit::completionBox virtual so that konq can reimplement it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117042/ --- (Updated March 26, 2014, 9:55 p.m.) Status -- This change has been m

Re: Review Request 117042: Make KLineEdit::completionBox virtual so that konq can reimplement it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117042/#review54242 --- This review has been submitted with commit f228e77cbba2bdbb67

Re: Review Request 117037: Refactor parameter names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117037/ --- (Updated March 26, 2014, 10:01 p.m.) Status -- This change has been

Re: Review Request 117037: Refactor parameter names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117037/#review54245 --- This review has been submitted with commit 5ab3bc1656bef22811

Re: Review Request 117040: Remove FIXME in KCompletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117040/ --- (Updated March 26, 2014, 10:06 p.m.) Status -- This change has been

Re: Review Request 117040: Remove FIXME in KCompletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117040/#review54246 --- This review has been submitted with commit 2f6964af8763c9fed2

Re: Review Request 116969: Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969/#review54248 --- Ping? - David Gil Oliva On March 24, 2014, 9:45 p.m., David

Location of docbooks in frameworks repos

Hi, a) In kde4 docbooks usually were located in a top level folder named "doc" in each repo, in frameworks this folder is named "docs" with an additional *s* , where as the other repos with a frameworks branch seem to use the name "doc" (kate, kde-workspace as of now before the split etc.). Th

Review Request 117103: Remove startup notification code from K(Unique)Application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117103/ --- Review request for KDE Frameworks. Repository: kde4support Description

Review Request 117102: Remove unused methods from KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117102/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 117102: Remove unused methods from KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117102/ --- (Updated March 26, 2014, 10:52 p.m.) Review request for KDE Frameworks an

Re: Review Request 117102: Remove unused methods from KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117102/ --- (Updated March 26, 2014, 10:55 p.m.) Review request for KDE Frameworks an

Re: Review Request 117052: Add ECMSetupQtTranslations

> On March 25, 2014, 2:33 p.m., Alex Merry wrote: > > The docs need cleaning up, but I'd like to concentrate on the API first. > > > > I'd rather this followed the convention of other file-generating macros in > > getting the user to provide a variable name to store the file(s) in, rather > >

Review Request 117104: Remove KLineEdit::clear(): it doesn't seem to modify clipboard anymore

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117104/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Final kde-runtime splitting plan

On Wed, Mar 26, 2014 at 10:02 PM, Albert Astals Cid wrote: > El Dimecres, 26 de març de 2014, a les 11:42:01, Àlex Fiestas va escriure: > > On Tuesday 25 March 2014 20:00:51 Albert Astals Cid wrote: > > > Can you give a rationale of why we're removing the following things? > > > > > > kfile4 > >

Re: Final kde-runtime splitting plan

On Wed, Mar 26, 2014 at 12:37 PM, Carlos De Maine wrote: > On Wed, 26 Mar 2014 11:28:24 AM Àlex Fiestas wrote: > > > On Wednesday 26 March 2014 09:52:08 Carlos De Maine wrote: > > > > On Tue, 25 Mar 2014 04:18:22 PM Àlex Fiestas wrote: > > > > > Hi there > > > > > > > > > > Today Aleix and I are

Re: Location of docbooks in frameworks repos

On Wed, Mar 26, 2014 at 11:22 PM, Burkhard Lück wrote: > Hi, > > a) In kde4 docbooks usually were located in a top level folder named "doc" > in > each repo, in frameworks this folder is named "docs" with an additional > *s* , > where as the other repos with a frameworks branch seem to use the na

Re: Review Request 116969: Deprecate reset() in KHistoryComboBox and substitute it for resetIndex()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969/#review54254 --- I like the cleaning up, but maybe you're being too picky for p

Re: Review Request 117104: Remove KLineEdit::clear(): it doesn't seem to modify clipboard anymore

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117104/#review54255 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 26, 2014,

Review Request 117106: Remove support for htdig index generation from meinproc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117106/ --- Review request for Documentation and KDE Frameworks. Repository: kdoctool

Re: Location of docbooks in frameworks repos

On Wed, March 26, 2014 23:22:22 Burkhard Lück wrote: > Hi, > I think we need a similar *consistent* scheme for docbook location in > frameworks repos. Agreed. You've mentioned 3 different schemes (application, kioslave, kcm modules). Is the full list of possible schemes to be used published som

Re: Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117049/ --- (Updated March 27, 2014, 6:20 a.m.) Status -- This change has been m

Re: Review Request 117049: Ensure that pluginVersion gets resolved for multiple KPluginLoader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117049/#review54263 --- This review has been submitted with commit dc155f4fd02a4dcaa0