Re: Keeping CI green

2014-05-22 Thread Martin Gräßlin
On Thursday 22 May 2014 21:08:05 Alex Merry wrote: > There are currently four frameworks that are yellow (for between 6 hours and > 8 days). kdelibs4support has had 3 commits (not counting those by scripty) > since it broke that have done nothing to fix the issue. One of the failing frameworks is

Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)

2014-05-22 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118270/ --- Review request for KDE Frameworks, kdelibs, Rohan Garg, Jonathan Riddell, a

Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations

2014-05-22 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118269/ --- Review request for KDE Frameworks and David Faure. Bugs: 334648 https

Re: Keeping CI green

2014-05-22 Thread Ben Cooksley
On Fri, May 23, 2014 at 8:08 AM, Alex Merry wrote: > There are currently four frameworks that are yellow (for between 6 hours and 8 > days). kdelibs4support has had 3 commits (not counting those by scripty) since > it broke that have done nothing to fix the issue. > > If we claim that our release

Keeping CI green

2014-05-22 Thread Alex Merry
There are currently four frameworks that are yellow (for between 6 hours and 8 days). kdelibs4support has had 3 commits (not counting those by scripty) since it broke that have done nothing to fix the issue. If we claim that our release schedule means more stability because of our review proces

Re: KUnitConversion apidox

2014-05-22 Thread Alex Merry
On Thursday 22 May 2014 15:19:50 John Layt wrote: > Hi, > > I've just noticed that the KUnitConversion api dox at > http://api.kde.org/frameworks-api/frameworks5-apidocs/kunitconversion/html/i > ndex.html does not have a class list available not the individual classes. > Have I missed something?

Review Request 118264: Switch to PolkitQt5-1

2014-05-22 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118264/ --- Review request for KDE Frameworks. Repository: kauth Description --

Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB

2014-05-22 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252/#review58320 --- > Note: it uses an Atom instead of xcb_atom_t for WM_CHANGE_ST

KUnitConversion apidox

2014-05-22 Thread John Layt
Hi, I've just noticed that the KUnitConversion api dox at http://api.kde.org/frameworks-api/frameworks5-apidocs/kunitconversion/html/index.html does not have a class list available not the individual classes. Have I missed something? Cheers! John. ___

Jenkins build became unstable: kio_master_qt5 #235

2014-05-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118102: Use all entries from a cert attribute instead of just using the first one

2014-05-22 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118102/ --- (Updated May 22, 2014, 1:32 p.m.) Status -- This change has been mar

Re: Review Request 118116: Rename DBus interfaces to use new namespaces

2014-05-22 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118116/ --- (Updated May 22, 2014, 1:32 p.m.) Status -- This change has been mar

Re: Review Request 118104: Fix tests in kio

2014-05-22 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118104/ --- (Updated May 22, 2014, 1:32 p.m.) Status -- This change has been mar

Re: Review Request 118102: Use all entries from a cert attribute instead of just using the first one

2014-05-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118102/#review58309 --- This review has been submitted with commit a250df5c5f5f1b7706

Re: Review Request 118116: Rename DBus interfaces to use new namespaces

2014-05-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118116/#review58308 --- This review has been submitted with commit f4bd1516fc203c0a71

Re: Review Request 118104: Fix tests in kio

2014-05-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118104/#review58307 --- This review has been submitted with commit 211861c8223fee5cc4

Re: Review Request 118102: Use all entries from a cert attribute instead of just using the first one

2014-05-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118102/#review58299 --- Ship it! Ship It! - David Edmundson On May 19, 2014, 1:26

Re: Review Request 118116: Rename DBus interfaces to use new namespaces

2014-05-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118116/#review58298 --- Ship it! Ship It! - David Edmundson On May 19, 2014, 1:27

Re: How to properly encode the supported platforms on api.kde.org?

2014-05-22 Thread Alex Merry
On 22/05/14 08:21, Martin Gräßlin wrote: > Hi, > > I wanted to ask how the platforms on the overview of > http://api.kde.org/frameworks-api/frameworks5-apidocs/ are supposed to be > read. > > E.g. for kwindowsystem it looks like: > * Linux supported > * Windows not supported > * MacOS X not sup

Re: Review Request 118216: Skip non-directory files inside the po/ directory

2014-05-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118216/#review58282 --- Ship it! Ship It! - Alex Merry On May 20, 2014, 1:05 p.m.,

Re: Review Request 118216: Skip non-directory files inside the po/ directory

2014-05-22 Thread Aurélien Gâteau
> On May 20, 2014, 4:15 p.m., Alex Merry wrote: > > Perhaps put some files in the test directories to make sure they are > > ignored? Interestingly, I did put files in the test directories, but they were not added to this request.Maybe post-review decided it was not worth its time since the f

Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB

2014-05-22 Thread Martin Gräßlin
> On May 22, 2014, 10:18 a.m., Thomas Lübking wrote: > > autotests/kwindowsystemx11test.cpp, line 347 > > > > > > found no spec, but from tronche: > > > > "Window managers *may* elect to receive this mes

Re: Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB

2014-05-22 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118252/#review58274 --- autotests/kwindowsystemx11test.cpp

How to properly encode the supported platforms on api.kde.org?

2014-05-22 Thread Martin Gräßlin
Hi, I wanted to ask how the platforms on the overview of http://api.kde.org/frameworks-api/frameworks5-apidocs/ are supposed to be read. E.g. for kwindowsystem it looks like: * Linux supported * Windows not supported * MacOS X not supported This is only half of the story, though. The framework