Re: Review Request 118425: Improve deprecated notes in KSessionManager

2014-06-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118425/#review58919 --- This review has been submitted with commit

Re: Review Request 118425: Improve deprecated notes in KSessionManager

2014-06-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118425/ --- (Updated June 2, 2014, 6:06 a.m.) Status -- This change has been

errors during install of documentation in kio

2014-06-02 Thread David Faure
Something's not right it seems? -- Up-to-date: /d/kde/inst/kde_frameworks/share/doc/HTML/en/kioslave5/data/index.docbook failed to create symbolic link 'share/doc/HTML/en/kioslave5/data/common': No such file or directory -- Up-to-date:

Re: errors during install of documentation in kio

2014-06-02 Thread Luigi Toscano
David Faure ha scritto: Something's not right it seems? -- Up-to-date: /d/kde/inst/kde_frameworks/share/doc/HTML/en/kioslave5/data/index.docbook failed to create symbolic link 'share/doc/HTML/en/kioslave5/data/common': No such file or directory Almost: the symbolic link creation is not

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

2014-06-02 Thread Aleix Pol Gonzalez
On May 26, 2014, 8:11 a.m., Àlex Fiestas wrote: src/platformtheme/CMakeLists.txt, line 4 https://git.reviewboard.kde.org/r/118234/diff/1/?file=273903#file273903line4 This workaround is quite important for 5.3.0 and older at least, maybe in those cases we should make it mandatory?

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

2014-06-02 Thread Alex Merry
On May 26, 2014, 8:11 a.m., Àlex Fiestas wrote: src/platformtheme/CMakeLists.txt, line 4 https://git.reviewboard.kde.org/r/118234/diff/1/?file=273903#file273903line4 This workaround is quite important for 5.3.0 and older at least, maybe in those cases we should make it mandatory?

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

2014-06-02 Thread Martin Gräßlin
On May 26, 2014, 10:11 a.m., Àlex Fiestas wrote: src/platformtheme/CMakeLists.txt, line 4 https://git.reviewboard.kde.org/r/118234/diff/1/?file=273903#file273903line4 This workaround is quite important for 5.3.0 and older at least, maybe in those cases we should make it

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

2014-06-02 Thread Alex Merry
On May 26, 2014, 8:11 a.m., Àlex Fiestas wrote: src/platformtheme/CMakeLists.txt, line 4 https://git.reviewboard.kde.org/r/118234/diff/1/?file=273903#file273903line4 This workaround is quite important for 5.3.0 and older at least, maybe in those cases we should make it mandatory?

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

2014-06-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118234/#review58947 --- What happens with X11 on OS/X? I suspect this is a possible

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

2014-06-02 Thread Martin Gräßlin
On June 2, 2014, 12:48 p.m., Alex Merry wrote: What happens with X11 on OS/X? I suspect this is a possible setup. Is it one we care about? it shouldn't matter as I do hope nobody uses the xcb plugin on MacOS. - Martin --- This is

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

2014-06-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118234/#review58953 --- Ship it! Given the only objection so far has been that maybe

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

2014-06-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118234/ --- (Updated June 2, 2014, 11:44 a.m.) Status -- This change has been

Re: Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

2014-06-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118234/#review58954 --- This review has been submitted with commit

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-06-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/ --- (Updated June 2, 2014, 11:44 a.m.) Status -- This change has been

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-06-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/#review58955 --- This review has been submitted with commit

Re: problems in http kioslave, where to debug?

2014-06-02 Thread Marco Martin
On Sunday 01 June 2014, David Faure wrote: On Sunday 01 June 2014 09:58:09 David Faure wrote: OK, writing this email gave me an idea for a workaround, at least. Can you test it? (attached). I pushed this fix to kio so it becomes part of beta3, tagged today. with the patch, i see that

Re: problems in http kioslave, where to debug?

2014-06-02 Thread Marco Martin
On Monday 02 June 2014, Marco Martin wrote: Changing filecopyJob line 388 to m_getJob = KIO::get(m_src, Reload, HideProgressInfo /* no GUI */); make the download work correctly, even tough is obviously wrong, since it always disables the caches I don't know if is the right approach, but

Review Request 118474: Move networkstatus kded module to kf5/kded subdirectory

2014-06-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118474/ --- Review request for KDE Frameworks. Repository: kdelibs4support

Review Request 118476: Move kded module to kf5/kded subdirectory

2014-06-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118476/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 118473: reset m_request.cacheTag dates in sendQuery()

2014-06-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118473/#review59000 --- This review has been submitted with commit

Re: Review Request 118473: reset m_request.cacheTag dates in sendQuery()

2014-06-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118473/ --- (Updated June 2, 2014, 4:41 p.m.) Status -- This change has been

Re: KIO directory listing - CPU slows down SSD

2014-06-02 Thread Aaron J. Seigo
On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: On Thu, May 29, 2014 at 12:21 AM, Aaron J. Seigo ase It's just a hobby for me to optimize it to levels that match raw speed (without any KIO). meaningful speed improvements would be a reason to change things. if wire compatibility can be

Re: Review Request 118472: Version the kded module files

2014-06-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118472/#review59001 --- Ship it! Ship It! - David Faure On June 2, 2014, 4:04

Re: Review Request 118472: Version the kded module files

2014-06-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118472/ --- (Updated June 2, 2014, 4:52 p.m.) Status -- This change has been

Re: Review Request 118473: reset m_request.cacheTag dates in sendQuery()

2014-06-02 Thread Marco Martin
On June 2, 2014, 4:35 p.m., David Faure wrote: Well spotted. Porting bug (from time_t to QDateTime) in b4d30c9fab4c. I see that it was done also in cacheParseResponseHeader and resetSessionSettings should be probably fixed there too? - Marco

Review Request 118479: Other time_t-QDateTime porting issues

2014-06-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118479/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: KIO directory listing - CPU slows down SSD

2014-06-02 Thread Frank Reininghaus
Hi, 2014-06-02 18:42 GMT+02:00 Aaron J. Seigo: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: dolphin on a massive folder. In fact, those that use kio::listdir for listing folders only have interfaces that become usable when all entries are fetched. assuming these UIs receive

Re: Review Request 118473: reset m_request.cacheTag dates in sendQuery()

2014-06-02 Thread David Faure
On June 2, 2014, 4:35 p.m., David Faure wrote: Well spotted. Porting bug (from time_t to QDateTime) in b4d30c9fab4c. Marco Martin wrote: I see that it was done also in cacheParseResponseHeader and resetSessionSettings should be probably fixed there too? Urgh. Yes, indeed,

Re: Review Request 118479: Other time_t-QDateTime porting issues

2014-06-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118479/ --- (Updated June 2, 2014, 5:13 p.m.) Status -- This change has been

Re: Review Request 118479: Other time_t-QDateTime porting issues

2014-06-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118479/#review59008 --- This review has been submitted with commit

Re: KIO directory listing - CPU slows down SSD

2014-06-02 Thread Mark Gaiser
On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: On Thu, May 29, 2014 at 12:21 AM, Aaron J. Seigo ase It's just a hobby for me to optimize it to levels that match raw speed (without any KIO). meaningful speed

Review Request 118484: Move katepart into a kf5/parts subdir of plugin dir

2014-06-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118484/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository:

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

2014-06-02 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/#review59018 --- The high-level logic makes sense, but I would prefer for

Re: KIO directory listing - CPU slows down SSD

2014-06-02 Thread Frank Reininghaus
Hi, 2014-06-02 20:54 GMT+02:00 Mark Gaiser: On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: dolphin on a massive folder. In fact, those that use kio::listdir for listing folders only have interfaces that become usable when all

Re: KIO directory listing - CPU slows down SSD

2014-06-02 Thread Frank Reininghaus
Hi, 2014-06-02 23:39 GMT+02:00 Frank Reininghaus: Hi, 2014-06-02 20:54 GMT+02:00 Mark Gaiser: On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: dolphin on a massive folder. In fact, those that use kio::listdir for listing folders

Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic

2014-06-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/ --- Review request for KDE Frameworks and Chusslove Illich. Repository:

Re: KIO directory listing - CPU slows down SSD

2014-06-02 Thread Mark Gaiser
On Mon, Jun 2, 2014 at 11:39 PM, Frank Reininghaus frank7...@googlemail.com wrote: Hi, 2014-06-02 20:54 GMT+02:00 Mark Gaiser: On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: dolphin on a massive folder. In fact, those that use

Re: KIO directory listing - CPU slows down SSD

2014-06-02 Thread Mark Gaiser
On Mon, Jun 2, 2014 at 11:47 PM, Frank Reininghaus frank7...@googlemail.com wrote: Hi, 2014-06-02 23:39 GMT+02:00 Frank Reininghaus: Hi, 2014-06-02 20:54 GMT+02:00 Mark Gaiser: On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote:

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-06-02 Thread Ben Cooksley
On 3 June 2014 09:08, Marko Käning mk-li...@email.de wrote: Hi Ben, On 01 Jun 2014, at 23:05 , Ben Cooksley bcooks...@kde.org wrote: That is caused by the patch. It assumes you have kdoctools installed within the sources of kconfigwidgets. This won't work. I see. The solution in this case