Re: Review Request 118484: Move katepart into a kf5/parts subdir of plugin dir

2014-06-03 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118484/#review59032 --- Ship it! If that is the way to do it in KF5, I am OK ;)

Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

2014-06-03 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118489/ --- Review request for KDE Frameworks. Repository: kconfig Description

Review Request 118490: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

2014-06-03 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118490/ --- Review request for KDE Frameworks. Repository: kdnssd Description

Re: Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic

2014-06-03 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/#review59035 --- For KF5 I don't have anything other than tests at the moment.

Re: Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

2014-06-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118489/#review59060 --- Changing the macro name is a no-brainer. Comments below; a

Re: Review Request 118490: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

2014-06-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118490/#review59066 --- Ship it! The actual changes are sensible, hence the shipit,

Re: Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic

2014-06-03 Thread Alex Merry
On June 3, 2014, 7:11 a.m., Chusslove Illich wrote: For KF5 I don't have anything other than tests at the moment. I should soon adapt some of the test programs I used earlier... Could you also check how this patch relates to the commit 06fdfea5? It does the opposite to that commit.

Re: Review Request 118484: Move katepart into a kf5/parts subdir of plugin dir

2014-06-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118484/#review59068 --- This review has been submitted with commit

Re: Review Request 118484: Move katepart into a kf5/parts subdir of plugin dir

2014-06-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118484/ --- (Updated June 3, 2014, 10:19 a.m.) Status -- This change has been

extra-cmake-modules broken noarch support

2014-06-03 Thread Daniel Vrátil
Hi, I noticed that in ECM, the generated file in /usr/share/ECM/cmake/ECMConfigVersion.cmake contains an architecture check: # check that the installed version has the same 32/64bit-ness as the one which is currently searching: if(NOT ${CMAKE_SIZEOF_VOID_P} STREQUAL 4) math(EXPR

Re: Review Request 118270: [doc] explicitly load external entities (after CVE-2014-0191)

2014-06-03 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118270/ --- (Updated June 3, 2014, 3:50 p.m.) Review request for Documentation, KDE

Review Request 118498: Make ECM language-independent again, but make the tests use C

2014-06-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118498/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: extra-cmake-modules broken noarch support

2014-06-03 Thread Alex Merry
On 03/06/14 13:08, Daniel Vrátil wrote: Hi, I noticed that in ECM, the generated file in /usr/share/ECM/cmake/ECMConfigVersion.cmake contains an architecture check: # check that the installed version has the same 32/64bit-ness as the one which is currently searching: if(NOT

Re: How to port KIntSpinBox::setSuffix

2014-06-03 Thread Kevin Ottens
On Sunday 01 June 2014 10:34:07 David Faure wrote: On Friday 30 May 2014 07:54:45 Martin Gräßlin wrote: Hi all, while trying to get rid of kdelibs4support I stumbled [1] over KIntSpinBox::setSuffix which allows to set a plural aware suffix. The recommendation is to port to QSpinBox,

Re: How to port KIntSpinBox::setSuffix

2014-06-03 Thread David Faure
On Tuesday 03 June 2014 17:53:22 Kevin Ottens wrote: On Sunday 01 June 2014 10:34:07 David Faure wrote: On Friday 30 May 2014 07:54:45 Martin Gräßlin wrote: Hi all, while trying to get rid of kdelibs4support I stumbled [1] over KIntSpinBox::setSuffix which allows to set a plural

Re: How to port KIntSpinBox::setSuffix

2014-06-03 Thread Kevin Ottens
Hello, On Tuesday 03 June 2014 17:59:18 David Faure wrote: On Tuesday 03 June 2014 17:53:22 Kevin Ottens wrote: I'm not sure I get the reasoning leading to that conclusion. Can't be done upstream in Qt? This is all about calling i18n() at runtime, from within the widget (when the value

Re: Keeping CI green

2014-06-03 Thread Kevin Ottens
Hello, On Thursday 22 May 2014 21:08:05 Alex Merry wrote: There are currently four frameworks that are yellow (for between 6 hours and 8 days). kdelibs4support has had 3 commits (not counting those by scripty) since it broke that have done nothing to fix the issue. If we claim that our

Review Request 118499: Put kparts into a kf5/parts subdirectory of the plugins dir

2014-06-03 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118499/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: How to port KIntSpinBox::setSuffix

2014-06-03 Thread David Faure
On Tuesday 03 June 2014 18:10:50 Kevin Ottens wrote: Hello, On Tuesday 03 June 2014 17:59:18 David Faure wrote: On Tuesday 03 June 2014 17:53:22 Kevin Ottens wrote: I'm not sure I get the reasoning leading to that conclusion. Can't be done upstream in Qt? This is all about

Deprecation warnings not showing on CMake 3

2014-06-03 Thread Anuj Pahuja
Hi, I am building libkdegames on KF5/Qt5 using CMake 3 but I'm not getting deprecation warnings for KDELibs4Support classes (KDialog, KFileDialog etc.). However, I get all the deprecation warnings when I use CMake 2.8. Also, functions like KGlobal::dirs() do give a warning on CMake 3. Is it some

Re: How to port KIntSpinBox::setSuffix

2014-06-03 Thread laurent Montel
Le mardi 3 juin 2014 19:25:54 David Faure a écrit : On Tuesday 03 June 2014 18:10:50 Kevin Ottens wrote: Hello, On Tuesday 03 June 2014 17:59:18 David Faure wrote: On Tuesday 03 June 2014 17:53:22 Kevin Ottens wrote: I'm not sure I get the reasoning leading to that conclusion. Can't

Re: Keeping CI green

2014-06-03 Thread Alex Merry
On 03/06/14 17:24, Kevin Ottens wrote: I see room for improvement in what gets evaluated when (like ability to run a patch in jenkins as part of the review process), I'm just stuck on the term enforcing there, not sure what you have in mind. Neither am I, to be honest. It just feels like

Re: Review Request 118490: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

2014-06-03 Thread Matthew Dawson
On June 3, 2014, 6:16 a.m., Alex Merry wrote: src/mdnsd-servicetypebrowser.cpp, line 51 https://git.reviewboard.kde.org/r/118490/diff/1/?file=277690#file277690line51 Interesting... any idea which monday? I'm assuming that is any Monday, as that used to be the day to break SIC/BIC

Re: Review Request 118489: Change all occurrences of KDE_NO_DEPRECATED to an appropriate define.

2014-06-03 Thread Matthew Dawson
On June 3, 2014, 6:12 a.m., Alex Merry wrote: Changing the macro name is a no-brainer. Comments below; a lot of them are about binary compatibility issues, and these depend on how we expect this macro to be used. I believe that Qt5 makes all its deprecated functions header-only so

Is plasma-framework not in tier 3?

2014-06-03 Thread Marko Käning
I was wondering why I couldn't find plasma-framework in tier 3 on api.kde.org not below frameworks [1] although it is actually shown as part of tier 3 in the dependency graph in [2] ... What am I missing? [1] http://api.kde.org/frameworks-api/frameworks5-apidocs/ [2]

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-06-03 Thread Marko Käning
Hi folks, there is eventually unexpected SUCCESS ... (... although I didn’t manage to patch Qt's sources to handle a non-standard path ...) ... since as a work-around I have simply copied the file tree installed by kdoctools into the KDE/CI system’s “/Library/Application Support/” folder: