Re: New framework to review: KPackage

2014-12-09 Thread Albert Astals Cid
El Dimecres, 3 de desembre de 2014, a les 16:29:11, Marco Martin va escriure: > Hi all, > > In the past weeks I have been working on a new framework, called KPackage. > (during Akademy seemed there was some interest for applications to use it) > It comes from the old classes Plasma::Package, so is

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

2014-12-09 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452/ --- (Updated Dez. 9, 2014, 10:44 nachm.) Review request for KDE Frameworks an

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-09 Thread Xuetian Weng
> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? 1. icon size (the widget size) doesn't change frequently. Usually it only happens when user resize the UI or changes the

plasma-framework now getting early CI feedback on changes within Gerrit

2014-12-09 Thread Jan Kundrát
Hi, I've activated CI checking for changes proposed to plasma-framework (kio is waiting for a review of two patches which improve test stability). The build environment is different from the one at build.k.o, but the scripts are more or less the same. Both the default build/test variant and t

Jenkins build is back to stable : kio_stable_qt5 #18

2014-12-09 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121299: Add NET::OSD window type

2014-12-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121299/ --- (Updated Dez. 9, 2014, 6:16 nachm.) Review request for KDE Frameworks, kw

Re: Review Request 121411: Don't trigger animation if size changed.

2014-12-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/#review71665 --- Wasn't that part of the idea? Having it scale up the pixmap fi

Review Request 121411: Don't trigger animation if size changed.

2014-12-09 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/ --- Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Kai Uwe

Re: KIO's KDirListerTest::testRefreshRootItem on RHEL7 and XFS

2014-12-09 Thread Jan Kundrát
After applying [1] and [2], I don't see any more test failures -- reviews are appreciated. With kind regards, Jan [1] https://gerrit.vesnicky.cesnet.cz/r/#/c/204/3 [2] https://gerrit.vesnicky.cesnet.cz/r/#/c/208/6 -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/ _

Re: Review Request 119607: Support for ".hidden" files

2014-12-09 Thread Bruno Nova
> On Dez. 6, 2014, 11:03 a.m., David Faure wrote: > > src/core/kcoredirlister.cpp, line 51 > > > > > > split on 2 lines, each with their own comment (more modular and precise) Done. > On Dez. 6, 2014, 11:03 a.m

Baloo Framework - License Exception

2014-12-09 Thread Vishesh Handa
Hey guys I would like to promote Baloo to be a framework for 5.6. All of Baloo's code is LGPL, however, we internally use Xapian as a full text index (GPL). This would make Baloo GPL. Could we have an exception for now? We have been looking into alternatives since we have a rather large share of

Re: Review Request 119607: Support for ".hidden" files

2014-12-09 Thread Bruno Nova
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119607/ --- (Updated Dez. 9, 2014, 2:14 p.m.) Review request for KDE Frameworks and D

Change in kio[master]: Work around non-determinism in tests

2014-12-09 Thread Code Review
Jan Kundrát has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/208 Change subject: Work around non-determinism in tests .. Work around non-determinism in tests Apparently the order in which these events

Re: Review Request 121401: Add Windows VERSIONINFO to KF5CoreAddons.dll

2014-12-09 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121401/#review71633 --- This probably shouldn't go in until ecm has a release with tha

Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon

2014-12-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121379/#review71632 --- Ship it! Very good, maybe we can assume a silent consent. On

Re: MultiPart HTTP requests

2014-12-09 Thread Aleix Pol
On Sat, Dec 6, 2014 at 11:44 AM, David Faure wrote: > On Friday 05 December 2014 16:14:45 Aleix Pol wrote: > > Hi all, > > Every now and then I end up having to generate MultiPart HTTP requests to > > implement some of those fancy HTTP API's to upload images. > > > > I know we have many implement

Re: Review Request 121372: Differeniate between bookmarks for documents and the web

2014-12-09 Thread Gun Chleoc
> On Dec. 8, 2014, 8:40 p.m., Albert Astals Cid wrote: > > I don't think this makes sense at a framework level. If some application is > > so special that really needs a special case, they can call setText over the > > kaction themselves, otherwise we're going to end up havin 20 different "Add