Re: Review Request 122616: Use KIO::FileSystemFreeSpaceJob in KPropertiesDialog

2015-03-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122616/#review77154 --- Ship it! Ship It! - David Faure On Feb. 18, 2015, 8:17

Re: Review Request 122614: Fix a porting bug in the http ioslave

2015-03-07 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122614/ --- (Updated March 7, 2015, 11:33 a.m.) Status -- This change has been

Re: KDE Frameworks 5.8

2015-03-07 Thread David Faure
On Saturday 07 March 2015 19:32:07 šumski wrote: On Saturday 07 of March 2015 17:24:17 David Faure wrote: Dear packagers, Here's KF 5.8.0 New frameworks: kpeople and kxmlrpcclient. A few things regarding kpeople: It requires Qt 5.3, rest of KF5 5.2; Fixed (although I don't have a

Re: KDE Frameworks 5.8

2015-03-07 Thread šumski
On Saturday 07 of March 2015 17:24:17 David Faure wrote: Dear packagers, Here's KF 5.8.0 New frameworks: kpeople and kxmlrpcclient. A few things regarding kpeople: It requires Qt 5.3, rest of KF5 5.2; it uses strange version 0.5.0, rest of KF5 uses the same version as release; it uses

Re: KDE Frameworks 5.8

2015-03-07 Thread Marko Käning
On 07 Mar 2015, at 19:32 , šumski hrvoje.sen...@gmail.com wrote: A few things regarding kpeople: It requires Qt 5.3, rest of KF5 5.2; There are quite a few frameworks which require 5.4 even! signature.asc Description: Message signed with OpenPGP using GPGMail

Re: Review Request 122682: Respect KZip::extraField setting also when writing central header entries

2015-03-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122682/#review77156 --- Ship it! src/kzip.cpp

Re: Review Request 122755: Add testcases for KIO::del()

2015-03-07 Thread David Faure
On March 7, 2015, 10:22 a.m., Emmanuel Pescosta wrote: autotests/deletejobtest.cpp, line 62 https://git.reviewboard.kde.org/r/122755/diff/3/?file=352496#file352496line62 This has broken the KIO build (http://build.kde.org/job/kio_stable_qt5/123/console)

Re: Review Request 122620: Implement quota-used-bytes and quota-available-bytes in http ioslave

2015-03-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122620/#review77166 --- Ship it! I don't know much about webdav, but if it works,

Re: [Kde-games-devel] Data migration issue

2015-03-07 Thread laurent Montel
Le Saturday 07 March 2015 13:47:13 David Faure a écrit : KdePlatformTheme::loadSetting This code runs before the application name is set, but the fallback to argv[0] should still work. [This makes me realize that we should call QCoreApplication::setApplicationName before creating the

Re: Review Request 122620: Implement quota-used-bytes and quota-available-bytes in http ioslave

2015-03-07 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122620/ --- (Updated March 7, 2015, 1:18 p.m.) Status -- This change has been

Jenkins build is back to stable : kservice_stable_qt5 #47

2015-03-07 Thread KDE CI System
See http://build.kde.org/job/kservice_stable_qt5/47/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122755: Add testcases for KIO::del()

2015-03-07 Thread Martin Blumenstingl
On March 7, 2015, 10:22 a.m., Emmanuel Pescosta wrote: autotests/deletejobtest.cpp, line 62 https://git.reviewboard.kde.org/r/122755/diff/3/?file=352496#file352496line62 This has broken the KIO build (http://build.kde.org/job/kio_stable_qt5/123/console)

Jenkins build is back to stable : kservice_master_qt5 #247

2015-03-07 Thread KDE CI System
See http://build.kde.org/job/kservice_master_qt5/247/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122576: Introduce KMoreTools

2015-03-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review77147 --- KService is basically ksycoca. One day I hope we can move

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

2015-03-07 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122621/#review77149 --- Ping - Emmanuel Pescosta On Feb. 18, 2015, 12:14 p.m.,

Re: Review Request 122620: Implement quota-used-bytes and quota-available-bytes in http ioslave

2015-03-07 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122620/#review77164 --- ping src/ioslaves/http/http.h

Re: Review Request 122755: Add testcases for KIO::del()

2015-03-07 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122755/#review77157 --- autotests/deletejobtest.cpp

Jenkins build is back to normal : kio_stable_qt5 #124

2015-03-07 Thread KDE CI System
See http://build.kde.org/job/kio_stable_qt5/124/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122614: Fix a porting bug in the http ioslave

2015-03-07 Thread David Faure
On March 7, 2015, 9:42 a.m., David Faure wrote: src/ioslaves/http/http.cpp, line 854 https://git.reviewboard.kde.org/r/122614/diff/1/?file=350094#file350094line854 I don't like the use of section, when we have QUrl API to do this cleanly. Store

Re: Review Request 122614: Fix a porting bug in the http ioslave

2015-03-07 Thread Emmanuel Pescosta
On March 7, 2015, 10:42 a.m., David Faure wrote: src/ioslaves/http/http.cpp, line 854 https://git.reviewboard.kde.org/r/122614/diff/1/?file=350094#file350094line854 I don't like the use of section, when we have QUrl API to do this cleanly. Store

Re: Review Request 122614: Fix a porting bug in the http ioslave

2015-03-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122614/#review77150 --- src/ioslaves/http/http.cpp

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

2015-03-07 Thread Emmanuel Pescosta
On March 7, 2015, 11:05 a.m., David Faure wrote: sftp/kio_sftp.h, line 215 https://git.reviewboard.kde.org/r/122621/diff/1/?file=350140#file350140line215 not really a todo for this particular class then, it wouldn't change ;) Just copied the comment from smb ioslave, but I agree

Re: Web shortcuts context menu

2015-03-07 Thread David Faure
On Sunday 15 February 2015 17:37:01 Eike Hein wrote: Hi, about two years(?) ago I wrote a Web Shortcuts context menu for Konversation: http://wstaw.org/m/2015/02/15/ctx.png This code subsequently got copied to at least Okular and Konsole, perhaps others - making it an obvious can-

Re: Review Request 122614: Fix a porting bug in the http ioslave

2015-03-07 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122614/ --- (Updated March 7, 2015, 10:29 a.m.) Review request for KDE Frameworks.

KDE/CI for KF5 WAS OSX/CI: libkcddb and ark fail to build for KF5

2015-03-07 Thread Marko Käning
Hi Jeremy AND folks, On 07 Mar 2015, at 02:14 , Jeremy Whiting jpwhit...@kde.org wrote: I appreciate the efforts you are making :) Thanks. :) Just wondering whether I am wasting my time because of my “perfectionism here on OSX/CI. E.g. libkcddb I perhaps shouldn’t have touched at all for

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

2015-03-07 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122621/ --- (Updated March 7, 2015, 11:42 a.m.) Status -- This change has been

Re: [Kde-games-devel] Data migration issue

2015-03-07 Thread David Faure
KdePlatformTheme::loadSetting This code runs before the application name is set, but the fallback to argv[0] should still work. [This makes me realize that we should call QCoreApplication::setApplicationName before creating the application instance, everywhere.]. This function caches that

Re: Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

2015-03-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/#review77148 --- src/widgets/kurlcombobox.cpp

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

2015-03-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122621/#review77155 --- Ship it! sftp/kio_sftp.h

Re: New framework: KXmlRpcClient

2015-03-07 Thread David Faure
On Thursday 26 February 2015 01:06:40 Albert Astals Cid wrote: El Dimecres, 25 de febrer de 2015, a les 13:23:42, David Faure va escriure: On Wednesday 28 January 2015 20:01:45 Albert Astals Cid wrote: El Dimecres, 28 de gener de 2015, a les 16:17:53, David Faure va escriure: On Monday

Re: Review Request 122616: Use KIO::FileSystemFreeSpaceJob in KPropertiesDialog

2015-03-07 Thread Emmanuel Pescosta
On March 7, 2015, 11:01 a.m., David Faure wrote: Ship It! Will push it after 5.8 has been tagged, because it introduces a new i18n string: Unknown size - Emmanuel --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 122614: Fix a porting bug in the http ioslave

2015-03-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122614/#review77153 --- Ship it! Ship It! - David Faure On March 7, 2015, 9:29

Re: KDE Frameworks 5.8

2015-03-07 Thread Alex Merry
On Saturday 07 March 2015 19:59:09 David Faure wrote: On Saturday 07 March 2015 19:32:07 šumski wrote: it uses DATA_INSTALL_DIR/$wanted_dir, rest of KF5 uses KDE_INSTALL_DATADIR_KF5/$wanted_dir (this is not about variable name, but location on the filesystem) Hmm, KAuth still uses

Re: KDE/CI for KF5 WAS OSX/CI: libkcddb and ark fail to build for KF5

2015-03-07 Thread Ben Cooksley
On Sun, Mar 8, 2015 at 12:43 AM, Marko Käning mk-li...@email.de wrote: Hi Jeremy AND folks, Hi Marko, On 07 Mar 2015, at 02:14 , Jeremy Whiting jpwhit...@kde.org wrote: I appreciate the efforts you are making :) Thanks. :) Just wondering whether I am wasting my time because of my