Re: Review Request 123707: Set session manager discard command

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/ --- (Updated May 11, 2015, 4:20 a.m.) Review request for KDE Frameworks and

Re: Versioning of Frameworks

2015-05-10 Thread Christian Mollekopf
On Mon, May 11, 2015, at 12:05 AM, Albert Astals Cid wrote: El Diumenge, 10 de maig de 2015, a les 23:47:32, Christian Mollekopf va escriure: On Sun, May 10, 2015, at 11:23 PM, Albert Astals Cid wrote: El Diumenge, 10 de maig de 2015, a les 22:31:10, Alexander Neundorf va

Re: Opinions on KIO Slave side sorting? Possible GSoC project?

2015-05-10 Thread Mark Gaiser
On Sun, May 3, 2015 at 12:44 AM, David Faure fa...@kde.org wrote: On Thursday 08 January 2015 10:45:13 Mark Gaiser wrote: (wow, time flies) The issue i see here is different processes. KIO::listDir is a process, KDirListerCache lives in the client process. I guess you didn't mean this

Re: Versioning of Frameworks

2015-05-10 Thread Christian Mollekopf
On Sun, May 10, 2015, at 11:13 PM, David Faure wrote: On Sunday 10 May 2015 22:31:10 Alexander Neundorf wrote: There I have Qt available, as Christian says, it feels like a system library, our application is built on it. Well, I wish you would see KF5 as a natural extension of Qt,

Re: Versioning of Frameworks

2015-05-10 Thread Albert Astals Cid
El Diumenge, 10 de maig de 2015, a les 22:33:30, Christian Mollekopf va escriure: On Sun, May 10, 2015, at 03:39 PM, David Faure wrote: On Sunday 10 May 2015 12:36:53 Christian Mollekopf wrote: * I'd consider Qt to be a lower level library. Qt mostly provides fundamentals just like libc

Re: Versioning of Frameworks

2015-05-10 Thread Albert Astals Cid
El Diumenge, 10 de maig de 2015, a les 23:47:32, Christian Mollekopf va escriure: On Sun, May 10, 2015, at 11:23 PM, Albert Astals Cid wrote: El Diumenge, 10 de maig de 2015, a les 22:31:10, Alexander Neundorf va escriure: On Sunday, May 10, 2015 15:39:02 David Faure wrote: On

Re: Review Request 123700: Fix build with cmake 2.8.12.2

2015-05-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123700/#review80188 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 9, 2015,

Re: changelog for 5.10

2015-05-10 Thread Aleix Pol
On Sat, May 9, 2015 at 3:00 PM, Sebastian Kügler se...@kde.org wrote: On Saturday, May 09, 2015 13:06:57 David Faure wrote: On Saturday 09 May 2015 12:52:52 Albert Astals Cid wrote: Why do we need a blog if we have an announcement? https://www.kde.org/announcements/kde-frameworks-5.10.0.php

Re: Review Request 123654: Improve performance of KFileItem and KDirSortFilterProxyModel

2015-05-10 Thread Mark Gaiser
On mei 10, 2015, 10:43 p.m., David Faure wrote: src/core/kfileitem.cpp, line 1115 https://git.reviewboard.kde.org/r/123654/diff/1/?file=366630#file366630line1115 I had the same thought as Milian... but I wonder why I wrote that comment. m_strText is the displayName, m_strName is

Re: Review Request 123714: Only accept existing directories in FileMode::Directory mode

2015-05-10 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123714/ --- (Updated May 10, 2015, 10:01 p.m.) Status -- This change has been

Re: Review Request 123713: KFileWidget: Don't accept files in directory only mode

2015-05-10 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123713/ --- (Updated May 10, 2015, 10:01 p.m.) Status -- This change has been

Re: changelog for 5.10

2015-05-10 Thread Aleix Pol
On Mon, May 11, 2015 at 12:48 AM, David Faure fa...@kde.org wrote: On Saturday 09 May 2015 13:00:54 Sebastian Kügler wrote: On Saturday, May 09, 2015 13:06:57 David Faure wrote: On Saturday 09 May 2015 12:52:52 Albert Astals Cid wrote: Why do we need a blog if we have an announcement?

Re: Versioning of Frameworks

2015-05-10 Thread Alexander Neundorf
On Sunday, May 10, 2015 15:39:02 David Faure wrote: On Sunday 10 May 2015 12:36:53 Christian Mollekopf wrote: * I'd consider Qt to be a lower level library. Qt mostly provides fundamentals just like libc or the STL, and it's therefore okay for me to just work with what I have available.

Re: Versioning of Frameworks

2015-05-10 Thread David Faure
On Sunday 10 May 2015 22:31:10 Alexander Neundorf wrote: There I have Qt available, as Christian says, it feels like a system library, our application is built on it. Well, I wish you would see KF5 as a natural extension of Qt, therefore a system library too, if you want to call it that. Now

Re: Versioning of Frameworks

2015-05-10 Thread David Faure
On Monday 11 May 2015 00:13:27 Christian Mollekopf wrote: Are you volunteering, or just making demands for others to do work for you? I'm volunteering to do the maintenance and release engineering for the libraries that matter to me, and I'm also prepared to work out a proposal on how to

Re: Review Request 123595: Fix KUser test for Mac.

2015-05-10 Thread Alex Richardson
On May 6, 2015, 5:40 p.m., René J.V. Bertin wrote: I'm not sure, after reading http://pig.made-it.com/uidgid.html also: ``` id nobody uid=4294967294(nobody) gid=4294967294(nobody)

Review Request 123719: kbuildsycoca: parse all the mimeapps.list files mentionned in the new spec.

2015-05-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123719/ --- Review request for KDE Frameworks and Luc Menut. Repository: kservice

Re: Versioning of Frameworks

2015-05-10 Thread Christian Mollekopf
On Sun, May 10, 2015, at 03:39 PM, David Faure wrote: On Sunday 10 May 2015 12:36:53 Christian Mollekopf wrote: * I'd consider Qt to be a lower level library. Qt mostly provides fundamentals just like libc or the STL, and it's therefore okay for me to just work with what I have available.

Re: Review Request 123654: Improve performance of KFileItem and KDirSortFilterProxyModel

2015-05-10 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123654/#review80187 --- autotests/kdirsortfilterproxymodel_benchmark.cpp (line 2)

Re: kbuildsycoca5 crashing

2015-05-10 Thread Bhushan Shah
On Sun, May 10, 2015 at 5:43 PM, Jeremy Whiting jpwhit...@kde.org wrote: Somehow kbuildsycoca5 is crashing here lately. I nuked my whole kde prefix (/usr/local) and rebuilt with packaged qt from my distro (arch). But kbuildsycoca5 is crashing every time I run it with some issue in QByteArray.

kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
Hey all, Somehow kbuildsycoca5 is crashing here lately. I nuked my whole kde prefix (/usr/local) and rebuilt with packaged qt from my distro (arch). But kbuildsycoca5 is crashing every time I run it with some issue in QByteArray. Has anyone seen this lately/before or know how I can get past it?

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
It sure isn't. I've also tried nuking ~/.cache/ksycoca5* and such. Same result. ~/.cache is owned by me and has decent permissions also. On Sun, May 10, 2015 at 6:21 AM, Bhushan Shah bhus...@gmail.com wrote: On Sun, May 10, 2015 at 5:43 PM, Jeremy Whiting jpwhit...@kde.org wrote: Somehow

Re: Review Request 123713: KFileWidget: Don't accept files in directory only mode

2015-05-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123713/#review80162 --- Ship it! - David Faure On May 10, 2015, 9:37 a.m., David

Re: Review Request 123714: Only accept existing directories in FileMode::Directory mode

2015-05-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123714/#review80163 --- Ship it! Ship It! - David Faure On May 10, 2015, 9:56

Re: Review Request 123706: Forward QSessionManager to KConfigGui

2015-05-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/#review80164 --- src/kmainwindow.cpp (line 122)

Review Request 123713: KFileWidget: Don't accept files in directory only mode

2015-05-10 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123713/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 123705: Add 2nd variant for KConfigGui::sessionConfig()

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/ --- (Updated May 10, 2015, 10:30 a.m.) Review request for KDE Frameworks and

Re: Review Request 123707: Set session manager discard command

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/ --- (Updated May 10, 2015, 10:47 a.m.) Review request for KDE Frameworks and

Re: Versioning of Frameworks

2015-05-10 Thread Christian Mollekopf
On Sat, May 9, 2015, at 01:27 PM, David Faure wrote: On Saturday 09 May 2015 13:08:35 Alexander Neundorf wrote: we pretend it's all independent libraries but still they all depend on the latest version of all other libs. It's a question of the definition of independent. E.g.

Re: Review Request 123706: Forward QSessionManager to KConfigGui

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/ --- (Updated May 10, 2015, 10:15 a.m.) Review request for KDE Frameworks and

Review Request 123714: Only accept existing directories in FileMode::Directory mode

2015-05-10 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123714/ --- Review request for KDE Frameworks. Repository: frameworkintegration

Re: debugfull - debug

2015-05-10 Thread Alex Merry
On Thursday 07 May 2015 22:57:47 Jaroslaw Staniek wrote: Hi, As with some other bits of knowledge during porting today I just share this one: https://community.kde.org/index.php?title=Calligra/Building/3diff=42353old id=42349 When you use Qt4/KF5, debugfull is dead [1] so you'd be

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

2015-05-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/#review80176 --- Ship it! So now we have a setter that returns a value ;)

Re: Review Request 123706: Forward QSessionManager to KConfigGui

2015-05-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/#review80177 --- Ship it! Ship It! - David Faure On May 10, 2015, 4:05

Re: Review Request 123706: Forward QSessionManager to KConfigGui

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/ --- (Updated May 10, 2015, 5:12 p.m.) Review request for KDE Frameworks and

Re: Review Request 123707: Set session manager discard command

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/ --- (Updated May 10, 2015, 5:11 p.m.) Review request for KDE Frameworks and

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/ --- (Updated May 10, 2015, 5:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 123705: Add 2nd variant for KConfigGui::sessionConfig()

2015-05-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/#review80165 --- src/gui/kconfiggui.cpp (line 45)

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
Also, while this is happening I did a package upgrade to see if it's a Qt packaging problem. I got another update of Qt packages from the arch repo (5.4.1-6 now) But I still get the same issues (kbuildsycoca5 crash and login dbus issue). I'll start a fresh rebuild and look later today I guess.

Re: Review Request 123595: Fix KUser test for Mac.

2015-05-10 Thread David Faure
On May 6, 2015, 4:40 p.m., René J.V. Bertin wrote: I'm not sure, after reading http://pig.made-it.com/uidgid.html also: ``` id nobody uid=4294967294(nobody) gid=4294967294(nobody)

Re: kbuildsycoca5 crashing

2015-05-10 Thread David Faure
On Sunday 10 May 2015 07:49:48 Jeremy Whiting wrote: ==2883== Address 0x is not stack'd, malloc'd or (recently) free'd This must be a miscompilation, I see no other reason for the refcount of a QByteArray to be at address 0x. Try rebuilding kservice from scratch. -- David

Re: kbuildsycoca5 crashing

2015-05-10 Thread David Faure
On Sunday 10 May 2015 08:24:48 Jeremy Whiting wrote: Rebuilt kservice (and nuked my build folder and /usr/local just to be doubly sure.) kbuildsycoca5 still crashes with this same backtrace, no idea why. Could it be a bug in QtCore? Arch testing packages of Qt? I doubt it. More likely a

Re: Review Request 123705: Add 2nd variant for KConfigGui::sessionConfig()

2015-05-10 Thread David Faure
On May 9, 2015, 7:42 p.m., David Faure wrote: With this API change, I wonder if it makes sense for kconfiggui.cpp to retain ownership of the KConfig object. Wouldn't it be safer if the caller got ownership of it, saved into it, and then discarded the KConfig instance? Then we

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
I see. Some kde applications segfault (klettres, okular) other's run ok (dolphin, khangman) I haven't tried others. As for qt binaries I checked the binaries that come with the arch package, and assistant, designer, qdbusviewer all work fine. Is there one in particular I should check? On Sun, May

Re: Review Request 123707: Set session manager discard command

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/ --- (Updated May 10, 2015, 4:03 p.m.) Review request for KDE Frameworks and

Re: Review Request 123706: Forward QSessionManager to KConfigGui

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/ --- (Updated May 10, 2015, 2:39 p.m.) Review request for KDE Frameworks and

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
Also, none of the recent patches on https://projects.archlinux.org/svntogit/packages.git/log/trunk?h=packages/qt5 make me nervous, all seem to be pretty straightforward. Could it be lower level as in my glibc is too new, or the compiler itself (GCC 5.1.0) On Sun, May 10, 2015 at 8:54 AM, Jeremy

Re: Review Request 123705: Add 2nd variant for KConfigGui::sessionConfig()

2015-05-10 Thread Stefan Becker
On May 9, 2015, 7:42 p.m., David Faure wrote: With this API change, I wonder if it makes sense for kconfiggui.cpp to retain ownership of the KConfig object. Wouldn't it be safer if the caller got ownership of it, saved into it, and then discarded the KConfig instance? Then we

Re: Review Request 123705: Add 2nd variant for KConfigGui::sessionConfig()

2015-05-10 Thread David Faure
On May 9, 2015, 7:42 p.m., David Faure wrote: With this API change, I wonder if it makes sense for kconfiggui.cpp to retain ownership of the KConfig object. Wouldn't it be safer if the caller got ownership of it, saved into it, and then discarded the KConfig instance? Then we

Re: Review Request 123706: Forward QSessionManager to KConfigGui

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/ --- (Updated May 10, 2015, 4:05 p.m.) Review request for KDE Frameworks and

Re: kbuildsycoca5 crashing

2015-05-10 Thread David Faure
On Sunday 10 May 2015 06:13:15 Jeremy Whiting wrote: #7 0x004363d0 in QLinkedListKSycocaResource::detach (this=0x69b140) at /usr/include/qt/QtCore/qlinkedlist.h:99 Is that Qt4 or Qt5? Use ldd on your kbuildsycoca5 binary to check which Qt libs it's using. (and the next step if all

Re: Versioning of Frameworks

2015-05-10 Thread David Faure
On Sunday 10 May 2015 12:36:53 Christian Mollekopf wrote: * I'd consider Qt to be a lower level library. Qt mostly provides fundamentals just like libc or the STL, and it's therefore okay for me to just work with what I have available. I hope you can understand that the decision on how Qt (on

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
Yep, it's Qt5. After rebuilding everything trying to log into a plasma session I get startkde: could not sync environment to dbus in .xsession-errors, not much before that besides a bad dbus call. Seems very similar to https://bugzilla.redhat.com/show_bug.cgi?id=1191171 I've never thought

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
Rebuilt kservice (and nuked my build folder and /usr/local just to be doubly sure.) kbuildsycoca5 still crashes with this same backtrace, no idea why. Could it be a bug in QtCore? Arch testing packages of Qt? 0x is -1, no? did it get decreased one too many times somehow? On Sun, May 10,

Re: Review Request 123705: Add 2nd variant for KConfigGui::sessionConfig()

2015-05-10 Thread Stefan Becker
On May 9, 2015, 7:42 p.m., David Faure wrote: With this API change, I wonder if it makes sense for kconfiggui.cpp to retain ownership of the KConfig object. Wouldn't it be safer if the caller got ownership of it, saved into it, and then discarded the KConfig instance? Then we

Re: Review Request 123707: Set session manager discard command

2015-05-10 Thread Stefan Becker
On May 9, 2015, 7:52 p.m., David Faure wrote: src/core/kconfig.h, line 368 https://git.reviewboard.kde.org/r/123707/diff/1/?file=367996#file367996line368 I don't think this API is good to have (which is why it was never added). Most kconfig instances are a view over multiple

Re: kbuildsycoca5 crashing

2015-05-10 Thread Albert Astals Cid
El Diumenge, 10 de maig de 2015, a les 08:57:28, Jeremy Whiting va escriure: Also, none of the recent patches on https://projects.archlinux.org/svntogit/packages.git/log/trunk?h=packages/qt 5 make me nervous, all seem to be pretty straightforward. Could it be lower level as in my glibc is too

Re: Review Request 123705: Add KConfigGui::setSessionConfig()

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123705/ --- (Updated May 10, 2015, 4:01 p.m.) Review request for KDE Frameworks and

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
I only built kf5/kde applications. Though I've no idea what compiler was used to build the Qt packages. probably g++ 4.9 from arch stable I bet. /me removes testing, downgrades the dozen packages from it and will rebuild. Thanks for the tips both of you. Hopefully I can finish the 15.04.1 release

Re: kbuildsycoca5 crashing

2015-05-10 Thread Jeremy Whiting
\o/ KService built with a downgraded (4.9.1) g++ works fine. Sorry for the noise. Should be able to detect this sort of problem quickly in the future though. I'll stick with non testing arch for the time being. On Sun, May 10, 2015 at 10:07 AM, Jeremy Whiting jpwhit...@kde.org wrote: I only

Re: Versioning of Frameworks

2015-05-10 Thread Jan Kundrát
On Sunday, 10 May 2015 15:39:02 CEST, David Faure wrote: Qt *is* splitted. It's just that the splitted libs are released together. The splitting of Qt is not full and complete, however. Modules tend to use each other's internal APIs, and that's the biggest reason for not supporting random

Re: Review Request 123595: Fix KUser test for Mac.

2015-05-10 Thread René J . V . Bertin
On May 6, 2015, 6:40 p.m., René J.V. Bertin wrote: I'm not sure, after reading http://pig.made-it.com/uidgid.html also: ``` id nobody uid=4294967294(nobody) gid=4294967294(nobody)

Re: Review Request 123707: Set session manager discard command

2015-05-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/#review80186 --- If filePath() is relative, it can't be used in a discard