Re: Review Request 124121: KPlotWidget: add setAutoDeletePlotObjects, fix memory leak in replacePlotObject

2015-06-19 Thread David Faure
> On June 18, 2015, 5:56 p.m., David Edmundson wrote: > > src/kplotwidget.h, line 190 > > > > > > might be good to explain that KPlotWidget will take ownership (unless > > set otherwise) Hehe, yeah, I added tha

Re: Review Request 124121: KPlotWidget: add setAutoDeletePlotObjects, fix memory leak in replacePlotObject

2015-06-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124121/ --- (Updated June 19, 2015, 10:20 a.m.) Review request for KDE Frameworks and

Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

2015-06-19 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124128/ --- Review request for KDE Frameworks and David Edmundson. Repository: kcorea

KCoreaddons build failiure on ARM

2015-06-19 Thread Rohan Garg
Hi I'm trying to compile kcoreaddons on ARM with clang and I'm hitting this build failiure : 06:22:27 ../../../src/lib/io/kfilesystemtype.cpp:112:10: error: case value evaluates to 2240043254, which cannot be narrowed to type '__fsword_t' (aka 'int') [-Wc++11-narrowing] 06:22:27 case RAMFS_MAG

Review Request 124129: Fix KAuthorized config file loading

2015-06-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124129/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig

Re: Review Request 124129: Fix KAuthorized config file loading

2015-06-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124129/#review81575 --- +1 - Aleix Pol Gonzalez On June 19, 2015, 9:20 p.m., David

Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-19 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81586 --- +1, this is useful and a clean implementation IMO. - Sebastia

Re: Review Request 123890: Don't show "KDE Frameworks version" in the About KDE dialog

2015-06-19 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123890/#review81587 --- Since there's an informal +1 and no disagreement i'll commit i

Review Request 124134: Fixing KDED string references

2015-06-19 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124134/ --- Review request for KDE Frameworks. Repository: kio Description ---