QPA plugin like functionality in frameworks?

Hi framework-developers and packagers, with two frameworks I'm currently in the need to have something like QPA. I want to make it possible to provide windowing-system specific plugins for frameworks using a private API. The need arises first of all in kwindowsystem to support wayland [1]. To i

Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124155/ --- Review request for KDE Frameworks. Bugs: 349513 https://bugs.kde.org/

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124155/#review81700 --- src/kstatusnotifieritem.h (line 413)

Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124156/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124156/#review81703 --- Ship it! Ship It! - Jeremy Whiting On June 23, 2015, 5:33

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124155/ --- (Updated June 23, 2015, 2:04 p.m.) Review request for KDE Frameworks. B

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124156/#review81702 --- autotests/krearrangecolumnsproxymodeltest.cpp (line 180)

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124155/#review81704 --- +1 - Mark Gaiser On jun 23, 2015, 12:04 p.m., Martin Klapet

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

> On June 23, 2015, 12:26 p.m., Mark Gaiser wrote: > > src/krearrangecolumnsproxymodel.h, line 71 > > > > > > add line break Where, between methods? I like the current grouping ;) > On June 23, 2015, 12:26 p.m.

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

On June 23, 2015, 12:26 p.m., David Faure wrote: > > Regarding the style. AStyle time i think ;) > > There is lots of function( arg ) instead of function(arg). ?besides that, > > some places could use more line breaks for readability (marked above). > > > > Some API questions. > > setSourceColu

Re: Review Request 124118: Make it possible to use KCoreAddons's desktoptojson in cross-compiled environments

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124118/#review81708 --- Ship it! Ship It! - David Edmundson On June 18, 2015, 4:36

Re: QPA plugin like functionality in frameworks?

On Tue, Jun 23, 2015 at 9:42 AM, Martin Gräßlin wrote: > Hi framework-developers and packagers, > > with two frameworks I'm currently in the need to have something like QPA. I > want to make it possible to provide windowing-system specific plugins for > frameworks using a private API. The need ari

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

> On jun 23, 2015, 12:26 p.m., Mark Gaiser wrote: > > src/krearrangecolumnsproxymodel.h, line 71 > > > > > > add line break > > David Faure wrote: > Where, between methods? I like the current grouping ;) My

Re: Review Request 124138: Install kconfig_compiler into libexec

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124138/ --- (Updated June 23, 2015, 7:46 p.m.) Status -- This change has been ma

Re: Review Request 124118: Make it possible to use KCoreAddons's desktoptojson in cross-compiled environments

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124118/ --- (Updated June 23, 2015, 7:56 p.m.) Status -- This change has been ma

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

> On June 23, 2015, 12:26 p.m., Mark Gaiser wrote: > > src/krearrangecolumnsproxymodel.h, line 92 > > > > > > can you make a smart pointer of this one? I prefer std::unique_ptr<...> > > but the Qt versions are ob

Re: Review Request 124156: KItemModels: new proxy KRearrangeColumnsProxyModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124156/ --- (Updated June 23, 2015, 9:33 p.m.) Review request for KDE Frameworks. C