---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124156/#review81718
---
Ship it!
Ok, looks good to me. Minor nitpick below :)
On jun 23, 2015, 12:26 p.m., David Faure wrote:
Regarding the style. AStyle time i think ;)
There is lots of function( arg ) instead of function(arg). ?besides that,
some places could use more line breaks for readability (marked above).
Some API questions.
setSourceColumns seems to
On June 21, 2015, 8:50 p.m., Aleix Pol Gonzalez wrote:
I'm not very fond of the customProperty().isNull method, maybe it would
make sense to add a ::ProvidedKeys field we can use. Any thoughts?
Yeah, seems that would be better (::ProvidedProperties).
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124143/#review81720
---
Ship it!
src/personssortfilterproxymodel.h (line 42)
On Wed, Jun 24, 2015 at 9:51 AM, Martin Gräßlin mgraess...@kde.org wrote:
On Tuesday 23 June 2015 19:35:48 Aleix Pol wrote:
On Tue, Jun 23, 2015 at 9:42 AM, Martin Gräßlin mgraess...@kde.org wrote:
Hi framework-developers and packagers,
with two frameworks I'm currently in the need to have
On June 24, 2015, 9:17 p.m., Alex Merry wrote:
src/kconfig_compiler/CMakeLists.txt, line 13
https://git.reviewboard.kde.org/r/124104/diff/2/?file=380381#file380381line13
A bit late to the party, sorry, but this would be better as
message(WARNING ...).
You're right. I'll add it
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124143/
---
(Updated June 24, 2015, 6:05 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124128/#review81726
---
src/lib/io/kdirwatch.cpp (lines 197 - 198)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124165/
---
(Updated June 24, 2015, 5 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124104/#review81729
---
src/kconfig_compiler/CMakeLists.txt (line 13)
On Thursday 18 June 2015 21:44:29 Albert Astals Cid wrote:
I just came back from a 3 week holiday and there's emails (with one dating
back from June 1) that have not been moderated.
So i guess we need more hands for the next time i decide to go on holiday :D
I'm happy to volunteer.
Alex
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124156/
---
(Updated June 24, 2015, 8:13 p.m.)
Status
--
This change has been
12 matches
Mail list logo
