Re: Review Request 124364: Don't rely on options()->initialDirectory() for Qt < 5.4

> On July 15, 2015, 7:20 p.m., Kåre Särs wrote: > > I have been looking a bit at the frameworks integration just around that > > code sniplet and wondered why KDEPlatformFileDialogHelper::setDirectory() > > is called three times every time the file dialog is opened. And for remote > > protocol

Re: Review Request 124364: Don't rely on options()->initialDirectory() for Qt < 5.4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124364/#review82549 --- I have been looking a bit at the frameworks integration just a

Re: Review Request 124364: Don't rely on options()->initialDirectory() for Qt < 5.4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124364/ --- (Updated July 15, 2015, 3:29 p.m.) Status -- This change has been ma

Re: Review Request 124150: Fix KCoreAddons build on Clang+ARM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124150/ --- (Updated July 15, 2015, 3:27 p.m.) Status -- This change has been ma

Re: Review Request 124306: Don't choke on empty QIconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124306/ --- (Updated July 15, 2015, 3:24 p.m.) Status -- This change has been ma

Re: Review Request 124306: Don't choke on empty QIconItem

> On July 13, 2015, 12:49 p.m., David Edmundson wrote: > > it would be more performant to delete the node if it's empty. > > > > though this is still fine. If I return a null node, I get such a crash: ``` #0 QSGTexture::setFiltering() at /home/kde-devel/frameworks/qt5/qtdeclarative/src/quick/

Re: Review Request 124364: Don't rely on options()->initialDirectory() for Qt < 5.4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124364/#review82546 --- Ship it! Ship It! - Marco Martin On July 15, 2015, 2:42 p.

Re: Review Request 124150: Fix KCoreAddons build on Clang+ARM

> On July 15, 2015, 8:49 p.m., Rohan Garg wrote: > > Ship It! Compiles fine on my board, tests run fine too. - Rohan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124150/#review82543 -

Re: Review Request 124150: Fix KCoreAddons build on Clang+ARM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124150/#review82543 --- Ship it! Ship It! - Rohan Garg On June 22, 2015, 10:43 p.m

Re: Review Request 124307: Remove Theme tree debug entry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124307/ --- (Updated July 15, 2015, 3:14 p.m.) Status -- This change has been ma

Re: Review Request 124307: Remove Theme tree debug entry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124307/#review82542 --- Ship it! Ship It! - David Edmundson On July 9, 2015, 2:55

Review Request 124364: Don't rely on options()->initialDirectory() for Qt < 5.4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124364/ --- Review request for KDE Frameworks and Leszek Lesner. Repository: framewor

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

> On jul 15, 2015, 9:36 a.m., Milian Wolff wrote: > > src/kextracolumnsproxymodel.cpp, line 85 > > > > > > ah, a pity. Btw, in KDevelop where I can use lambdas (can you here?), I > > stopped using private signals

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/#review82536 --- Ship it! Yu are right about QPMI, but it just shows again how

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/ --- (Updated July 15, 2015, 8:59 a.m.) Review request for KDE Frameworks, Jes

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

> On July 14, 2015, 4:58 p.m., Milian Wolff wrote: > > src/kextracolumnsproxymodel.cpp, line 44 > > > > > > these two really should be QVector. As far as I can see, you do not > > interact with the Qt API and thu

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

> On July 15, 2015, 5:54 a.m., Sune Vuorela wrote: > > src/kextracolumnsproxymodel.h, line 39 > > > > > > Are there any of these "not supported" things we might want to support > > in the future? Can we implement