Re: Failure while executing KTar::open while using KCompressionDevice as the device

2015-11-02 Thread Aleix Pol
On Tue, Nov 3, 2015 at 3:00 AM, Luiz Romário Santana Rios wrote: > 2015-11-02 22:41 GMT-03:00 Aleix Pol : >> On Mon, Nov 2, 2015 at 6:53 PM, Luiz Romário Santana Rios >> wrote: >>> Hello, >>> >>> I'm trying to decompress a XZ archive downloaded using >>> QNetworkAccessManager, so, according to th

Re: Failure while executing KTar::open while using KCompressionDevice as the device

2015-11-02 Thread Luiz Romário Santana Rios
2015-11-02 22:41 GMT-03:00 Aleix Pol : > On Mon, Nov 2, 2015 at 6:53 PM, Luiz Romário Santana Rios > wrote: >> Hello, >> >> I'm trying to decompress a XZ archive downloaded using >> QNetworkAccessManager, so, according to the documents, I have to pass >> the QNetworkReply pointer to a KCompression

Re: Failure while executing KTar::open while using KCompressionDevice as the device

2015-11-02 Thread Aleix Pol
On Mon, Nov 2, 2015 at 6:53 PM, Luiz Romário Santana Rios wrote: > Hello, > > I'm trying to decompress a XZ archive downloaded using > QNetworkAccessManager, so, according to the documents, I have to pass > the QNetworkReply pointer to a KCompressionDevice and, then, use it as > Ktar's device like

Re: Failure while executing KTar::open while using KCompressionDevice as the device

2015-11-02 Thread Luiz Romário Santana Rios
Em 02/11/2015 16:31, "Boudhayan Gupta" escreveu: > > I'd first ascertain whether the file is corrupt. I'm pretty sure the file is OK. As a workaround, I had to write the downloaded contents into a temporary file, then extract the contents from the temp file using KTar, but I have to change that, s

Re: KPixmapCache in kdelibs4support uses QDateTime in mmap'ed struct

2015-11-02 Thread Michael Pyne
On Tue, November 3, 2015 00:40:58 Albert Astals Cid wrote: > Someone went a bit too far in the "port away from time_t to QDateTime" and > changed the timestamp member of the KPixmapCacheIndexHeader struct. > > According to mpyne and thiago this is a big no-no. The reason it's a big no-no is becau

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux, All, gcc - Build # 116 - Still Unstable!

2015-11-02 Thread Albert Astals Cid
El Monday 02 November 2015, a les 14:56:15, Marco Martin va escriure: > On Monday 02 November 2015, David Faure wrote: > > On Monday 02 November 2015 12:44:12 no-re...@kde.org wrote: > > > https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFO > > > R > > > M=Linux,compiler=gcc/31

KPixmapCache in kdelibs4support uses QDateTime in mmap'ed struct

2015-11-02 Thread Albert Astals Cid
Someone went a bit too far in the "port away from time_t to QDateTime" and changed the timestamp member of the KPixmapCacheIndexHeader struct. According to mpyne and thiago this is a big no-no. I'm suggesting bringing the code back to using time_t so it still works, this may be a bit less porta

Re: Failure while executing KTar::open while using KCompressionDevice as the device

2015-11-02 Thread Boudhayan Gupta
I'd first ascertain whether the file is corrupt. Why don't you dump the tar to a QFile and manually use tar -xvf to extract it, just to test whether the download is working? On 2 November 2015 at 23:23, Luiz Romário Santana Rios wrote: > Hello, > > I'm trying to decompress a XZ archive downloaded

Review Request 125924: KJob::kill(Quiet) should also exit the event loop

2015-11-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125924/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Failure while executing KTar::open while using KCompressionDevice as the device

2015-11-02 Thread Luiz Romário Santana Rios
Hello, I'm trying to decompress a XZ archive downloaded using QNetworkAccessManager, so, according to the documents, I have to pass the QNetworkReply pointer to a KCompressionDevice and, then, use it as Ktar's device like this: https://gist.github.com/anonymous/b8fb686367f518a7dbb5 The problem i

Re: Review Request 125817: Add plugin system for Calendar events

2015-11-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/ --- (Updated Nov. 2, 2015, 6:35 p.m.) Review request for KDE Frameworks, Plas

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 117 - Still Unstable!

2015-11-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/117/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 02 Nov 2015 13:28:29 + Build duration: 7 min 11 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 126 - Still Unstable!

2015-11-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/126/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 02 Nov 2015 13:28:29 + Build duration: 3 min 2 sec CHANGE SET Rev

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 116 - Still Unstable!

2015-11-02 Thread Marco Martin
On Monday 02 November 2015, David Faure wrote: > On Monday 02 November 2015 12:44:12 no-re...@kde.org wrote: > > https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFOR > > M=Linux,compiler=gcc/31/ Name: (root) Failed: 1 test(s), Passed: 10 > > test(s), Skipped: 0 test(s), Total:

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux, All, gcc - Build # 116 - Still Unstable!

2015-11-02 Thread David Faure
On Monday 02 November 2015 12:44:12 no-re...@kde.org wrote: > https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ > Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), > Total: 11 test(s)Failed: TestSuite.dialognativetest Is anyone

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 125 - Still Unstable!

2015-11-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/125/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 02 Nov 2015 12:31:09 + Build duration: 3 min 5 sec CHANGE SET Rev

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 116 - Still Unstable!

2015-11-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/116/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 02 Nov 2015 12:31:09 + Build duration: 3 min 3 sec CHANGE SET Revision 0

Re: Review Request 125915: Drop runtime dependency on QApplication

2015-11-02 Thread Martin Gräßlin
> On Nov. 2, 2015, 9:04 a.m., Martin Gräßlin wrote: > > I consider this a very dangerous change. We don't have unit tests for this > > specific code, it's an unlikely code path to be taken and we won't notice > > regressions. > > > > Personally I don't see a problem with having a dependency on

Re: Review Request 125911: EventGenerator: Add support for sending wheel events

2015-11-02 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125911/ --- (Updated Nov. 2, 2015, 9:48 a.m.) Status -- This change has been mar

Re: Review Request 125915: Drop runtime dependency on QApplication

2015-11-02 Thread David Edmundson
> On Nov. 2, 2015, 8:04 a.m., Martin Gräßlin wrote: > > I consider this a very dangerous change. We don't have unit tests for this > > specific code, it's an unlikely code path to be taken and we won't notice > > regressions. > > > > Personally I don't see a problem with having a dependency on

Re: Review Request 125905: Make kactivitymanagerd a QApplication

2015-11-02 Thread Martin Gräßlin
> On Nov. 1, 2015, 12:49 p.m., Ivan Čukić wrote: > > So, we went a full circle back to QApplication :) > > > > What assert are you hitting on unity? > > Albert Astals Cid wrote: > KWindowSystem uses QApplication::desktopWidget which you can't if you're > not a QApplication > What assert a

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 31 - Still Unstable!

2015-11-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 Nov 2015 09:21:58 + Build duration: 4 min 1 sec CHANGE SET Revision 70c200431e02fc00ce1e496ead

Re: Review Request 125884: Set default value for WheelScrollLines

2015-11-02 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125884/ --- (Updated Nov. 2, 2015, 9:21 a.m.) Status -- This change has been mar

Re: Review Request 125905: Make kactivitymanagerd a QApplication

2015-11-02 Thread Martin Gräßlin
> On Nov. 1, 2015, 11:35 p.m., David Edmundson wrote: > > I've made https://git.reviewboard.kde.org/r/125915/ back referencing my comment to that review: I think trying to change KWindowSystem to not use desktopWidget doesn't solve the problem. KWindowSystem is a QWidget based framework. Thus

Re: Review Request 125885: Support socks5 proxy in KTcpSocket

2015-11-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125885/#review87847 --- Ship it! Ah I see, forget what I said about HTTP proxy. Abou

Re: Review Request 125915: Drop runtime dependency on QApplication

2015-11-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125915/#review87846 --- I consider this a very dangerous change. We don't have unit te