Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-22 Thread Boudhayan Gupta
> On Nov. 16, 2015, 10:46 p.m., Hrvoje Senjan wrote: > > >assuming, that is, distros push out the updates together > > > > don't assume this ;-) at least send a mail to kde-distro-packagers about > > the sideeffects if those 3 are pushed asynchronously > > Boudhayan Gupta wrote: > 'course,

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-22 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/#review88705 --- Deleting a texture twice is legal in OpenGL, since unused text

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/#review88703 --- are you sure it means that? I mean I did read the documentatio

Re: Review Request 126087: Move the i18n context from KDeclarative

2015-11-22 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/#review88697 --- Ship it! autotests/ki18ndeclarativetest.cpp (line 31)

Review Request 126140: [kfilemetadata] avoid utf16->utf8->utf16 conversions reading taglib metadata

2015-11-22 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126140/ --- Review request for KDE Frameworks and Vishesh Handa. Repository: kfilemet

Re: Review Request 126056: Use KDE_INSTALL_FULL_ICONDIR to install the icons

2015-11-22 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126056/ --- (Updated Nov. 22, 2015, 1:57 p.m.) Status -- This change has been ma

Re: Review Request 126130: [kholidays] Qt5Core should be required, not Qt5Test

2015-11-22 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126130/ --- (Updated Nov. 22, 2015, 1:52 p.m.) Status -- This change has been ma

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/#review88691 --- Ship it! Ship It! - Alex Merry On Nov. 22, 2015, 1:57 a.m.

Re: Review Request 126130: [kholidays] Qt5Core should be required, not Qt5Test

2015-11-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126130/#review88690 --- Ship it! Ship It! - Alex Merry On Nov. 22, 2015, 12:52 a.m

Re: Review Request 126056: Use KDE_INSTALL_FULL_ICONDIR to install the icons

2015-11-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126056/#review88689 --- Ship it! Ship It! - Alex Merry On Nov. 22, 2015, 11:43 a.m

Re: Review Request 126056: Use KDE_INSTALL_FULL_ICONDIR to install the icons

2015-11-22 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126056/ --- (Updated Nov. 22, 2015, 11:43 vorm.) Review request for KDE Frameworks an

Re: Review Request 126057: Use KDE_INSTALL_ICONDIR to install the icons

2015-11-22 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126057/ --- (Updated Nov. 22, 2015, 11:31 a.m.) Status -- This change has been m