Re: Purpose as a KDE Framework

On Fri, Dec 4, 2015 at 11:26 PM, Mark Gaiser wrote: > On Thu, Dec 3, 2015 at 7:29 PM, Aleix Pol wrote: >> >> On Wed, Dec 2, 2015 at 11:56 PM, Mark Gaiser wrote: >> > On Tue, Dec 1, 2015 at 3:01 PM, Aleix Pol wrote: >> >> >> >> Hi, >> >> I've been working on Purpose since some months now, with t

Re: Review Request 126241: [OS X] adapting KStyle (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126241/#review89137 --- > create a Qt *style* plugin that does nothing more than exten

Re: Purpose as a KDE Framework

On Thu, Dec 3, 2015 at 7:29 PM, Aleix Pol wrote: > On Wed, Dec 2, 2015 at 11:56 PM, Mark Gaiser wrote: > > On Tue, Dec 1, 2015 at 3:01 PM, Aleix Pol wrote: > >> > >> Hi, > >> I've been working on Purpose since some months now, with the intention > >> of becoming a framework some day. Some infor

Review Request 126246: Add test for dynamically changing file definitions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126246/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 4, 2015, 2:40 p.m., Martin Gräßlin wrote: > > No, those we shouldn't need anymore as the toplevel CMake file will reject Qt versions earlier than 5.3.0 . Should I clean up all occurrences from platformtheme, even where they have nothing to do with the Mac version? - René J.V. --

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 4, 2015, 7:01 p.m.) Review request for KDE Software on Mac

Review Request 126245: Cookie dialogue: make Accept/Reject buttons work, and other fixes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126245/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > src/platformtheme/kdeplatformtheme.h, lines 41-54 > > > > > > why did you add the virtual? The methods are marked as Q_DECL_OVERRIDE > > which implies they

Re: Review Request 126239: make autotests nongui executables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126239/ --- (Updated Dec. 4, 2015, 4:49 p.m.) Status -- This change has been mar

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 42 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/42/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 04 Dec 2015 16:26:28 + Build duration: 16 sec CHANGE SET Revision efb14cb69ad53bcdb4f3f7b4f2439183d27ebb

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126222/ --- (Updated Dec. 4, 2015, 4:26 p.m.) Status -- This change has been mar

Re: Review Request 126242: KCoreAddons: Add WheelArea

> On Dec. 4, 2015, 3:57 p.m., Aleix Pol Gonzalez wrote: > > Maybe it fits better in KQuickControls? KCoreAddons is mostly for actually > > interfacing with KCoreAddons the framework. > > > > Have you considered getting an iteration of this upstream in Qt? At first > > glance the feature doesn'

Re: Review Request 126242: KCoreAddons: Add WheelArea

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126242/#review89126 --- Maybe it fits better in KQuickControls? KCoreAddons is mostly

Review Request 126242: KCoreAddons: Add WheelArea

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126242/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review89124 --- src/platformtheme/kdemactheme.h (line 50)

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > src/platformtheme/main_mac.cpp, line 45 > > > > > > why does the mac platform want to setupXcbFlush? > > René J.V. Bertin wrote: > If it won't ever be s

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > src/platformtheme/CMakeLists.txt, lines 67-69 > > > > > > don't make thie an elsif, just an if. It's not an elseif condition > > René J.V. Bertin wrote: >

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

> On Дец. 4, 2015, 10:35 пре п., Chusslove Illich wrote: > > The KI18N_INSTALL macro is also used by KI18n itself, to install its own > > translations. And so do other higher-tier frameworks. So I'm not sure when > > this no-Gettext/no-Python build is supposed to be useful. When one wants to >

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/ --- (Updated Dec. 4, 2015, 2:05 p.m.) Review request for KDE Software on Mac

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme (and autotests)

> On Dec. 4, 2015, 8:26 a.m., Martin Gräßlin wrote: > > Please include Hugo for a review on the KStyle changes. > > > > I'd suggest to split the review into three parts: one about the adjusted > > test (ecm_foo) - that's a no brainer and doesn't need further discussion. > > One about the KStyl

Review Request 126241: [OS X] adapting KStyle (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126241/ --- Review request for KDE Software on Mac OS X, KDE Frameworks and Hugo Pereir

Re: Review Request 126239: make autotests nongui executables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126239/#review89119 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 4, 2015, 1:

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

> On Dec. 4, 2015, 9:35 a.m., Chusslove Illich wrote: > > The KI18N_INSTALL macro is also used by KI18n itself, to install its own > > translations. And so do other higher-tier frameworks. So I'm not sure when > > this no-Gettext/no-Python build is supposed to be useful. When one wants to > >

Review Request 126239: make autotests nongui executables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126239/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

> On Dec. 4, 2015, 10:35 a.m., Chusslove Illich wrote: > > The KI18N_INSTALL macro is also used by KI18n itself, to install its own > > translations. And so do other higher-tier frameworks. So I'm not sure when > > this no-Gettext/no-Python build is supposed to be useful. When one wants to > >

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

> On Дец. 4, 2015, 10:35 пре п., Chusslove Illich wrote: > > The KI18N_INSTALL macro is also used by KI18n itself, to install its own > > translations. And so do other higher-tier frameworks. So I'm not sure when > > this no-Gettext/no-Python build is supposed to be useful. When one wants to >

Re: KTabBar/QTabBar and documentMode

Jaroslaw Staniek wrote: > Hi, that's one of my hints from 2010 > https://blogs.kde.org/2010/09/29/elegance-4-tab-bar-uncluttered :) But that's for a different purpose, removing distracting visual clutter rather than ensuring that the tabs themselves remain useful. After looking into the issue a

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

> On Dec. 4, 2015, 9:35 a.m., Chusslove Illich wrote: > > The KI18N_INSTALL macro is also used by KI18n itself, to install its own > > translations. And so do other higher-tier frameworks. So I'm not sure when > > this no-Gettext/no-Python build is supposed to be useful. When one wants to > >

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

> On Дец. 4, 2015, 10:35 пре п., Chusslove Illich wrote: > > The KI18N_INSTALL macro is also used by KI18n itself, to install its own > > translations. And so do other higher-tier frameworks. So I'm not sure when > > this no-Gettext/no-Python build is supposed to be useful. When one wants to >

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

> On Дец. 4, 2015, 10:35 пре п., Chusslove Illich wrote: > > The KI18N_INSTALL macro is also used by KI18n itself, to install its own > > translations. And so do other higher-tier frameworks. So I'm not sure when > > this no-Gettext/no-Python build is supposed to be useful. When one wants to >

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126222/#review89112 --- Ship it! Ship It! - Lamarque Souza On Dec. 3, 2015, 10:19

Re: Review Request 126222: Fix rating widget flickering when selecting rating with mouse

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126222/#review89111 --- src/kratingwidget.cpp (line 181)

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

> On Dec. 4, 2015, 9:35 a.m., Chusslove Illich wrote: > > The KI18N_INSTALL macro is also used by KI18n itself, to install its own > > translations. And so do other higher-tier frameworks. So I'm not sure when > > this no-Gettext/no-Python build is supposed to be useful. When one wants to > >

Re: Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126230/#review89109 --- The KI18N_INSTALL macro is also used by KI18n itself, to insta