Jenkins-kde-ci: kemoticons master stable-kf5-qt5 » Linux,gcc - Build # 33 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kemoticons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 01:49:00 + Build duration: 1 min 26 sec CHANGE SET Revision 6e58d0592b8dc70384223ea2a598f

Jenkins-kde-ci: kemoticons master kf5-qt5 » Linux,gcc - Build # 32 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kemoticons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 01:48:59 + Build duration: 22 sec CHANGE SET Revision 6e58d0592b8dc70384223ea2a598f7cf776685be b

Re: Review Request 126531: Fix some Clazy warnings in kemoticons.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126531/ --- (Updated Dec. 28, 2015, 1:48 a.m.) Status -- This change has been ma

Re: Review Request 126531: Fix some Clazy warnings in kemoticons.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126531/#review90191 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 27, 2015, 9

Re: Review Request 126531: Fix some Clazy warnings in kemoticons.

On Dec. 27, 2015, 6:53 p.m., Andrey Cygankov wrote: > > Are you sure you used clazy properly? It usually detects those warnings > > correctly. Correct, after resolving the issues I'd recommend re-running clazy to make sure everything got fixed. - Aleix -

Re: Review Request 126539: Check sockaddr_un buffer size before strcpy()ing into it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126539/ --- (Updated Dec. 28, 2015, 1:34 a.m.) Status -- This change has been ma

Re: Review Request 126539: Check sockaddr_un buffer size before strcpy()ing into it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126539/#review90188 --- Ship it! Ship It! - David Edmundson On Dec. 28, 2015, 12:1

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 192 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/192/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 00:12:29 + Build duration: 12 min CHANGE SET Revision 45e4aea0e219ff1154c9e4fcc177f7c9fb9c7138 by mpy

Review Request 126539: Check sockaddr_un buffer size before strcpy()ing into it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126539/ --- Review request for KDE Frameworks and Plasma. Repository: kwallet-pam D

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 184 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/184/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 00:12:29 + Build duration: 4 min 56 sec CHANGE SET Revision 45e4aea0e219ff1154c9e4fcc177f7c9fb

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/ --- (Updated Dec. 28, 2015, 12:12 a.m.) Status -- This change has been m

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correc

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correct:

Re: Review Request 126531: Fix some Clazy warnings in kemoticons.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126531/ --- (Updated Дек. 27, 2015, 8:08 п.п.) Review request for KDE Frameworks and

Re: Review Request 126531: Fix some Clazy warnings in kemoticons.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126531/ --- (Updated Дек. 27, 2015, 8:05 п.п.) Review request for KDE Frameworks and

Re: Review Request 126472: Don't always load the timetracker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/ --- (Updated Dec. 27, 2015, 7:38 p.m.) Status -- This change has been ma

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

> On Dec. 27, 2015, 9:21 a.m., Heiko Tietze wrote: > > Perfect use of the message panel. However, the red close icon does not work > > (well) with colored backgrounds. > > Kai Uwe Broulik wrote: > Do we even need the close button to begin with? It's not like it > appearing is really under

Re: Review Request 126531: Fix some Clazy warnings in kemoticons.

> On Дек. 27, 2015, 5:53 п.п., Aleix Pol Gonzalez wrote: > > src/providers/pidgin/pidgin_emoticons.cpp, line 180 > > > > > > Use QLatin1String when comparing, same for the next one. How to understand: /kemoticon

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correc

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correct:

Re: Review Request 126516: Add StatusNotifier flag

> On Dez. 27, 2015, 6:18 nachm., David Edmundson wrote: > > Ship It! > > Kai Uwe Broulik wrote: > I'll put this on hold until we decided whether we want DrKonqi vs SNI > (what this review is about) or Desktop Notification vs SNI (my second > approach, in which case the flag should probably

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. The and is correct: - I never want to show the di

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90166 --- Ship it! drkonqi/main.cpp (line 159)

Re: Review Request 126516: Add StatusNotifier flag

> On Dez. 27, 2015, 6:18 nachm., David Edmundson wrote: > > Ship It! I'll put this on hold until we decided whether we want DrKonqi vs SNI (what this review is about) or Desktop Notification vs SNI (my second approach, in which case the flag should probably be named diferently (PassiveNotifica

Re: Review Request 126516: Add StatusNotifier flag

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126516/#review90164 --- Ship it! Ship It! - David Edmundson On Dec. 25, 2015, 4:24

Re: Review Request 126531: Fix some Clazy warnings in kemoticons.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126531/#review90163 --- src/providers/adium/adium_emoticons.cpp (line 51)

Re: Review Request 126531: Fix some Clazy warnings in kemoticons.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126531/ --- (Updated Dec. 27, 2015, 6:50 p.m.) Review request for KDE Frameworks and

Re: Review Request 126506: Fix improper destruction of non-virtual KDirModel subclasses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126506/#review90161 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 26, 2015, 6

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/ --- (Updated Dec. 27, 2015, 5:14 p.m.) Review request for KDE Frameworks, Alb

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

> On Dec. 27, 2015, 9:21 a.m., Heiko Tietze wrote: > > Perfect use of the message panel. However, the red close icon does not work > > (well) with colored backgrounds. > > Kai Uwe Broulik wrote: > Do we even need the close button to begin with? It's not like it > appearing is really under

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- (Updated Dez. 27, 2015, 4:11 nachm.) Review request for KDE Frameworks, P

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

> On Dez. 27, 2015, 9:21 vorm., Heiko Tietze wrote: > > Perfect use of the message panel. However, the red close icon does not work > > (well) with colored backgrounds. Do we even need the close button to begin with? It's not like it appearing is really under your direct control anyway. - Ka

Re: Review Request 126505: Do not show a warning color before the user even started typing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126505/ --- (Updated Dec. 27, 2015, 2:40 p.m.) Review request for KDE Frameworks, KDE

Re: Review Request 126505: Do not show a warning color before the user even started typing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126505/ --- (Updated Dec. 27, 2015, 2:36 p.m.) Review request for KDE Frameworks and

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 25, 2015, 4:37 nachm., Kai Uwe Broulik wrote: > > Usability: I envisioned this to be used for auto-restarting shell services > > and not to be used by applications. > > Another interesting thought could be enabling this by default for all > > applications but for regular applications

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review90139 --- Sorry for the delay; Christmas happened :-) Just two more sma

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dec. 25, 2015, 4:37 p.m., Kai Uwe Broulik wrote: > > Usability: I envisioned this to be used for auto-restarting shell services > > and not to be used by applications. > > Another interesting thought could be enabling this by default for all > > applications but for regular applications tr

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126523/#review90137 --- Ship it! Perfect use of the message panel. However, the red c