Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

> On Янв. 8, 2016, 1:20 д.п., Aleix Pol Gonzalez wrote: > > I did it myself because you're a GCI student, but besides compilation, you > > should have checked if tests still pass and specified so in the testing > > field. > > > > The change looks, good. Thanks! Please tell me how to run the a

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review90785 --- Looks good. +1 - Aleix Pol Gonzalez On Jan. 8, 2016, 2:34

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/ --- (Updated Янв. 8, 2016, 1:34 д.п.) Review request for KDE Frameworks, Plas

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126670/#review90784 --- Ship it! I did it myself because you're a GCI student, but be

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126670/ --- (Updated Jan. 8, 2016, 2:15 a.m.) Review request for KDE Frameworks and A

Re: Review Request 126665: [GCI] Fix clazy's issues in tests.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126665/#review90783 --- Ship it! Do you have push rights? - Aleix Pol Gonzalez On

Re: Review Request 126664: [GCI] Apply qstring-related clazy fixes to tests.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126664/#review90782 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 7, 2016, 7:

Re: Menu/Command capitalization

Hi, In data giovedì 7 gennaio 2016 22:42:18, Jaroslaw Staniek ha scritto: > Not too long ago MS Windows has moved from "Title Capitalization" to > "Sentence capitalization" for menus and commands: > https://msdn.microsoft.com/en-us/library/dn742392.aspx > > What can we do and should we do somethi

Menu/Command capitalization

Hello, Asking here as this is somewhat a cross platform issue. I do admit it isn't a massive one but rather strange; I've never noted it before, I just recently had to help with that for a customer's app. Not too long ago MS Windows has moved from "Title Capitalization" to "Sentence capitalization

Re: QProcess for GUI apps on OSX (Re: closest equivalent to KApplicationPrivate::init() ?)

Hi, I'm sure you're on Qt's "development" ML too, but here's a link to a relevant thread for the sake of completeness: http://thread.gmane.org/gmane.comp.lib.qt.devel/24290 Cheers, René ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.or

Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux,gcc - Build # 30 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdbusaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/30/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 07 Jan 2016 20:59:40 + Build duration: 1 min 34 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux,gcc - Build # 30 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdbusaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/30/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 07 Jan 2016 20:59:40 + Build duration: 1 min 34 sec CHANGE SET No changes JUNIT RESULTS Name: (r

Review Request 126664: [GCI] Apply qstring-related clazy fixes to tests.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126664/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kpa

Jenkins-kde-ci: kdbusaddons master stable-kf5-qt5 » Linux,gcc - Build # 30 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdbusaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/30/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 07 Jan 2016 17:46:15 + Build duration: 8.8 sec CHANGE SET No changes ___

Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux,gcc - Build # 29 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdbusaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/29/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 07 Jan 2016 17:29:21 + Build duration: 2.8 sec CHANGE SET Revision f79810135d409294e55b2381c02f2900059ceb2a

Re: Review Request 126661: [GCI] Apply qstring-related clazy fixes to the core lib.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126661/ --- (Updated Jan. 7, 2016, 8:40 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 126662: [GCI] Fix clazy's issues in core lib.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126662/ --- (Updated Jan. 7, 2016, 8:40 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > src/kpackage/packageloader.cpp, line 190 > > > > > > What does the category have to do with this? We should only be going by > > the id (the plugin name)

Re: Review Request 126662: [GCI] Fix clazy's issues in core lib.

> On Jan. 7, 2016, 4:51 p.m., Aleix Pol Gonzalez wrote: > > src/kpackagetool/kpackagetool.cpp, line 351 > > > > > > Why's this change? > > Mihail Ivchenko wrote: > Otherwese clazy warns about detaching tempo

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > src/kpackage/packageloader.cpp, line 190 > > > > > > What does the category have to do with this? We should only be going by > > the id (the plugin name)

Re: Review Request 126662: [GCI] Fix clazy's issues in core lib.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126662/#review90762 --- src/kpackage/packageloader.cpp (line 219)

Re: Review Request 126661: [GCI] Apply qstring-related clazy fixes to the core lib.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126661/#review90761 --- src/kpackage/package.cpp (line 227)

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > src/kpackage/packageloader.cpp, line 190 > > > > > > What does the category have to do with this? We should only be going by > > the id (the plugin name)

Review Request 126662: [GCI] Fix clazy's issues in core lib.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126662/ --- Review request for KDE Frameworks. Repository: kpackage Description ---

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote: > > Wouldn't it be way easier to simply check if the plugin is already in lst? > > > > Your approach looks very complex for just that... O(n) vs. O(n^2) - Andreas --- This is an aut

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

> On Jan. 7, 2016, 11:15 a.m., David Faure wrote: > > src/ioslaves/ftp/ftp.cpp, line 1775 > > > > > > The porting bug is here. In kdelibs4 tmptr was initialized to the > > current date, and used below. > >

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

> On Jan. 7, 2016, 12:15 nachm., David Faure wrote: > > src/ioslaves/ftp/ftp.cpp, line 1797 > > > > > > yes, this is a QDate behaviour change in Qt5. According to the documentation, QDate's behaviour was the sa

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126659/ --- (Updated Jan. 7, 2016, 1:21 nachm.) Review request for KDE Frameworks, kd

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126659/#review90743 --- src/ioslaves/ftp/ftp.cpp (line 1775)

Re: Review Request 126651: Fix wrong documentation for KIconTheme::iconPath

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126651/#review90736 --- Ship it! Yep, copy/paste error from one layer above, KIconLoa