Re: Review Request 126789: Don't propagate dataChanged upwards when we are not filtering.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126789/#review91306 --- I wrote extensive unit tests for this class. 1) does the unit

Re: Review Request 126745: Fix karchive autotests on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126745/#review91305 --- Ship it! Ship It! - David Faure On Jan. 18, 2016, 4:58

Re: Review Request 126725: prevent crash-on-exit in KSelectAction::~KSelectAction

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126725/#review91304 --- Ship it! Ship It! - David Faure On Jan. 14, 2016, 11:21

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

> On Jan. 14, 2016, 8:47 a.m., Kåre Särs wrote: > > tests/proxymodeltestapp/proxyitemselectionwidget.cpp, line 47 > > > > > > QStringLiteral with multiple string initializers does not work on > > Windows. All pla

Re: Review Request 126675: Add .kra and .ora qimagio plugins

> On Jan. 16, 2016, 1:46 p.m., Alex Merry wrote: > > I think the diff uploaded wrong, because reviewboard thinks all the new > > files are empty. > > > > Also, could you please add test cases to the autotests directory? It > > shouldn't be too complicated, just an example file or two and the P

Review Request 126806: DragDropEvent: Add ignore() function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126806/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Review Request 126804: DragArea: Implement grabbing delegate item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126804/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Re: Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

> On Jan. 15, 2016, 7:20 vorm., Martin Gräßlin wrote: > > > The KIconDialog itself works fine, but the "Browse..." sub dialog, which > > > is a grand child of the modal dialog, is opened in the background and > > > cannot be used > > > > this sounds like a Qt bug or a KFileDialog bug. The sub

Re: Review Request 125869: Allows protocoltojson & kio to handle translated json ExtraNames

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/#review91279 --- Fix it, then Ship it! src/protocoltojson/main.cpp (line 1

Re: Review Request 126745: Fix karchive autotests on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126745/ --- (Updated Jan. 18, 2016, 4:58 p.m.) Review request for KDE Frameworks and

Re: Review Request 126798: Add multiple installation method per categorie

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126798/#review91273 --- Please remove the commented qDebugs as well src/core/engine

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126624/ --- (Updated Jan. 18, 2016, 5:48 p.m.) Review request for KDE Software on Mac

Re: Reminder: Please add "Since" version info also to cmake macros and arguments

Am Donnerstag, 14. Januar 2016, 09:50:05 schrieb Friedrich W. H. Kossebau: > I am happy to fix at least KF5CoreAddonsMacros.cmake now that I came across > it, appending the Since behind the example, if that is the current syntax? > > # Example: > # kcoreaddons_add_plugin(kdeconnect_share JSON kd

Review Request 126798: Add multiple installation method per categorie

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126798/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstu

Re: kconfig question

On Monday, January 18, 2016 8:53:22 AM EST Boudewijn Rempt wrote: > On Sun, 17 Jan 2016, Matthew Dawson wrote: > > It appears this is the desired behaviour. On most platforms, > > GenericConfigLocation and ConfigLocation are the same things, except > > Windows. According to Qt's history, ConfigLoc

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

> On Jan. 11, 2016, 4:17 p.m., Yichao Yu wrote: > > qt5/style/qtcurve_api.cpp, line 3211 > > > > > > Should this be turned on only when KF5 is enabled? > > Aleix Pol Gonzalez wrote: > KGlobalSettings is dep

Re: Review Request 126624: respect "ShowIconsOnButtons" in the Qt5/KF5 style

> On 一月 11, 2016, 10:17 a.m., Yichao Yu wrote: > > qt5/style/qtcurve_api.cpp, line 3211 > > > > > > Should this be turned on only when KF5 is enabled? > > Aleix Pol Gonzalez wrote: > KGlobalSettings is depr

Re: QSP patch/activator

David, In your idea of a QSP::addStandardLocation() approach, would that always add to a "global" list (= affect all subsequent calls to standardLocations()), or would you also consider a variant that only affects the next call? Also, if you think we should avoid thinking of this as "providing

Re: opening dialogs using a "foreign" WId

‎Hi, > ‎Are there other platforms where WIds cannot be used for this kind of use > case (MS Windows for instance)?  Wayland.‎ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

opening dialogs using a "foreign" WId

Hi, Allow me to bring back up something that I've maybe never tried to discuss as an individual topic: dialogs that are created using a WId instance that is owned by a different application. Example: the warnings and password dialogs posted by kwalletd, which are supposed to open in a window (o

Review Request 126789: Don't propagate dataChanged upwards when we are not filtering.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126789/ --- Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmod

Re: Deadlock in kded whith Qt 5.6

On Friday 15 January 2016 13:48:14 Aleix Pol wrote: > On Fri, Jan 15, 2016 at 1:02 PM, Aleix Pol wrote: > > Hi, > > I realized earlier last week that some of my applications were > > freezing, it turns out it's because my kded is freezing and any dbus > > calls there need to time out (they take 30