Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread Martin Gräßlin
> On Jan. 29, 2016, 9:43 a.m., David Faure wrote: > > This looks good to me. It doesn't affect Linux, it doesn't affect API / > > binary compatibility, it uses #if so no risk of missing include, and it > > hides the globalaccel gui so it's not like users have the risk on clicking > > on

Re: Review Request 126893: [kioslave/remote] fix knetattach .desktop filename

2016-01-29 Thread Takahiro Hashimoto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126893/ --- (Updated Jan. 29, 2016, 11:29 a.m.) Review request for KDE Frameworks.

Re: Review Request 126908: Change licence header from "Library GPL 2 or later" to "Lesser GPL 2.1 or later"

2016-01-29 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126908/ --- (Updated Jan. 29, 2016, 12:49 p.m.) Status -- This change has been

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-29 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/#review91774 --- src/inhibition.h (line 136)

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread David Faure
> On Jan. 29, 2016, 8:43 a.m., David Faure wrote: > > This looks good to me. It doesn't affect Linux, it doesn't affect API / > > binary compatibility, it uses #if so no risk of missing include, and it > > hides the globalaccel gui so it's not like users have the risk on clicking > > on

Re: Review Request 126892: [kioslave/remote] check return of createWizardEntry

2016-01-29 Thread Takahiro Hashimoto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126892/ --- (Updated Jan. 29, 2016, 11:29 a.m.) Review request for KDE Frameworks.

Re: QProcess for GUI apps on OSX, or maybe a KProcess::launchGUIApplication() proof-of-concept?

2016-01-29 Thread René J . V . Bertin
On Tuesday January 05 2016 12:55:57 David Faure wrote: >No worries, we're both evolving our thoughts as the discussion progresses. Slowly but (I think) surely :) Feedback on the Qt ML thread is inclining me to design an initial proof of concept implementation extending KProcess, probably even

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread David Faure
> On Jan. 29, 2016, 8:43 a.m., David Faure wrote: > > This looks good to me. It doesn't affect Linux, it doesn't affect API / > > binary compatibility, it uses #if so no risk of missing include, and it > > hides the globalaccel gui so it's not like users have the risk on clicking > > on

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread Martin Gräßlin
> On Jan. 26, 2016, 7:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread Andre Heinecke
> On Jan. 26, 2016, 6:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread Martin Gräßlin
> On Jan. 29, 2016, 9:43 a.m., David Faure wrote: > > This looks good to me. It doesn't affect Linux, it doesn't affect API / > > binary compatibility, it uses #if so no risk of missing include, and it > > hides the globalaccel gui so it's not like users have the risk on clicking > > on

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

2016-01-29 Thread Marco Martin
> On Jan. 25, 2016, 8 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/tooltip.cpp, line 160 > > > > > > why bind it to compositingActive? > > Anthony Fieroni wrote: > To stop animated reposition

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126895/#review91751 --- Ship it! This looks good to me. It doesn't affect Linux,

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

2016-01-29 Thread Martin Gräßlin
> On Jan. 25, 2016, 9 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/tooltip.cpp, line 160 > > > > > > why bind it to compositingActive? > > Anthony Fieroni wrote: > To stop animated reposition

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread David Faure
> On Jan. 29, 2016, 8:43 a.m., David Faure wrote: > > This looks good to me. It doesn't affect Linux, it doesn't affect API / > > binary compatibility, it uses #if so no risk of missing include, and it > > hides the globalaccel gui so it's not like users have the risk on clicking > > on

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread Andre Heinecke
> On Jan. 26, 2016, 6:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread Martin Gräßlin
> On Jan. 26, 2016, 7:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread Martin Gräßlin
> On Jan. 29, 2016, 9:43 a.m., David Faure wrote: > > This looks good to me. It doesn't affect Linux, it doesn't affect API / > > binary compatibility, it uses #if so no risk of missing include, and it > > hides the globalaccel gui so it's not like users have the risk on clicking > > on

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread Andre Heinecke
> On Jan. 26, 2016, 6:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

2016-01-29 Thread Martin Gräßlin
> On Jan. 25, 2016, 9 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/tooltip.cpp, line 160 > > > > > > why bind it to compositingActive? > > Anthony Fieroni wrote: > To stop animated reposition

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

2016-01-29 Thread Anthony Fieroni
> On Ян. 25, 2016, 10 преди обяд, Martin Gräßlin wrote: > > src/declarativeimports/core/tooltip.cpp, line 160 > > > > > > why bind it to compositingActive? > > Anthony Fieroni wrote: > To stop animated

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread Martin Gräßlin
> On Jan. 26, 2016, 7:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread Boudewijn Rempt
> On Jan. 26, 2016, 6:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: opening dialogs using a "foreign" WId

2016-01-29 Thread Martin Graesslin
On Thursday, January 28, 2016 5:28:24 PM CET René J. V. Bertin wrote: > René J. V. Bertin wrote: > > Which is all I'm hinting at, and certainly not that a single (or small > > group of) person(s) implement this for all platforms. > > Of course, if cross-process WIds are basically only usable

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread Martin Gräßlin
> On Jan. 26, 2016, 7:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread Kåre Särs
> On Jan. 26, 2016, 6:40 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I'm a bit afraid of all these ifndef. Do you think it would make sense to > > abstract out the KGlobalAccel usage? > > > > Otherwise, would it be possible to make KGlobalAccel useful (or just dumb) > > on Windows? > >

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

2016-01-29 Thread Kåre Särs
> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote: > > According to the documentation AppLocalDataLocation is the following: > > "C:/Users//AppData/Local/", "C:/ProgramData/", > > "", "/data" > > > > In which directory are the desktop files? Unfortunately I can't check as my > > Windows

Re: Finding kdesu binary

2016-01-29 Thread Luigi Toscano
On Friday 29 of January 2016 16:13:55 Aleix Pol wrote: > On Fri, Jan 29, 2016 at 3:33 PM, Andrius Štikonas wrote: > > Hi, > > > > I would like to ask how do I find kdesu binary from the code (of > > partitionmanager). > > > > PartitionManager tries to restart itself with

Re: Finding kdesu binary

2016-01-29 Thread Andrius Štikonas
> On Fri, Jan 29, 2016 at 3:33 PM, Andrius Štikonas > wrote: > > Hi, > > > > I would like to ask how do I find kdesu binary from the code (of > > partitionmanager). > > > > PartitionManager tries to restart itself with root privileges and tries to > > rerun itself with kdesu, kdesudo or

Re: Finding kdesu binary

2016-01-29 Thread Aleix Pol
On Fri, Jan 29, 2016 at 3:33 PM, Andrius Štikonas wrote: > Hi, > > I would like to ask how do I find kdesu binary from the code (of > partitionmanager). > > PartitionManager tries to restart itself with root privileges and tries to > rerun itself with kdesu, kdesudo or

Finding kdesu binary

2016-01-29 Thread Andrius Štikonas
Hi, I would like to ask how do I find kdesu binary from the code (of partitionmanager). PartitionManager tries to restart itself with root privileges and tries to rerun itself with kdesu, kdesudo or gksu... However, KF5 based kdesu is now in libexec, something like /usr/lib64/libexec/kf5/kdesu

Review Request 126926: Clean up dependencies for KDeclarative/QuickAddons

2016-01-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126926/ --- Review request for KDE Frameworks. Repository: kdeclarative

Re: Finding kdesu binary

2016-01-29 Thread Aleix Pol
On Fri, Jan 29, 2016 at 5:03 PM, Andrius Štikonas wrote: >> On Fri, Jan 29, 2016 at 3:33 PM, Andrius Štikonas >> wrote: >> > Hi, >> > >> > I would like to ask how do I find kdesu binary from the code (of >> > partitionmanager). >> > >> > PartitionManager tries to restart

Re: Finding kdesu binary

2016-01-29 Thread Andrius Štikonas
2016 m. sausio 29 d., penktadienis 17:30:32 GMT Aleix Pol rašė: > On Fri, Jan 29, 2016 at 5:03 PM, Andrius Štikonas wrote: > >> On Fri, Jan 29, 2016 at 3:33 PM, Andrius Štikonas > >> wrote: > >> > Hi, > >> > > >> > I would like to ask how do I find kdesu binary from the

Re: Review Request 126895: Make KGlobalAccel dependency in KXmlGui optional

2016-01-29 Thread Jaroslaw Staniek
On 28 January 2016 at 11:47, Martin Graesslin wrote: > On Thursday, January 28, 2016 11:10:20 AM CET Jaroslaw Staniek wrote: > > Now instead of that, everything but truly uncommon stuff would be ON by > > default.​ If someone knows what she/he​ is doing, will set to OFF but >