Re: Review Request 127060: Potentially fix 347962

2016-02-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127060/ --- (Updated Feb. 13, 2016, 3:01 a.m.) Review request for KDE Frameworks. C

Review Request 127060: Potentially fix 347965

2016-02-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127060/ --- Review request for KDE Frameworks. Bugs: 347965 https://bugs.kde.org/

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Kåre Särs
> On Feb. 12, 2016, 3:55 p.m., Aleix Pol Gonzalez wrote: > > src/kcatalog.cpp, line 179 > > > > > > elseif? > > Andreas Cord-Landwehr wrote: > Sure? I must admit, my Windows compiler foo is not very elaborat

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Andreas Cord-Landwehr
> On Feb. 12, 2016, 3:55 nachm., Aleix Pol Gonzalez wrote: > > src/kcatalog.cpp, line 179 > > > > > > elseif? Sure? I must admit, my Windows compiler foo is not very elaborated. Actually, I thought _MSC_VER is a

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/#review92301 --- +1 src/kcatalog.cpp (line 175)

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/ --- (Updated Feb. 12, 2016, 3:47 nachm.) Review request for KDE Frameworks, A

Re: Review Request 127046: Move popup menu image actions into a submenu

2016-02-12 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127046/#review92299 --- I wouldn't say that all actions for images are rarely used. I

Re: Review Request 127031: Add function to get runtime frameworks version information

2016-02-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127031/#review92298 --- src/lib/kcoreaddons.h (line 33)

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Kåre Särs
> On Feb. 12, 2016, 12:02 a.m., Aleix Pol Gonzalez wrote: > > src/kcatalog.cpp, line 179 > > > > > > maybe it should be `#ifdef libintl-lite` no? > > Andreas Cord-Landwehr wrote: > Also regarding Kare's comm

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Andreas Cord-Landwehr
> On Feb. 12, 2016, 12:02 vorm., Aleix Pol Gonzalez wrote: > > src/kcatalog.cpp, line 179 > > > > > > maybe it should be `#ifdef libintl-lite` no? Also regarding Kare's comment, I will change this to add a CMake