Re: Review Request 127023: [KFileMetadata] Support Origin Email subject/sender/id

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127023/ --- (Updated Feb. 26, 2016, 8:56 p.m.) Status -- This change has been

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127187/#review92814 --- src/lib/activitiesmodel.h (line 96)

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

> On Feb. 25, 2016, 8:26 a.m., Martin Gräßlin wrote: > > I don't like the introduction of the SCRAPBOOK. The repository is not the > > place for dead and old code. That's what git already supports with keeping > > the whole history. > > > > We have some autotests for kwindowsystem. Could you

Re: Review Request 126813: Fix build with older polkit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126813/ --- (Updated Feb. 26, 2016, 3:59 p.m.) Status -- This change has been

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127166/#review92811 --- ping - Xuetian Weng On Feb. 24, 2016, 5:19 a.m., Xuetian

Re: Review Request 127191: KCompletionBox should *not* be a tooltip

> On Feb. 26, 2016, 2:14 p.m., Thomas Lübking wrote: > > src/kcompletionbox.cpp, line 66 > > > > > > q->setAttribute(Qt::WA_X11NetWmWindowTypeCombo); // broken?? ok, i'm blind :p - Marco

Re: Review Request 127191: KCompletionBox should *not* be a tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127191/ --- (Updated Feb. 26, 2016, 2:18 p.m.) Review request for KDE Frameworks and

Re: Review Request 127177: Compilation fixes for MSVC (2013)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127177/ --- (Updated Feb. 26, 2016, 2:14 p.m.) Status -- This change has been

Re: Review Request 127191: KCompletionBox should *not* be a tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127191/#review92809 --- src/kcompletionbox.cpp (line 66)

Re: Review Request 127179: Add external extractor plugin support

> On Feb. 25, 2016, 9:18 p.m., Pinak Ahuja wrote: > > src/externalextractor.cpp, line 104 > > > > > > You should use the asynchronous api instead of blocking the event loop > > by calling waitForFinished() > >

Re: Review Request 127191: KCompletionBox should *not* be a tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127191/#review92807 --- +1 - Martin Gräßlin On Feb. 26, 2016, 2:23 p.m., Marco

Review Request 127191: KCompletionBox should *not* be a tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127191/ --- Review request for KDE Frameworks and kwin. Repository: kcompletion

Re: Review Request 127179: Add external extractor plugin support

> On Feb. 26, 2016, 2:48 a.m., Pinak Ahuja wrote: > > src/externalextractor.cpp, line 104 > > > > > > You should use the asynchronous api instead of blocking the event loop > > by calling waitForFinished() > >

Re: Review Request 127177: Compilation fixes for MSVC (2013)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127177/#review92805 --- Fix it, then Ship it! src/kcatalog.cpp (line 46)

Re: QString -> QStringLiteral conversions might make applications crash on exit

On Friday, 26 February 2016 01:37:57 CET, Frank Reininghaus wrote: This becomes a problem if the read-only data that the QString refers to are not there any more, which can happen if the QString was stored in a global static object from one library, and the QStringLiteral is from another

Re: Review Request 127179: Add external extractor plugin support

> On Feb. 25, 2016, 9:18 p.m., Pinak Ahuja wrote: > > src/externalextractor.cpp, line 104 > > > > > > You should use the asynchronous api instead of blocking the event loop > > by calling waitForFinished() > >

Re: QString -> QStringLiteral conversions might make applications crash on exit

> a) Everyone who makes QString -> QStringLiteral replacements should be > extremely careful (which is very difficult, since it is not always > obvious if passing a QString to a function will result in the string > being stored in a global static object). Automated tools like clazy > should then

Re: polkit-qt-1 does not build

On Fri, Feb 26, 2016 at 11:13 PM, Martin Graesslin wrote: > On Friday, February 26, 2016 10:37:10 PM CET Ben Cooksley wrote: >> Hi all, >> >> I've been hammering away at some of the builds on our Jenkins Sandbox, >> and have found it isn't possible to get polkit-qt-1 to build.

Re: Review Request 126813: Fix build with older polkit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126813/#review92802 --- Ship it! Ship It! - Martin Gräßlin On Jan. 21, 2016,

polkit-qt-1 does not build

Hi all, I've been hammering away at some of the builds on our Jenkins Sandbox, and have found it isn't possible to get polkit-qt-1 to build. This blocks the entire KDE 4 chain, among other things. Could someone please investigate?

Review Request 127187: Fix build for MSVC (2013) on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127187/ --- Review request for KDE Frameworks, kdewin and Ivan Čukić. Repository:

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

> On Feb. 25, 2016, 8:26 a.m., Martin Gräßlin wrote: > > I don't like the introduction of the SCRAPBOOK. The repository is not the > > place for dead and old code. That's what git already supports with keeping > > the whole history. > > > > We have some autotests for kwindowsystem. Could you