Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-27 Thread Aleix Pol Gonzalez
> On Feb. 24, 2016, 8:06 p.m., Stephen Kelly wrote: > > Hi Aleix, > > > > I'm not familiar with the 'tiny mess'. Can you say what it is? I would > > expect the libs go in the same place, but maybe the plugins are affected by > > this? Can you be more specific? > > > > Thanks, > > Aleix Pol

Re: Review Request 127201: Fix svg icon path resolving in IconItem

2016-02-27 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/ --- (Updated Feb. 28, 2016, 1:18 a.m.) Review request for KDE Frameworks,

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 281 - Failure!

2016-02-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/281/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 27 Feb 2016 22:26:09 + Build duration: 2 min 18 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 281 - Failure!

2016-02-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/281/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 27 Feb 2016 22:26:09 + Build duration: 2 min 18 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 288 - Failure!

2016-02-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/288/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 27 Feb 2016 22:26:09 + Build duration: 1 min 28 sec CHANGE

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 288 - Failure!

2016-02-27 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/288/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 27 Feb 2016 22:26:09 + Build duration: 2 min 30 sec CHANGE SET

Review Request 127201: Fix svg icon path resolving in IconItem

2016-02-27 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository:

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

2016-02-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127136/#review92833 --- Fix it, then Ship it! src/kswitchlanguagedialog_p.cpp

Re: Review Request 127180: kdeinit: Prefer loading libraries from RUNPATH

2016-02-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127180/#review92832 --- Ship it! Makes sense. - David Faure On Feb. 25, 2016,

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-27 Thread David Faure
> On Feb. 27, 2016, 1:41 p.m., David Faure wrote: > > Nicolás: if the prefixes are different, then this patch doesn't change > > anything (since it compares the prefixes). So it makes sense to me. > > Adopt the Qt plugins dir when installing into the same prefix as Qt, keep > > default paths

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127169/#review92830 --- Nicolás: if the prefixes are different, then this patch

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-27 Thread Stephen Kelly
> On Feb. 24, 2016, 7:06 p.m., Stephen Kelly wrote: > > Hi Aleix, > > > > I'm not familiar with the 'tiny mess'. Can you say what it is? I would > > expect the libs go in the same place, but maybe the plugins are affected by > > this? Can you be more specific? > > > > Thanks, > > Aleix Pol

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

2016-02-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review92828 --- It seems weird to have a setting for FTP on one side, and a

Re: Review Request 123939: KAssistantDialog: Re-add the Help button that was present in KDELibs4 version

2016-02-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123939/#review92827 --- This commit added a Help button which does nothing. If

Re: Review Request 127197: [kcm_colors] Port away from KDELibs4Support

2016-02-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127197/#review92826 --- No idea about the leak, but the port looks ok (almost)

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

2016-02-27 Thread Thomas Friedrichsmeier
> On Feb. 26, 2016, 5:13 p.m., Dāvis Mosāns wrote: > > src/lib/activitiesmodel.h, line 96 > > > > > > Wouldn't it be better to use _MSC_VER <= 1800 /* MSVC2013 */ > > > > as maybe it works for MSVC2015?

Review Request 127197: [kcm_colors] Port away from KDELibs4Support

2016-02-27 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127197/ --- Review request for KDE Frameworks, Plasma, David Edmundson, David Faure,