Review Request 127613: Add a test application to render all icons installed on an X11 window

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127613/ --- Review request for KDE Frameworks and David Edmundson. Repository:

Re: Review Request 127587: [Kate view] Correct override cursor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127587/ --- (Updated Април 8, 2016, 7:36 преди обяд) Review request for Kate, KDE

Jenkins-kde-ci: kmediaplayer master stable-kf5-qt5 » Linux,gcc - Build # 17 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kmediaplayer%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 08 Apr 2016 00:24:23 + Build duration: 15 min CHANGE SET No changes

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 17 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 08 Apr 2016 00:11:20 + Build duration: 7.5 sec CHANGE SET No changes

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 16 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 07 Apr 2016 23:45:19 + Build duration: 25 min CHANGE SET Revision 549fdb643b171952b5101ae0c7b9f80f361f3845

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 20 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/20/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 07 Apr 2016 23:45:21 + Build duration: 23 min CHANGE SET Revision 549fdb643b171952b5101ae0c7b9f80f361f3845 by

Please add new versions on bugs.kde.org products on KF5 releases

Hi, please do not forget to also add versions to KF5 products on bugs.kde.org on new releases. Was there not a script provided by some good developers meanwhile to help with that? Right now it seems at least the 5.21.0 version misses with all KF5 products, though some also seem to miss the

Re: Review Request 127418: Set text on QCheckbox widget rather than using a separate label

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127418/ --- (Updated April 7, 2016, 11:44 p.m.) Status -- This change has been

Re: Review Request 127414: Don't enable acl permissions widget if we don't own the file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127414/ --- (Updated April 7, 2016, 11:44 p.m.) Status -- This change has been

Re: Review Request 127414: Don't enable acl permissions widget if we don't own the file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127414/#review94417 --- Ship it! Makes sense. - Aleix Pol Gonzalez On March

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/#review94405 --- Ship it! Ship It! - David Edmundson On April 7, 2016,

Re: Review Request 127606: [kunitconversion] If we don't know a conversion rate, inform the client instead of guessing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127606/ --- (Updated April 7, 2016, 10:27 p.m.) Review request for KDE Frameworks.

Re: Review Request 127603: [kunitconversion] Create relevant cache dir for libkunitconversion before trying to use it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127603/ --- (Updated April 7, 2016, 10:22 p.m.) Status -- This change has been

Re: Review Request 127605: [kunitconversion] Fix blocking network file downloading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127605/ --- (Updated April 7, 2016, 10:22 p.m.) Status -- This change has been

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/#review94404 --- Ship it! Ship It! - David Edmundson On April 7, 2016,

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/ --- (Updated April 7, 2016, 10 nachm.) Review request for KDE Frameworks and

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/ --- (Updated April 7, 2016, 9:53 nachm.) Review request for KDE Frameworks,

Re: Review Request 127605: [kunitconversion] Fix blocking network file downloading

> On April 7, 2016, 5:07 p.m., Kai Uwe Broulik wrote: > > https://git.reviewboard.kde.org/r/127251/ Ooops. I didn't see that. Sorry! It looks like we've both basically done the same thing. So if you merge yours (with David's comment fixed) I'll throw this and

Re: Review Request 127606: [kunitconversion] If we don't know a conversion rate, inform the client instead of guessing

> On April 7, 2016, 8:58 p.m., Kai Uwe Broulik wrote: > > src/currency.cpp, line 134 > > > > > > This exchange rate (and all the others from countries that switched to > > Euro) will never change. Oh! That's

Re: Review Request 127604: [kunitconversion] Simplify isConnected

> On April 7, 2016, 8:55 p.m., Kai Uwe Broulik wrote: > > src/currency.cpp, line 673 > > > > > > Are you sure about that? I was unsure enough that I had to checked :) qDebug() << "Batman check:" << <<

Re: Review Request 127606: [kunitconversion] If we don't know a conversion rate, inform the client instead of guessing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127606/#review94399 --- src/currency.cpp (line 134)

Re: Review Request 127604: [kunitconversion] Simplify isConnected

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127604/#review94398 --- src/currency.cpp (line 637)

Re: Misbehavior when unloading KStyle

On Mittwoch, 6. April 2016 20:10:53 CEST Aleix Pol wrote: > Hi, > I've seen a couple of times such backtrace [1] which shows Qt waiting > for something that never happens. An easy way to reproduce is to load > konversation (or any application with KDBusService::Unique), hide it > and run it again.

Re: Review Request 127605: [kunitconversion] Fix blocking network file downloading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127605/#review94391 --- https://git.reviewboard.kde.org/r/127251/ - Kai Uwe Broulik

Re: Review Request 127605: [kunitconversion] Fix blocking network file downloading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127605/#review94390 --- - Kai Uwe Broulik On April 7, 2016, 3:58 nachm., David

Re: Review Request 127605: [kunitconversion] Fix blocking network file downloading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127605/#review94388 --- src/currency.cpp (line 656)

Re: Review Request 127604: [kunitconversion] Simplify isConnected

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127604/#review94387 --- src/currency.cpp (line 664)

Re: Review Request 127603: [kunitconversion] Create relevant cache dir for libkunitconversion before trying to use it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127603/#review94386 --- +1 otherwise src/currency.cpp (line 50)

Review Request 127606: [kunitconversion] If we don't know a conversion rate, inform the client instead of guessing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127606/ --- Review request for KDE Frameworks. Repository: kunitconversion

Review Request 127604: [kunitconversion] Simplify isConnected

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127604/ --- Review request for KDE Frameworks. Repository: kunitconversion

Review Request 127605: [kunitconversion] Fix blocking network file downloading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127605/ --- Review request for KDE Frameworks. Repository: kunitconversion

Review Request 127603: [kunitconversion] Create relevant cache dir for libkunitconversion before trying to use it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127603/ --- Review request for KDE Frameworks. Repository: kunitconversion

Re: Review Request 124648: Handle clients having a different device pixel ratio

> On April 7, 2016, 9:45 a.m., Martin Gräßlin wrote: > > src/kwindowsystem.cpp, lines 495-496 > > > > > > This part looks wrong to me and I think is the reason why reading icons > > fails in kwin_wayland now. >

Re: Review Request 124648: Handle clients having a different device pixel ratio

> On April 7, 2016, 9:45 a.m., Martin Gräßlin wrote: > > src/kwindowsystem.cpp, lines 495-496 > > > > > > This part looks wrong to me and I think is the reason why reading icons > > fails in kwin_wayland now. >

Re: Review Request 127597: Fix generation of path to xcb plugin

> On April 7, 2016, 2:17 p.m., Heiko Becker wrote: > > Wouldn't \{$KDE_INSTALL_FULL_PLUGINDIR\}/kf5/org.kde.k... be better suited > > to solve the relative/absolute PLUGINDIR issue? > > Martin Gräßlin wrote: > that generates a proper absolute path. I don't know about the relative > path,

Re: Review Request 127597: Fix generation of path to xcb plugin

> On April 7, 2016, 2:17 p.m., Heiko Becker wrote: > > Wouldn't \{$KDE_INSTALL_FULL_PLUGINDIR\}/kf5/org.kde.k... be better suited > > to solve the relative/absolute PLUGINDIR issue? > > Martin Gräßlin wrote: > that generates a proper absolute path. I don't know about the relative > path,

Re: Review Request 127602: Add a test case for KWindowEffects::isEffectAvailable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127602/#review94373 --- Ship it! Ship It! - Sebastian Kügler On April 7, 2016,

Review Request 127602: Add a test case for KWindowEffects::isEffectAvailable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127602/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Re: Review Request 127597: Fix generation of path to xcb plugin

> On April 7, 2016, 2:17 p.m., Heiko Becker wrote: > > Wouldn't \{$KDE_INSTALL_FULL_PLUGINDIR\}/kf5/org.kde.k... be better suited > > to solve the relative/absolute PLUGINDIR issue? that generates a proper absolute path. I don't know about the relative path, though. - Martin

Re: Review Request 124648: Handle clients having a different device pixel ratio

> On April 7, 2016, 7:45 a.m., Martin Gräßlin wrote: > > src/kwindowsystem.cpp, line 588 > > > > > > This looks wrong to me! This method is supposed to return the actual > > work area as set on X11, not

Re: Review Request 127597: Fix generation of path to xcb plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127597/#review94371 --- Wouldn't \{$KDE_INSTALL_FULL_PLUGINDIR\}/kf5/org.kde.k... be

Re: Review Request 127597: Fix generation of path to xcb plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127597/#review94370 --- Ship it! Generating the path at compile time doesn't look

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/#review94365 --- src/unit.h (line 158)

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

> On April 7, 2016, 9:55 vorm., John Layt wrote: > > src/unit.h, line 158 > > > > > > This can be added to the end of the Currency group and still be BIC, > > that's why each group is hard-coded to start at a

Finding local translations?

I'm trying to make translations work for Krita. On starting the application, I want to check what the user's system language is and what the override language from the language selection dialog is. The problem is that the translations are located here: Windows The translations are in

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/#review94364 --- One correction to the enum. src/unit.h (line 158)

Re: Review Request 126520: [OS X] try to [k]launch the requested application in the foreground [showcase]

> On April 6, 2016, 7:26 p.m., Aleix Pol Gonzalez wrote: > > src/klauncher/klauncher.h, line 279 > > > > > > You shoudln't/can't have Q* classes outside of Qt. > > > > Also does this really need to be

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127253/#review94362 --- Ping - Kai Uwe Broulik On März 2, 2016, 1:17 vorm., Kai

Re: Review Request 127597: Fix generation of path to xcb plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127597/#review94358 --- This is still not 100% correct. The define should be bullet

Re: Review Request 127391: Require Qt 5.4 and remove version ifdefs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127391/ --- (Updated April 7, 2016, 9:56 a.m.) Status -- This change has been

Review Request 127597: Fix generation of path to xcb plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127597/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Re: Review Request 124648: Handle clients having a different device pixel ratio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124648/#review94357 --- Sorry that I didn't notice this review earlier. But the

Re: Misbehavior when unloading KStyle

On Wednesday, April 6, 2016 8:10:53 PM CEST Aleix Pol wrote: > Hi, > I've seen a couple of times such backtrace [1] which shows Qt waiting > for something that never happens. An easy way to reproduce is to load > konversation (or any application with KDBusService::Unique), hide it > and run it