Re: Review Request 127586: [calendar] Add a mark to days containing events

2016-04-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127586/ --- (Updated April 19, 2016, 5:23 a.m.) Review request for KDE Frameworks

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-18 Thread Albert Astals Cid
> On April 11, 2016, 10:44 p.m., Albert Astals Cid wrote: > > I'm unconvinced, actually the spec mentions order to be "Changed search > > order to png, svg, xpm" > > Albert Astals Cid wrote: > > https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html > > Aleix

Re: Review Request 127345: Make it possible for an applet to offer a test object

2016-04-18 Thread David Rosca
> On April 15, 2016, 6:45 p.m., LUIS GUSTAVO BARRETO wrote: > > src/plasma/corona.cpp, line 179 > > > > > > If you don't call importLayout() the startupCompleted signal never gets > > emitted causing a slow

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-04-18 Thread Kevin Funk
> On April 18, 2016, 11:05 a.m., Gleb Popov wrote: > > Let's do something about this. I see two solutions for this: > > > > - Add another macro. If we go this route, can we put it in the same .cmake > > file? > > - Add a keyword parameter to the existing macro. Because macro uses > >

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-04-18 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review94684 --- Let's do something about this. I see two solutions for this:

Re: Review Request 127666: kconfig and kurlrequester friendship: store local paths in string-typed item without file:// prefix

2016-04-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127666/#review94676 --- -2 The bug is in some layer above this. If you use ItemUrl