Re: Review Request 127923: Add support for custom emoticon sizes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127923/#review95521 --- Ship it! Ship It! - David Gil Oliva On Mayo 17, 2016, 3

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127911/#review95522 --- Ship it! Ship It! - Kevin Funk On May 17, 2016, 5:55 a.

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127911/ --- (Updated May 17, 2016, 11:28 a.m.) Status -- This change has been ma

Re: Review Request 127876: use the "selected" state for icons in selected menu items and selected buttons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127876/ --- (Updated May 17, 2016, 9:07 a.m.) Status -- This change has been mar

Broken ABI in networkmanager-qt

Hi, we decided to drop WiMAX support in nm-qt when it's compiled against NM 1.2.0, but this seems to break binary compatibility when nm-qt was previously build against older NM version. I didn't realize this before that this could happen and now I'm not sure how fix that. We could either: 1) R

Re: Review Request 127817: Don't make KIconThemes depend on Oxygen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127817/ --- (Updated May 17, 2016, 10:23 a.m.) Status -- This change has been ma

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 35 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/35/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 17 May 2016 10:24:14 + Build duration: 57 sec CHANGE SET Revision ad1ead84ee2c3a14363afdb048b3579f3d01fa18

Re: Broken ABI in networkmanager-qt

On Tue, May 17, 2016 at 11:06 AM, Jan Grulich wrote: > Hi, > > we decided to drop WiMAX support in nm-qt when it's compiled against NM 1.2.0, > but this seems to break binary compatibility when nm-qt was previously build > against older NM version. I didn't realize this before that this could happ

Re: LGPL for Breeze QStyle and qtquickcontrols?

On 9 May 2016 at 07:53, Martin Graesslin wrote: > On Saturday, May 7, 2016 10:10:50 PM CEST Jaroslaw Staniek wrote: > > Hi, > > Is relicensing Breeze QStyle to LGPL from GPL for possible and > acceptable? > > I've found cases when bits of the code beyond QStyle/KStyle API need > > to be reused. O

Re: Review Request 127817: Don't make KIconThemes depend on Oxygen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127817/#review95528 --- Sorry for coming late, I'm not subscribed to the list (and I'

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 46 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/46/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 17 May 2016 12:46:16 + Build duration: 2 min 42 sec CHANGE SET Rev

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 46 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/46/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 17 May 2016 12:46:16 + Build duration: 2 min 49 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 47 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/47/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 17 May 2016 12:46:16 + Build duration: 2 min 48 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 47 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/47/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 17 May 2016 12:46:16 + Build duration: 3 min 11 sec CHANGE SET Revision f

Re: LGPL for Breeze QStyle and qtquickcontrols?

On Tuesday, May 17, 2016 2:21:43 PM CEST Jaroslaw Staniek wrote: > On 9 May 2016 at 07:53, Martin Graesslin wrote: > > On Saturday, May 7, 2016 10:10:50 PM CEST Jaroslaw Staniek wrote: > > > Hi, > > > Is relicensing Breeze QStyle to LGPL from GPL for possible and > > > > acceptable? > > > > > I'

Re: Review Request 127817: Don't make KIconThemes depend on Oxygen

> On May 17, 2016, 2:29 p.m., Wolfgang Bauer wrote: > > Sorry for coming late, I'm not subscribed to the list (and I'm not a > > maintainer either), just noticed the commit. > > > > I have nothing against the patch per se, and it apparently won't cause the > > wrong fallback to breeze either a

Re: Review Request 127817: Don't make KIconThemes depend on Oxygen

> On Mai 17, 2016, 2:29 nachm., Wolfgang Bauer wrote: > > Sorry for coming late, I'm not subscribed to the list (and I'm not a > > maintainer either), just noticed the commit. > > > > I have nothing against the patch per se, and it apparently won't cause the > > wrong fallback to breeze either

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review95537 --- > I saw that one of the justifications for the move was a dep

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126198/#review95538 --- given that Plasma integration got removed I suggest to create

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127809/#review95540 --- sorry for the late review. Thanks for updating the change re

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On May 17, 2016, 4:36 p.m., Martin Gräßlin wrote: > > > I saw that one of the justifications for the move was a dependency on > > > Plasma library/ies, but I don't see any such dependencies in the latest > > > version before the move (commit 07548ac1fe7a7fb31a941473911e982fb623c07d). > > > >

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. I quite like the way things are, but yes, I've played with that idea. I guess I can simply fork `frameworkintegratio

Re: LGPL for Breeze QStyle and qtquickcontrols?

On 17 May 2016 at 15:02, Martin Graesslin wrote: > On Tuesday, May 17, 2016 2:21:43 PM CEST Jaroslaw Staniek wrote: > > On 9 May 2016 at 07:53, Martin Graesslin wrote: > > > On Saturday, May 7, 2016 10:10:50 PM CEST Jaroslaw Staniek wrote: > > > > Hi, > > > > Is relicensing Breeze QStyle to LGPL

Re: Review Request 127941: Kio fish: cannot process any file or diretory having a non-latin1 name

> On mai 16, 2016, 11:33 après-midi, David Faure wrote: > > I wish this awful E() macro was a function, it would be much more readable > > and safer (would return a QByteArray rather than a pointer to a temporary > > buffer...), but anyhow, the fix looks clearly correct. > > > > PS: don't clic

Re: LGPL for Breeze QStyle and qtquickcontrols?

On Sat, May 7, 2016 at 10:10 PM, Jaroslaw Staniek wrote: > Hi, > Is relicensing Breeze QStyle to LGPL from GPL for possible and acceptable? > I've found cases when bits of the code beyond QStyle/KStyle API need > to be reused. One example is: custom widgets. > If we're considering Breeze QStyle as

Re: LGPL for Breeze QStyle and qtquickcontrols?

On Tuesday, May 17, 2016 6:23:10 PM CEST Jaroslaw Staniek wrote: > > If you show me why it needs to be a framework and I agree with it, > > I might be willing to consider to allow to relicense the code I wrote for > > it. > > There's no request to make it framework from me. LGPLing Breeze does not

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On May 17, 2016, 4:36 p.m., Martin Gräßlin wrote: > > > I saw that one of the justifications for the move was a dependency on > > > Plasma library/ies, but I don't see any such dependencies in the latest > > > version before the move (commit 07548ac1fe7a7fb31a941473911e982fb623c07d). > > > >

Re: LGPL for Breeze QStyle and qtquickcontrols?

Hi, [snip] ​Architecturally, the eventual solution would be that breeze.git becomes layered, and routines beyond what QStyle defines are provided by an LGPL lib. It worked with libOxygen that is LGPL. The reason for liboxygen was that part of Oxygen was also used by KWin decoration. We fixed th

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

Re: Broken ABI in networkmanager-qt

On Tue, May 17, 2016 at 8:36 AM, Harald Sitter wrote: > On Tue, May 17, 2016 at 11:06 AM, Jan Grulich wrote: > > Hi, > > > > we decided to drop WiMAX support in nm-qt when it's compiled against NM > 1.2.0, > > but this seems to break binary compatibility when nm-qt was previously > build > > aga

Review Request 127948: Avoid skipping KAuthorized check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127948/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig

Re: Review Request 127948: Avoid skipping KAuthorized check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127948/#review95556 --- +1 Dolphin probably uses KRun which uses KDesktopFile::isAut

Re: Review Request 127948: Avoid skipping KAuthorized check

> On May 17, 2016, 8:12 p.m., Kai Uwe Broulik wrote: > > +1 > > > > Dolphin probably uses KRun which uses KDesktopFile::isAuthorizedDesktopFile > > which does not check for X-KDE-AuthorizeAction With the comment about Dolphin, I simply meant I had tested that I hadn't broken the normal case a

Re: Review Request 127948: Avoid skipping KAuthorized check

> On Mai 17, 2016, 8:12 nachm., Kai Uwe Broulik wrote: > > +1 > > > > Dolphin probably uses KRun which uses KDesktopFile::isAuthorizedDesktopFile > > which does not check for X-KDE-AuthorizeAction > > David Edmundson wrote: > With the comment about Dolphin, I simply meant I had tested that

Re: Review Request 127948: Avoid skipping KAuthorized check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127948/#review95559 --- +1 from me. Before pushing, can you please add a unit test f

Re: Review Request 127887: Improve usage of Qt APIs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127887/#review95561 --- src/core/installation.cpp (line 382)

Re: Review Request 127887: Improve usage of Qt APIs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127887/#review95562 --- Looks fine to me. I opened two issues but these are just ques

Re: Review Request 127817: Don't make KIconThemes depend on Oxygen

> On May 17, 2016, 12:29 p.m., Wolfgang Bauer wrote: > > Sorry for coming late, I'm not subscribed to the list (and I'm not a > > maintainer either), just noticed the commit. > > > > I have nothing against the patch per se, and it apparently won't cause the > > wrong fallback to breeze either

Re: KConfig compiler. GenerateProperties and Mutable.

Hi Aleix, Thank you for the reply. I was able to compile KStars for Android because the mentor of my project got rid of KIO. > Use KF5_HOST_TOOLING variable to point to your host tooling. It worked perfectly. Regards, Artem 2016-05-15 10:31 GMT+02:00 Aleix Pol : > On Fri, May 13, 2016 at 1:02

Re: Review Request 127923: Add support for custom emoticon sizes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127923/ --- (Updated May 17, 2016, 4:56 p.m.) Status -- This change has been mar

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On Май 17, 2016, 5:44 след обяд, Martin Gräßlin wrote: > > src/platforms/xcb/kwindowsystem.cpp, lines 730-732 > > > > > > this change looks not really needed. Looking at the code I think there > > is no change

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

> On May 17, 2016, 4:44 p.m., Martin Gräßlin wrote: > > src/platforms/xcb/kwindowsystem.cpp, lines 730-732 > > > > > > this change looks not really needed. Looking at the code I think there > > is no change at a