Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 29, 2016, 5:51 p.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 909 > > > > > > i18nc please > > René J.V. Bertin wrote: > I'm not sure what to expect here, what effect is using `i

The return of ASAN issues

Hi all, As you may recall, some time ago the CI scripts were adapted to forcibly inject ASAN into all test processes launched on the CI system to fix Marble's tests, as Marble does not use ECM and thus does not enable ASAN as a result. Unfortunately this has bad effects with certain processes, pa

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/#review96017 --- src/kstatusnotifieritem.cpp (line 903)

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

> On May 30, 2016, 10:43 a.m., Kai Uwe Broulik wrote: > > src/kstatusnotifieritem.cpp, line 910 > > > > > > That "bell" looks like some electrical circuit symbol, I'd rather > > prefer the exclamation mark then.

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated May 30, 2016, 12:39 p.m.) Review request for KDE Software on Mac

Re: The return of ASAN issues

Hi, Am Montag, 30. Mai 2016, 19:42:38 CEST schrieb Ben Cooksley: > As you may recall, some time ago the CI scripts were adapted to > forcibly inject ASAN into all test processes launched on the CI system > to fix Marble's tests, as Marble does not use ECM and thus does not > enable ASAN as a resul

Re: LGPL for Breeze QStyle and qtquickcontrols?

On 05/30/2016 12:33 AM, Aleix Pol wrote: On Mon, May 23, 2016 at 9:38 AM, Martin Graesslin wrote: On Sunday, May 22, 2016 12:22:28 AM CEST Jaroslaw Staniek wrote: So we, in KDE, lack LGPL style code for our de-facto official look and feel. This is the crucial point. Breeze is not the de-facto

Re: Review Request 127997: Extend KNS3::Entry public API

> On May 26, 2016, 6:14 p.m., Jeremy Whiting wrote: > > Sorry I missed the initial review request somehow. This looks good to me > > except for homepage. Homepage sounds to me like a web site url that gives > > more information about the KNS::Entry. Is that what you're using it for, or > > is

Re: Review Request 127997: Extend KNS3::Entry public API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127997/ --- (Updated May 30, 2016, 11:42 a.m.) Status -- This change has been ma

Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128055/ --- Review request for KDE Frameworks, Plasma and David Faure. Bugs: 356237

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128055/#review96036 --- keditfiletype/mimetypewriter.cpp (line 155)

Re: LGPL for Breeze QStyle and qtquickcontrols?

On Saturday, May 28, 2016 11:24:52 PM CEST Michael Pyne wrote: > On Sat, May 28, 2016 14:53:54 Jaroslaw Staniek wrote: > > All in all, If nobody just noted an issue with the licensing above maybe > > nobody tried to place/distribute a non-GPL software on top of Plasma? That > > would be the worst n

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

> On Mai 30, 2016, 2:35 nachm., David Faure wrote: > > keditfiletype/mimetypewriter.cpp, line 155 > > > > > > This could all be done with a single line, > > QDir().mkpath(packagesDirName); > > No need to

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128055/ --- (Updated Mai 30, 2016, 3:17 nachm.) Review request for KDE Frameworks, Pl

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128055/#review96041 --- Ship it! Ship It! - David Faure On May 30, 2016, 1:17 p

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128055/ --- (Updated May 30, 2016, 9:51 a.m.) Status -- This change has been mar

QGlobalStatic and windowing specific calls in dtor

Hi frameworks-dev, I have a problem with my KWayland based plugin for KIdleTime. KIdleTime uses a QGlobalStatic, so it gets destroyed at exit-time. At that point the QGuiApplication and the qpa plugin does not exist any more, so any windowing system specific calls will fail. In the case of the

Re: LGPL for Breeze QStyle and qtquickcontrols?

On Mon, May 30, 2016 14:42:43 Martin Graesslin wrote: > On Saturday, May 28, 2016 11:24:52 PM CEST Michael Pyne wrote: > > On Sat, May 28, 2016 14:53:54 Jaroslaw Staniek wrote: > > > All in all, If nobody just noted an issue with the licensing above maybe > > > nobody tried to place/distribute a no

Review Request 128057: Don't initialize KNS3::DownloadManager with the wrong categories

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128057/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstu

kwindowsystem crashes

There are a number of lines that division by zero could happen in frameworks/kwindowsystem/src/platforms/xcb/kwindowsystem.cpp if displayGeometry returns a 0 QRect. I think that is what is happening with bug 349512. viewportToDesktop, viewportWindowToDesktop, desktopToViewport I’m not clear

Jenkins-kde-ci: attica qt4 latest-qt4 » Linux,gcc - Build # 1 - Successful!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/attica%20qt4%20latest-qt4/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 May 2016 15:37:57 + Build duration: 32 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Jenkins-kde-ci: attica qt4 stable-qt4 » Linux,gcc - Build # 1 - Successful!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/attica%20qt4%20stable-qt4/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 May 2016 15:37:57 + Build duration: 26 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Re: QGlobalStatic and windowing specific calls in dtor

On Mon, May 30, 2016 at 4:25 PM, Martin Graesslin wrote: > Hi frameworks-dev, > > I have a problem with my KWayland based plugin for KIdleTime. KIdleTime uses a > QGlobalStatic, so it gets destroyed at exit-time. At that point the > QGuiApplication and the qpa plugin does not exist any more, so an

Re: Review Request 128043: Allow to play the default system sound (beep) instead of a specific sound file (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128043/#review96047 --- src/notifybyaudio.cpp (line 58)

Re: Review Request 126161: OS X housekeeping

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126161/ --- (Updated May 30, 2016, 8:28 p.m.) Review request for KDE Software on Mac

[kservice] new warnings from kbuildsycoca5, every time

Hi, I'm upgrading from my install from 5.20.0 to 5.22.0 and with that version I'm now getting a new list of warnings (errors?) each time kbuildsycoca5 is invoked: Not found: "image/x-pcx" Not found: "application/x-deb" Not found: "video/x-ms-asf" Not found: "application/x-palm-database" Saving D

Re: Review Request 128017: Add donate menu item to help menu of our apps

> On May 30, 2016, 5:54 a.m., Martin Gräßlin wrote: > > Kind of unrelated: do you have ideas how we can integrate the "Donate" into > > applications which don't have a help menu, like Plasma or KWin? I don't see "obvious" places for things without much chrome like Plasma and KWin other than th

Re: The return of ASAN issues

El dilluns, 30 de maig de 2016, a les 19:42:38 CEST, Ben Cooksley va escriure: > Hi all, > > As you may recall, some time ago the CI scripts were adapted to > forcibly inject ASAN into all test processes launched on the CI system > to fix Marble's tests, as Marble does not use ECM and thus does no

Re: [kservice] new warnings from kbuildsycoca5, every time

On Monday, May 30, 2016 10:42:04 PM CEST René J.V. Bertin wrote: > Hi, > > I'm upgrading from my install from 5.20.0 to 5.22.0 and with that version > I'm now getting a new list of warnings (errors?) each time kbuildsycoca5 is > invoked: > > Not found: "image/x-pcx" > Not found: "application/x-de

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 57 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/57/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 May 2016 21:47:37 + Build duration: 1 min 52 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 57 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/57/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 May 2016 21:47:37 + Build duration: 1 min 52 sec CHANGE SET No changes JUNIT RESULTS Name: (root

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 52 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 May 2016 21:46:15 + Build duration: 4 min 41 sec CHANGE SET No changes JUNIT RESULTS Nam

Re: [kservice] new warnings from kbuildsycoca5, every time

On Monday May 30 2016 23:50:08 David Faure wrote: > Did you find what is referring to these mimetypes? I've looked for some of them, and found the palm-database one too, but stopped the search when I realised I saw nothing wrong with what I found. I'll have a look at what you changed tomorrow an

Re: [kservice] new warnings from kbuildsycoca5, every time

On mardi 31 mai 2016 00:15:45 CEST René J.V. Bertin wrote: > That's another weird thing then. I keep adding qDebug() statements to code > I'm working on, wonder why I don't see them on the terminal, and then > either set "*.debug=true" in qtlogging.ini or replace qDebug() with > qWarning() (I have

Re: kwindowsystem crashes

On Monday, May 30, 2016 11:36:54 AM CEST Kurt Hindenburg wrote: > There are a number of lines that division by zero could happen in > frameworks/kwindowsystem/src/platforms/xcb/kwindowsystem.cpp if > displayGeometry returns a 0 QRect. I think that is what is happening with > bug 349512. urgh. Th

Re: The return of ASAN issues

On Mon, May 30, 2016 at 10:51 PM, Friedrich W. H. Kossebau wrote: > Hi, Hi Friedrich, > > Am Montag, 30. Mai 2016, 19:42:38 CEST schrieb Ben Cooksley: >> As you may recall, some time ago the CI scripts were adapted to >> forcibly inject ASAN into all test processes launched on the CI system >> t

Re: The return of ASAN issues

On Tue, May 31, 2016 at 9:36 AM, Albert Astals Cid wrote: > El dilluns, 30 de maig de 2016, a les 19:42:38 CEST, Ben Cooksley va escriure: >> Hi all, >> >> As you may recall, some time ago the CI scripts were adapted to >> forcibly inject ASAN into all test processes launched on the CI system >> t