Review Request 129315: Don't install plasmoid desktop files as services

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129315/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 129236: KAuth: make sure we can do more than one request

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129236/ --- (Updated Nov. 3, 2016, 1:27 a.m.) Status -- This change has been

[Differential] [Updated] D3226: Don't be fatal on File field not being properly parsed

apol marked an inline comment as done. apol added a comment. In https://phabricator.kde.org/D3226#60186, @aacid wrote: > If the file is broken maybe we should just fail in a more understandable way so people fix their software? The best way so people get to fix their software

Re: Review Request 129314: Setup targets for cross compiling.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129314/#review100526 --- KF5DocToolsMacros.cmake (line 150)

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129299/#review100525 --- +1, after some thinking and discussion. Would it make

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

> On Nov. 1, 2016, 2:35 a.m., Aleix Pol Gonzalez wrote: > > src/kxmlguiwindow.cpp, line 313 > > > > > > How come this is the _only_ exception? > > Albert Astals Cid wrote: > Because it's the only case where

Re: Review Request 129314: Setup targets for cross compiling.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129314/#review100517 --- works for me, but let's wait for Luigi's OK - Burkhard

Review Request 129314: Setup targets for cross compiling.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129314/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano.

Re: Review Request 129209: Rename subdir kcontrol to kcontrol5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129209/#review100513 --- +1 if Luigi is happy, I'm happy. - Aleix Pol Gonzalez On

Re: Review Request 129209: Rename subdir kcontrol to kcontrol5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129209/#review100512 --- kdeframeworks ping? - Burkhard Lück On Okt. 17, 2016,

[Differential] [Request, 128 lines] D3234: Separate sort roles and filters

apol created this revision. apol added reviewers: Frameworks, leinir, mart. REVISION SUMMARY They're semantically two different things. Readability Don't treat filters as specific cases Make it possible to query kns entries by their unique id BRANCH master REVISION DETAIL

Re: Review Request 129298: RFC: supporting dependencies on KPackage

> On Oct. 31, 2016, 6:19 p.m., Marco Martin wrote: > > autotests/data/testpackagesdep/metadata.json, line 14 > > > > > > if kns ends up using ids, maybe the server should be specified as well, > > as the id

[Differential] [Updated, 1 line] D3226: Don't be fatal on File field not being properly parsed

apol updated this revision to Diff 7826. apol added a comment. Dropped weird regex change CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3226?vs=7824=7826 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3226 AFFECTED FILES KF5ConfigMacros.cmake EMAIL PREFERENCES

[Differential] [Updated] D3226: Don't be fatal on File field not being properly parsed

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > kfunk wrote in KF5ConfigMacros.cmake:71 > I suggest to add some commentary here. Right, actually I was thinking of removing this part as the fallback fixes the issues we found. REVISION DETAIL

[Differential] [Changed Subscribers] D3226: Don't be fatal on File field not being properly parsed

kfunk added inline comments. INLINE COMMENTS > KF5ConfigMacros.cmake:71 > file(READ ${_tmp_FILE} _contents) > - string(REGEX MATCH "File=([^\n]+\\.kcfg)\n" "" "${_contents}") > + string(REGEX MATCH "File=([^\n]+\\.kcfg)c?\n" "" "${_contents}") > set(_kcfg_FILENAME

[Differential] [Request, 3 lines] D3226: Don't be fatal on File field not being properly parsed

apol created this revision. apol added a reviewer: Frameworks. REVISION SUMMARY Fallback on trying the same filename as the actual file. There were some regressions due to the former matching expression: string(REGEX REPLACE "^(.*\n)?File=([^\n]+kcfg).*\n.*$" "\\2" _kcfg_FILENAME

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 236 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/236/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 02 Nov 2016 11:00:07 + Build duration: 8 min 56 sec CHANGE

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 236 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/236/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 02 Nov 2016 11:00:07 + Build duration: 8 min 56 sec CHANGE

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 236 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/236/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 02 Nov 2016 11:00:07 + Build duration: 6 min 24 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 236 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/236/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 02 Nov 2016 11:00:07 + Build duration: 6 min 24 sec CHANGE SET Revision