Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 226 - Fixed!

2017-01-29 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/226/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 Jan 2017 02:58:46 + Build duration: 1 min 50 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 226 - Fixed!

2017-01-29 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/226/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 Jan 2017 02:58:46 + Build duration: 1 min 50 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 129849: KToolTipWidget: don't take ownership of the content widget

2017-01-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129849/#review102324 --- Shouldn't the tooltip be the parent of the widget anyway?

Re: Review Request 129833: KToolTipWidget: hide immediately if content gets destroyed

2017-01-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129833/#review102322 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 14,

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-01-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129663/#review102317 --- Actually, Alt+letter for actions in toolbars doesn't work

[Differential] [Closed] D4320: Don't fail when moving to the temp directory when installing

2017-01-29 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R304:95bb6fa8aabf: Don't fail when moving to the temp directory when installing (authored by apol). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4320?vs=10644=10679

[Differential] [Request, 14 lines] D4335: Fix endianness issues once and for all in Blowfish algorithm

2017-01-29 Thread A. Wilcox
awilcox created this revision. awilcox set the repository for this revision to R311 KWallet. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Attempting to package KWallet 5.29.0 for PowerPC, I ran in to a test failure

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 230 - Fixed!

2017-01-29 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/230/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 29 Jan 2017 18:07:21 + Build duration: 17 min CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 230 - Fixed!

2017-01-29 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/230/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 29 Jan 2017 18:07:21 + Build duration: 17 min CHANGE SET No changes JUNIT RESULTS

Re: Review Request 129885: [KStandadAction] Correct menubars logic

2017-01-29 Thread Anthony Fieroni
> On Ян. 29, 2017, 8:02 след обяд, Albert Astals Cid wrote: > > This patch makes no sense (somehow you wait for two shows to happen) and > > you even have tried it where it makes sense so -1 You can see the logic is only inverted to main, your comment makes no sense to me. - Anthony

Re: Review Request 129885: [KStandadAction] Correct menubars logic

2017-01-29 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129885/ --- (Updated Ян. 29, 2017, 8:25 след обяд) Status -- This change has

Re: Review Request 129885: [KStandadAction] Correct menubars logic

2017-01-29 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129885/#review102318 --- This patch makes no sense (somehow you wait for two shows

Re: Review Request 129892: Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars

2017-01-29 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129892/ --- (Updated Jan. 29, 2017, 6:01 p.m.) Status -- This change has been

Re: Review Request 129842: KAuth: update most of the examples, drop outdated ones

2017-01-29 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129842/ --- (Updated Jan. 29, 2017, 5:20 p.m.) Status -- This change has been

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-01-29 Thread Luigi Toscano
Il 29 gennaio 2017 16:31:24 CET, Olivier Churlaud ha scritto: >Le dimanche 29 janvier 2017, 16:24:46 CET Luigi Toscano a écrit : >> Il 29 gennaio 2017 16:16:51 CET, Olivier Churlaud > ha >scritto: >> >Le dimanche 29 janvier 2017, 08:32:21 CET Ben

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-01-29 Thread Olivier Churlaud
Le dimanche 29 janvier 2017, 16:24:46 CET Luigi Toscano a écrit : > Il 29 gennaio 2017 16:16:51 CET, Olivier Churlaud ha scritto: > >Le dimanche 29 janvier 2017, 08:32:21 CET Ben Cooksley a écrit : > >> We've just completed the registration of all mainline repositories > >>

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-01-29 Thread Luigi Toscano
Il 29 gennaio 2017 16:16:51 CET, Olivier Churlaud ha scritto: >Le dimanche 29 janvier 2017, 08:32:21 CET Ben Cooksley a écrit : >> We've just completed the registration of all mainline repositories >> (not including Websites or Sysadmin namespaced ones) on Phabricator. >>

Re: Phabricator: All repositories registered - upcoming workflow changes

2017-01-29 Thread Olivier Churlaud
Le dimanche 29 janvier 2017, 08:32:21 CET Ben Cooksley a écrit : > Hi everyone, Hi, > We've just completed the registration of all mainline repositories > (not including Websites or Sysadmin namespaced ones) on Phabricator. > Thanks go to Luigi Toscano for providing significant assistance with >

Re: Review Request 129663: Don't break accelerators in KToolBar

2017-01-29 Thread Martin Tobias Holmedahl Sandsmark
> On Dec. 17, 2016, 11:24 p.m., David Faure wrote: > > I agree that doing this in Show is far too late - and that > > KAcceleratorManager needs to be told, to avoid the infinite loop. > > > > However the reason for this code still holds I think, so it seems to me > > that it needs to be