davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
The current code checks if the existing action is valid rather the
argu
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:80c5aa01d207: Send desktopfilename as part of
notifyByPopup hints (authored by davidedmundson).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4416?vs=10866&
On Tuesday February 7 2017 01:15:23 Marko Käning wrote:
Hi,
>BTW, has this problem disappeared in the meantime?
Not really. The Qt error messages are no longer printed, but the underlying
cause is still there. QActions that are added to a Mac native menu are
reparented and cannot also be used
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/knotifications%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/59/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 09:17:01 +
Build duration: 3 min 50 sec
CHANGE SET
Revision 80c5aa01d2079c19dd7953d52
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R265 KConfigWidgets
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4471
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: d
subdiff created this revision.
subdiff added reviewers: Plasma, mart, hein.
subdiff added a subscriber: hein.
subdiff set the repository for this revision to R242 Plasma Framework (Library).
subdiff added a project: Plasma.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restric
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4473
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma, hein, mart
Cc: pl
subdiff added a comment.
Note: This patch changes the default. Since until now the frameVisible
property wasn't evaluated the frames were always shown.
But since QtQuickControls ScrollView (i.e. Plasma Extra Components ScrollArea
aswell) has set frameVisible to false by default, they are
hein added a comment.
IIUI this means scroll indicators are now disabled by default unless a UI
sets frameVisible: true? Marco, is this what you +1'd?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4473
EMAIL PREFERENCES
https://phabricator.kde
broulik added a comment.
-1
I don't get the overflow indicator mark anywhere anymore since frameVisible
is `false` by default for Plasma ScrollView.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4473
EMAIL PREFERENCES
https://phabricator.
mart added a comment.
what about changing the default to true but still have the binding?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4473
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma, m
subdiff added a comment.
You mean in Plasma's ScrollArea? Would be ok for me. It's a rather random
deviation from upstream's ScrollView though.
Is this ok for anyone else aswell?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4473
EMAIL PREF
davidedmundson added inline comments.
INLINE COMMENTS
> framesvg.cpp:136
>
> -FrameData *fd = d->frames[d->prefix];
> -
> -const QString oldKey = d->cacheId(fd, d->prefix);
> -const EnabledBorders oldBorders = fd->enabledBorders;
> -fd->enabledBorders = borders;
> -const QSt
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in framesvg.cpp:136
> I'm lost on why we have the pendingEnabledBorders
>
> you have some bugs if you do:
>
> setRepaintBlocked(false);
> setEnabledBorders(Left)
> enabledBorders() /// returns All not Left.
>
> it'll get update
subdiff updated this revision to Diff 11003.
subdiff added a comment.
Set ScrollArea's frameVisible default to true additional in order to not
change current implementations.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4473?vs=10997&i
guoyunhe closed this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4288
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: guoyunhe, #plasma, mart
Cc: plasma-devel, guoyunhe, #frameworks, lesliezhai, ali-m
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in framesvg.cpp:136
> it has pendingEnabledBorders because right now the borders are saved only n
> the frame, that we don't know if we can keep it or we'll have to throw it
> away ( or just dereference because some other frames
hein added a comment.
Is there some danger in this when using the component with a different theme
that has visible frames?
Should the scroll indicators be tied to frame visibility at all? That seems
dubious to me.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://
mart updated this revision to Diff 11006.
mart added a comment.
- just use enabledBorders to return as a property
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4414?vs=10861&id=11006
BRANCH
arcpatch-D4414
REVISION DETAIL
https://ph
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d8a1a9eb084b: don't regenerate frames when setting every
property (authored by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4414?vs=1100
subdiff added a comment.
The scroll indicators **are** the frame component in the Breeze style. So
they get replaced in any other style by the frame specified there. If you take
a look at ScrollViewStyle.qml, the indicators are inside the frame component
and the frame sides just change their
cfeck added a comment.
QApplication::desktopFileName() was only added in Qt 5.7, while frameworks
still support Qt 5.6. Please add a Qt version check around the new code.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D4416
EMAIL PREFERENCES
https://phabric
hein added a comment.
Aye. I think that's weird, but I'm guessing the Breeze style had no choice
there.
Does defaulting the frames to on mean the bottom flash is back too or is that
still fixed?
Can't comment on the ramifications of defaulting it to on + other themes ...
REPOSITORY
guoyunhe added a reviewer: Plasma.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4289
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: guoyunhe, #plasma:_design, #plasma
Cc: andreaska, guoyunhe, #frameworks
subdiff added a comment.
In https://phabricator.kde.org/D4473#83779, @hein wrote:
> Aye. I think that's weird
I agree.
> Does defaulting the frames to on mean the bottom flash is back too or is
that still fixed?
Still fixed.
> Can't comment on the ramifications of d
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:eb39b3514130: [ScrollViewStyle] Evaluate frameVisible
property (authored by subdiff).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4473?vs=1100
davidedmundson added a comment.
In https://phabricator.kde.org/D4416#83780, @cfeck wrote:
> QApplication::desktopFileName() was only added in Qt 5.7, while frameworks
still support Qt 5.6. Please add a Qt version check around the new code.
Done, thanks
REPOSITORY
R289 KNotifica
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/knotifications%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/60/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 13:21:00 +
Build duration: 5 min 45 sec
CHANGE SET
Revision d642e73614375380c37674b18
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/knotifications%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/60/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 13:21:00 +
Build duration: 5 min 45 sec
CHANGE SET
Revision d642e73614375380c37674b18
On Monday 06 February 2017, Albert Astals Cid wrote:
> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure:
> > Hi everyone,
> >
> > From this point forward, communities should be moving away from
> > Reviewboard to Phabricator for conducting code review. Sysadmin will
>
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/425/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 17:31:57 +
Build duration: 16 min
CHANGE SET
Revision 726abf9a6b177f80b627f46ff453c272a499d783
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/425/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 07 Feb 2017 17:31:57 +
Build duration: 16 min
CHANGE SET
Revision 726abf9a6b177f80b627f46ff453c272a499d783
On Tue, Feb 7, 2017 at 3:30 PM, Michael Pyne wrote:
> On Mon, Feb 06, 2017 at 11:35:15PM +0100, Albert Astals Cid wrote:
>> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va
>> escriure:
>> > Hi everyone,
>> >
>> > From this point forward, communities should be moving away from
On Wed, Feb 8, 2017 at 4:03 AM, Fredrik Höglund wrote:
> On Monday 06 February 2017, Albert Astals Cid wrote:
>> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va
>> escriure:
>> > Hi everyone,
>> >
>> > From this point forward, communities should be moving away from
>> > Revie
34 matches
Mail list logo