D5911: Make sure that SNI service name is unique and allowed by default in flatpak

jgrulich added a comment. In https://phabricator.kde.org/D5911#110687, @davidedmundson wrote: > I explained badly, let me try again with code. > https://paste.kde.org/pvzge2wq8 > > It will work in flatpak, and the SNI test we have in p-w still works fine. That indeed seems t

D5911: Make sure that SNI service name is unique and allowed by default in flatpak

jgrulich abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D5911 To: jgrulich, apol Cc: davidedmundson, #frameworks

D5914: Add template for Plasma QML Applet with QML extension

kossebau added a comment. Get created template bundle here: https://share.kde.org/index.php/s/eHJGEku7pw7DotV REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5914 To: kossebau, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, le

D5914: Add template for Plasma QML Applet with QML extension

kossebau created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Should help people to kick-off plasmoids which also use custom QML classes. TEST PLAN Created new plasmoid from tem

D5912: minimize dialog resizes/moves

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in dialog.cpp:864 > I don't understand your description of the problem. > > this call both that resizes and moves. > but if the item hasn't changed yet, it shouldn't actually resize anything. > > you're implying it does. Why? -

D5911: Make sure that SNI service name is unique and allowed by default in flatpak

davidedmundson added a comment. I explained badly, let me try again with code. https://paste.kde.org/pvzge2wq8 It will work in flatpak, and the SNI test we have in p-w still works fine. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D5911 To: jgrulich,

D5911: Make sure that SNI service name is unique and allowed by default in flatpak

jgrulich added a comment. In https://phabricator.kde.org/D5911#110683, @davidedmundson wrote: > This is a big solution for a problem that I don't think exists. There are actually two problems: 1. You need to guarantee that the SNI dbus service name will be unique, you cannot

D5911: Make sure that SNI service name is unique and allowed by default in flatpak

davidedmundson added a comment. This is a big solution for a problem that I don't think exists. There's no reason to register a new service, we pass the service name to the SNI watcher; it could be just the baseService (line 174 in the current code) If you do do that, use m_dbus.base

D5912: minimize dialog resizes/moves

davidedmundson added inline comments. INLINE COMMENTS > dialog.cpp:864 > if (d->mainItem) { > d->syncToMainItemSize(); > } I don't understand your description of the problem. this call both that resizes and moves. but if the item hasn't changed yet, it shouldn't a

D5912: minimize dialog resizes/moves

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY take into account size hints also when adjusting with synctomainitemsize which sometimes has to be executed right before a

D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau added a comment. If there are no further comments or other feedback, I would like to commit this once 5.35 is tagged. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 To: kossebau, #frameworks, #build_system, staniek Cc: shumski, kfunk, stan

D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau updated this revision to Diff 14672. kossebau added a comment. fix lett old "since 5.30" REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=14671&id=14672 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFF

D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau edited the summary of this revision. kossebau edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 To: kossebau, #frameworks, #build_system, staniek Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop

D2854: New: ECMAddQch, for generating qch & doxygen tag files

kossebau updated this revision to Diff 14671. kossebau added a comment. Restricted Application added projects: Frameworks, Build System. Some minor improvements, prepare for release with 5.36 REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?v

D3609: Create a QCH file with the API dox, optionally, using ECMAddQch

kossebau updated this revision to Diff 14670. kossebau added a comment. Restricted Application added a project: Frameworks. Update to latest ECMAddQch REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3609?vs=8818&id=14670 BRANCH addQCHBuild RE

D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH

kossebau updated this revision to Diff 14669. kossebau added a comment. Restricted Application added a project: Frameworks. Update to latest ECMAddQch REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3439?vs=8792&id=14669 BRANCH addQCHBuild REVISION D

D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH

kossebau updated this revision to Diff 14668. kossebau added a comment. Restricted Application added a project: Frameworks. Update to latest ECMAddQch REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3458?vs=8789&id=14668 BRANCH addQCHBuild REVISION DETA

D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH

kossebau updated this revision to Diff 14667. kossebau added a comment. Restricted Application added a project: Frameworks. Update to latest ECMAddQch REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3438?vs=8791&id=14667 BRANCH addQCHBuild REVISION D

D5911: Make sure that SNI service name is unique and allowed by default in flatpak

jgrulich added a reviewer: apol. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D5911 To: jgrulich, apol Cc: #frameworks

D5911: Make sure that SNI service name is unique and allowed by default in flatpak

jgrulich created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY In my previous change I made sure that the dbus service name for SNI is predictable so we can allow it in advance, but it introduced pro

D5890: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this symbol seems to have a special meaning.

This revision was automatically updated to reflect the committed changes. Closed by commit R313:07a8a4e6985c: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this… (authored by arrowdodger). REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5

D5890: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this symbol seems to have a special meaning.

arrowdodger added a comment. In https://phabricator.kde.org/D5890#110586, @bcooksley wrote: > This looks good to me. Would this also resolve https://build-sandbox.kde.org/view/Frameworks/job/Frameworks%20kcodecs%20kf5-qt5%20WindowsQt5.7/6/console ? > Invalid position value

D5890: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this symbol seems to have a special meaning.

bcooksley accepted this revision. bcooksley added a comment. This revision is now accepted and ready to land. This looks good to me. Would this also resolve https://build-sandbox.kde.org/view/Frameworks/job/Frameworks%20kcodecs%20kf5-qt5%20WindowsQt5.7/6/console ? REPOSITORY R313 KHtml BR

D5902: Expand KNewStuff documentation

leinir updated this revision to Diff 14660. leinir marked 2 inline comments as done. REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5902?vs=14634&id=14660 REVISION DETAIL https://phabricator.kde.org/D5902 AFFECTED FILES README.md src/core/engine.h s

D5902: Expand KNewStuff documentation

leinir marked 2 inline comments as done. leinir added inline comments. INLINE COMMENTS > apol wrote in README.md:30 > I'd say that it looks better to have `CONFIG` rather than `NO_MODULE`. Both > should work. > > Also `find_package(KF5 COMPONENTS NewStuffCore)` reads better to my eye. It certa

D5775: Don't include the pid in the dbus path when on flatpak

jgrulich added a comment. In https://phabricator.kde.org/D5775#110551, @apol wrote: > In https://phabricator.kde.org/D5775#110530, @jgrulich wrote: > > > In https://phabricator.kde.org/D5775#110529, @jgrulich wrote: > > > > > +1 > > > > > > good idea, it should solve all the pr

D5775: Don't include the pid in the dbus path when on flatpak

apol added a comment. In https://phabricator.kde.org/D5775#110530, @jgrulich wrote: > In https://phabricator.kde.org/D5775#110529, @jgrulich wrote: > > > +1 > > > > good idea, it should solve all the problems, we should use similar approach in KNotifications for SNI support. >

Re: KFileMetaData and API level requirement

Le 18 mai 2017 02:11, "Aleix Pol" a écrit : On Wed, May 17, 2017 at 9:57 PM, Matthieu Gallien wrote: > Hello, > > As a follow up of a discussion on android list, I would like to gather some > comments or point of views about the following dilemma. > Currently, the mandatory parts of KFileMetaDat

Re: Problem solved ([vlc] Qt4 plugin into Qt5 program)

On Wednesday May 17 2017 11:45:08 Rex Dieter wrote: >> Distro packaging should ensure that vlc-cache-gen is run every time the >> software gets installed or updated. This is also something that could be handled on our side, if KDE/Plasma is indeed the only environment where VlC's plugin cacheing

D5775: Don't include the pid in the dbus path when on flatpak

jgrulich added a comment. In https://phabricator.kde.org/D5775#110529, @jgrulich wrote: > +1 > > good idea, it should solve all the problems, we should use similar approach in KNotifications for SNI support. Actually this won't work for KNotifications and SNI, still problem wi

D5775: Don't include the pid in the dbus path when on flatpak

jgrulich added a comment. +1 good idea, it should solve all the problems, we should use similar approach in KNotifications for SNI support. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D5775 To: apol, #frameworks, jgrulich Cc: dfaure, davidedmundson, aaci