davidedmundson created this revision.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.
REVISION SUMMARY
Currently one has to connect every object manually to connectionDied,
which is something we can do
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
keyboard-leave-surface-destroy
REVISION DETAIL
https://phabricator.kde.org/D6683
To: graesslin, #frameworks, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot,
graesslin updated this revision to Diff 16755.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Add nullptr check to prevent crash
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
graesslin planned changes to this revision.
graesslin added a comment.
Causes crash in KWayaland when closing a window.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6683
To: graesslin, #frameworks, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
elvisangelaccio added a comment.
In https://phabricator.kde.org/D6709#125694, @thiago wrote:
> This class isn't hooked up to anything. It's technically correct as an FD
sender and receiver. What I want to see is how you use it, because that's
extremely important to get right.
I
thiago added a comment.
This class isn't hooked up to anything. It's technically correct as an FD
sender and receiver. What I want to see is how you use it, because that's
extremely important to get right.
I can confirm to you that anonymous namespace sockets do not work on BSDs
(which
chinmoyr added a subscriber: davidedmundson.
chinmoyr added a comment.
@davidedmundson will this revision solve the problem you mentioned
https://phabricator.kde.org/D6198. I will include the code for warning in the
job itself.
REPOSITORY
R241 KIO
REVISION DETAIL
chinmoyr updated this revision to Diff 16738.
chinmoyr marked 4 inline comments as done.
chinmoyr edited the test plan for this revision.
chinmoyr added a comment.
In my previous revision the logic for showing warning from ioslave was
flawed. In case of deleteRecursive everything would have
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130180/
---
(Updated July 15, 2017, 12:53 p.m.)
Status
--
This change has been
chinmoyr marked an inline comment as done.
chinmoyr added inline comments.
INLINE COMMENTS
> davidedmundson wrote in sharefd.cpp:107
> If this is on the client side, what stops any other (non authorised) client
> listening to here?
It doesn't matter. The job of client is to send the file
> On July 15, 2017, 9:31 a.m., Simone Gaiarin wrote:
> > Inviala!
>
> Luigi Toscano wrote:
> You can't "ship it" you own review. "Ship it" is marked by other
> reviewers who thinks that this should go in.
> Do you mean to say that you don't have a developer account and someone
> else
chinmoyr added a comment.
And
In https://phabricator.kde.org/D6709#125610, @davidedmundson wrote:
> > The sequence would be, registering service in ioslave, setting euid of
the helper process and sending the file descriptor over user's session bus
>
> I don't fully know this
> On July 15, 2017, 7:31 a.m., Simone Gaiarin wrote:
> > Inviala!
>
> Luigi Toscano wrote:
> You can't "ship it" you own review. "Ship it" is marked by other
> reviewers who thinks that this should go in.
> Do you mean to say that you don't have a developer account and someone
> else
davidedmundson added a comment.
> The sequence would be, registering service in ioslave, setting euid of the
helper process and sending the file descriptor over user's session bus
I don't fully know this code, but that doesn't sound right.
Your helper is running on the system bus,
Present: me, chinmoy
Minutes in the attachment.
Cheers,
Elvis2017-07-15 10:00:18 eangMeeting?
2017-07-15 10:00:39 chinmoy[m] i am here
2017-07-15 10:01:24 eanglet's start, as arnav said he wouldn't make it
2017-07-15 10:01:35 chinmoy[m] sure.
2017-07-15
chinmoyr created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Some methods in file ioslave, `FileProtocol::copy` and FileProtocol::put to
be precise, use file descriptor of source and destination files. So performing
any these operations as root user
> On Lug. 15, 2017, 7:31 a.m., Simone Gaiarin wrote:
> > Inviala!
>
> Luigi Toscano wrote:
> You can't "ship it" you own review. "Ship it" is marked by other
> reviewers who thinks that this should go in.
> Do you mean to say that you don't have a developer account and someone
> else
> On Lug. 15, 2017, 9:31 a.m., Simone Gaiarin wrote:
> > Inviala!
You can't "ship it" you own review. "Ship it" is marked by other reviewers who
thinks that this should go in.
Do you mean to say that you don't have a developer account and someone else
should push this?
- Luigi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130180/#review103453
---
Ship it!
Inviala!
- Simone Gaiarin
On Lug. 12, 2017,
> On Lug. 14, 2017, 8:24 p.m., David Faure wrote:
> > Enlarging the dialog when showing a child widget can sometimes be done by
> > activating the toplevel layout, but with a listview above I'm not sure it
> > would work.
> > Anyway, I like how it behaves with your patch, I find it quite nice
20 matches
Mail list logo
