D6754: [server] Send pointer leave if focused surface gets unbound

2017-07-18 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R127:a00a5d5e1c97: [server] Send pointer leave if focused surface gets unbound (authored by graesslin). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D6776: Don't perform wayland specific fixes when on X

2017-07-18 Thread Martin Flöser
graesslin added a comment. Your commit message has a typo where X is written but Wayland is meant. INLINE COMMENTS > dialog.cpp:1160 > > -if (ee->region().isNull()) { > +if (ee->region().isNull() || KWindowSystem::isPlatformX11()) { > return

D6776: Don't perform wayland specific fixes when on X

2017-07-18 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY https://phabricator.kde.org/R242:fd2e850156ac7aa9c9dc2cf46652b2a1f1fc3a07 introduces some behaviour changes

D6687: Adding support to ipv*.route-metric

2017-07-18 Thread Lamarque Souza
lvsouza accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D6687 To: pvillani, jgrulich, lvsouza Cc: #frameworks

D6493: Add KF5WindowSystem to link interface

2017-07-18 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6493 To: asturmlechner, #plasma, davidedmundson Cc: plasma-devel, davidedmundson, #frameworks,

D6775: Fix labels of DeleteFile/RenameFile actions

2017-07-18 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY For consistency with https://phabricator.kde.org/D6774. TEST PLAN None as I can't figure out whether these strings are actually displayed somewhere. REPOSITORY R237 KConfig BRANCH

D6774: Fix labels of DeleteFile/RenameFile actions

2017-07-18 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY These actions can be applied also to folders, so their user-visible labels should not explicitly mention "File". BUG: 382450 REPOSITORY R265 KConfigWidgets BRANCH master

D6773: Add API dox for KDEInstallDirs' KDE_INSTALL_USE_QT_SYS_PATHS

2017-07-18 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH adddoxforqtsyspaths REVISION DETAIL https://phabricator.kde.org/D6773 To: kossebau, #frameworks, apol Cc: #build_system

D6773: Add API dox for KDEInstallDirs' KDE_INSTALL_USE_QT_SYS_PATHS

2017-07-18 Thread Friedrich W . H . Kossebau
kossebau added a comment. Given the slightly complicated history of what KDE_INSTALL_USE_QT_SYS_PATHS does, I omitted a "since" on purpose for now. Would you agree it makes sense to simplify things be just adding "Since 5.22" and ignore previous behaviour? See also

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

2017-07-18 Thread Friedrich W . H . Kossebau
kossebau added a comment. See also https://phabricator.kde.org/D6773 for making the resulting behaviour documented. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6772 To: kossebau, #frameworks, ltoscano, rdieter Cc: #build_system

D6773: Add API dox for KDEInstallDirs' KDE_INSTALL_USE_QT_SYS_PATHS

2017-07-18 Thread Friedrich W . H . Kossebau
kossebau created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REPOSITORY R240 Extra CMake Modules BRANCH adddoxforqtsyspaths REVISION DETAIL https://phabricator.kde.org/D6773 AFFECTED FILES

D6772: Fix usage of query_qmake: differ between calls expecting qmake or not

2017-07-18 Thread Friedrich W . H . Kossebau
kossebau created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REVISION SUMMARY when KDE_INSTALL_USE_QT_SYS_PATHS has been explicitely set, qmake can be considered a required dependency, otherwise the

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-18 Thread Allen Winter
winterz closed this revision. winterz added a comment. see https://phabricator.kde.org/R240:db46fb7c2fdcfbff5f8a0445e4d055cf4388ead8 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6762 To: winterz, skelly, #build_system, #windows, kfunk Cc: nalvarez,

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-18 Thread Allen Winter
winterz added a comment. In https://phabricator.kde.org/D6762#126463, @nalvarez wrote: > Looks reasonable – although I wonder why on earth you're building KDE stuff on Cygwin... fun. as an experiment. i'm curious. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D6767: do not keep constructing new selectionmodels

2017-07-18 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. QAIV creates a new selectionModel whenever we call setModel. (qabstractitemview.cpp:762) So you're right this is at best, a bit pointlesss, but the fix isn't

D6624: do not crash qaccessible by causing a resize in a resize event

2017-07-18 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R236:ca40063c4e49: do not crash qaccessible by causing a resize in a resize event (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6624?vs=16502=16860#toc REPOSITORY R236

D6624: do not crash qaccessible by causing a resize in a resize event

2017-07-18 Thread Christoph Feck
cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. Would be nice if you also commit the conditional in the KCharSelectItemModel ::setColumnCount. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL

D6624: do not crash qaccessible by causing a resize in a resize event

2017-07-18 Thread Harald Sitter
sitter added a comment. In https://phabricator.kde.org/D6624#126506, @cfeck wrote: > Let's say someone fixes the referenced Qt bug, and we are at a point requiring that Qt version anyway. Are you going to remove the workaround? Anyone who happens to stumble upon it can.

D6624: do not crash qaccessible by causing a resize in a resize event

2017-07-18 Thread Christoph Feck
cfeck added a comment. Let's say someone fixes the referenced Qt bug, and we are at a point requiring that Qt version anyway. Are you going to remove the workaround? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D6624 To: sitter, gladhorn Cc: cfeck,

D6624: do not crash qaccessible by causing a resize in a resize event

2017-07-18 Thread Harald Sitter
sitter added a comment. In https://phabricator.kde.org/D6624#126503, @cfeck wrote: > If you are sure that your fix is "correct", then please remove the comment. From reading it, it looks like a workaround for a Qt bug. It is a workaround. It crashes because the life time of the

D6624: do not crash qaccessible by causing a resize in a resize event

2017-07-18 Thread Christoph Feck
cfeck added a comment. Reading your comment it is also wrong. Resizing the model does not cause a resize of the widget. The widget size is controlled by the layout manager. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D6624 To: sitter, gladhorn Cc: cfeck,

D6672: add KAboutLicense::spdx and introduce orLater qualification

2017-07-18 Thread Harald Sitter
sitter updated this revision to Diff 16858. sitter added a comment. - do not use ctor delegation, can't use that in kf5 yet - eliminate the "partial" private ctor, instead call the full private ctor from the partial public ctors. this results in defaults being implemented in the public

D6624: do not crash qaccessible by causing a resize in a resize event

2017-07-18 Thread Christoph Feck
cfeck added a comment. If you are sure that your fix is "correct", then please remove the comment. From readiong it, it looks like a workaround for a Qt bug. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D6624 To: sitter, gladhorn Cc: cfeck, anthonyfieroni,

D6624: do not crash qaccessible by causing a resize in a resize event

2017-07-18 Thread Harald Sitter
sitter added a comment. In https://phabricator.kde.org/D6624#126465, @cfeck wrote: > > It probably does. > > Were you able to test? I would prefer the simpler patch. I cannot test it, because my system does not have accessibility enabled. Yes, I did not manage to crash it

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-18 Thread Kevin Funk
kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6762 To: winterz, skelly, #build_system, #windows, kfunk Cc: nalvarez, #frameworks, #build_system