BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/39/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 28 Jul 2017 02:37:59 +
Build duration:
19 min and counting
JUnit Tests
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6946
To: davidedmundson, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg,
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
davidedmundson/xdgv6
REVISION DETAIL
https://phabricator.kde.org/D6727
To: davidedmundson, graesslin
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, progwolff,
kossebau added a comment.
In https://phabricator.kde.org/D6772#129531, @apol wrote:
> Works for me.
> Are you sure we don't need to include the `TRY` on other calls?
Any calls you would be thinking off? The ones where this patch does not add
`TRY` are in code which expects
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f9eb528acffc: KUrlNavigator: expose the
KUrlNavigatorButton that received a drop event (authored by elvisangelaccio).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Works for me.
Are you sure we don't need to include the `TRY` on other calls?
REPOSITORY
R240 Extra CMake Modules
BRANCH
handlenoqmakefound
REVISION DETAIL
kossebau marked an inline comment as done.
kossebau added a comment.
If there are no objections, will push on Saturday, 29th July
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6772
To: kossebau, #frameworks, ltoscano, rdieter, apol
Cc: #build_system
Hi,
On středa 19. července 2017 10:03:55 CEST Federico Buti wrote:
> Hi list.
>
> I've been tasked from my boss to write a little wrapper for
> NetworkManagerQt to provide specific operations suited from the devices of
> my company.
>
> Currently the devices have wifi, umts modem and ethernet
> On Nov. 20, 2016, 9:52 p.m., David Faure wrote:
> > I forgot to review this, sorry for the delay.
Sorry my own delay. Thanks for the detailled review. Everything should be fixed
now.
- Gregor
---
This is an automatically generated
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127111/
---
(Updated July 27, 2017, 11:15 a.m.)
Review request for KDE Frameworks,
carewolf updated this revision to Diff 17281.
carewolf edited the summary of this revision.
carewolf added a comment.
Fixed ruby tests
REPOSITORY
R252 Framework Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6914?vs=17224=17281
REVISION DETAIL
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R306 KParts
BRANCH
reset-url-in-closeUrl
REVISION DETAIL
https://phabricator.kde.org/D6856
To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop
Cc: cullmann, #frameworks
elvisangelaccio marked an inline comment as done.
REPOSITORY
R306 KParts
REVISION DETAIL
https://phabricator.kde.org/D6856
To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop
Cc: cullmann, #frameworks
elvisangelaccio edited the summary of this revision.
elvisangelaccio edited the test plan for this revision.
REPOSITORY
R306 KParts
REVISION DETAIL
https://phabricator.kde.org/D6856
To: elvisangelaccio, dfaure, #ktexteditor, #kate, #kdevelop
Cc: cullmann, #frameworks
elvisangelaccio updated this revision to Diff 17278.
elvisangelaccio added a comment.
- Drop TODO
REPOSITORY
R306 KParts
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6856?vs=17247=17278
BRANCH
reset-url-in-closeUrl
REVISION DETAIL
https://phabricator.kde.org/D6856
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:886dd7aaa33d: fix plasmashell unsetting QSG_RENDER_LOOP
(authored by mkoller).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6941?vs=17258=17276
REVISION
davidedmundson updated this revision to Diff 17272.
davidedmundson added a comment.
Updated docs + unit test
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6727?vs=16758=17272
BRANCH
davidedmundson/xdgv6
REVISION DETAIL
davidedmundson created this revision.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6946
AFFECTED FILES
dfaure added inline comments.
INLINE COMMENTS
> slavebase.cpp:1464
> +QByteArray buffer;
> +buffer.setNum(0);
> +send(MSG_PRIVILEGE_EXEC);
Better in one line: const QByteArray buffer = "0";
> file.h:115
> +};
> +virtual bool execWithElevatedPrivilege(int error, ActionType
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Looks good, apart from a few minor things.
INLINE COMMENTS
> job.cpp:276
> +// Whether or not sub-jobs have PrivilegeExecution flag set
> doesn't matter.
> +
dfaure added a comment.
Ah, well, if the flag is completely unused in subjobs then yes sure, just
remove the code that adds it.
REVISION DETAIL
https://phabricator.kde.org/D6833
To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> chinmoyr wrote in copyjob.cpp:1674
> Ideally it should be set when m_privilegeExecutionEnabled is true. But it
> will add more lines. Even though its just
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6685
To: elvisangelaccio, #frameworks, dfaure
23 matches
Mail list logo
