D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes

mpyne created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Inspired by https://phabricator.kde.org/D7279, manually declare nested Private classes to have hidden visibility (by default, they inherit the visibility of the class that they are nested under).

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

davidedmundson added a comment. > So from KWayland Server side we have a selection from KWayland server side we have a Seat:selection, we don't check if that has a DDI::selection If a client had called wl_set_selection(dataDevice, nulltptr) the server would still have a

D7170: Fix errorneous whitespace handling in Desktop Entry parsing from DesktopFileParser

This revision was automatically updated to reflect the committed changes. Closed by commit R244:077ef6797eb6: desktopfileparser: Fix non-compliant key/value parsing. (authored by mpyne). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7170?vs=17913=18069

D1231: Add Remote Access interface to KWayland

davidedmundson added a comment. All good to me. But double check with Martin. @graesslin this is a good week for merging bit stuff as the last frameworks was just released. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin,

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. Gentle reminder REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D6233: KKeyServer: fix handling of KeypadModifier.

bcooksley added a comment. @dfaure according to our Docker image the SUSE package you need is xorg-x11-server-wayland REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D6233 To: dfaure, graesslin Cc: bcooksley, graesslin, #frameworks

D7237: KIO/Mac : make kiod5 an "agent"

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7237 To: rjvbb, #frameworks, dfaure Cc: kde-mac, dfaure, #frameworks

D6233: KKeyServer: fix handling of KeypadModifier.

dfaure added a comment. I'm trying to run that unittest, but it aborts without Xwayland, and even after upgrading to OpenSuSE Leap 42.3, I still don't find a package containing Xwayland. It seems to be part of recent Xorg? I have xorg-x11-server-7.6_1.18.3-22.1.x86_64 REPOSITORY R278

D7280: Add syntax highlighting for Metamath

aaronpuchert added a comment. There are screenshots of other (known) syntax highlighters for Metamath on their homepage . REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7280 To: aaronpuchert, #frameworks

D7280: Add syntax highlighting for Metamath

aaronpuchert created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Metamath is a formal language to express mathematical theorems and proofs developed by Norman Megill. [1, 2] The language is defined in the documentation [3, Chapter 4]. The syntax

D7279: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Urgh I completely forgot about this after writing the perl script... Indeed that's much simpler than renaming the private classes. REPOSITORY R236 KWidgetsAddons BRANCH

D7275: Fix build with QT_NO_ACCESSIBILITY

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D7275 To: vkrause, #frameworks, dhaumann Cc: dhaumann, kwrite-devel

D7279: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

dfaure added a reviewer: mlaurent. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7279 To: kossebau, cfeck, dfaure, vkrause, mlaurent Cc: #frameworks

D7279: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

kossebau added a comment. @dfaure @vkrause I was surprised to see those symbols still exported. From what I remember in this ml thread in 2015 I would have assumed you dealt with that already: https://mail.kde.org/pipermail/kde-frameworks-devel/2015-August/025958.html After all that had

D7279: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

kossebau created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Nested classes inherit the visibility of their outer class, so all the KClass::Private symbols have also been exported if the ones of

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

graesslin added a comment. I like that refactoring  - though processAt might not be the best fitting name. Don't have a good name idea, maybe findChildSurfaceAt? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: subdiff, #frameworks, graesslin Cc:

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

subdiff marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: subdiff, #frameworks, graesslin Cc: graesslin, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein,

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

subdiff updated this revision to Diff 18059. subdiff added a comment. Use function pointers. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7038?vs=17500=18059 REVISION DETAIL https://phabricator.kde.org/D7038 AFFECTED FILES

Minutes GSoC meeting

Present: me, chinmoy, shortstheory Minutes in the attachment. Cheers, Elvis[Saturday, 12 August 2017] [12:01:15 CEST] Meeting! [Saturday, 12 August 2017] [12:01:28 CEST] Hey [Saturday, 12 August 2017] [12:02:14 CEST] chinmoy: ? [Saturday, 12 August 2017] [12:11:22 CEST] eang: i

D7275: Fix build with QT_NO_ACCESSIBILITY

vkrause created this revision. Restricted Application added a subscriber: kwrite-devel. Restricted Application added a project: Frameworks. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D7275 AFFECTED FILES src/view/kateviewinternal.cpp To:

D6233: KKeyServer: fix handling of KeypadModifier.

graesslin added a comment. Sorry for having missed your pings. I have something like 1000 unread mails in the frameworks folder :-( Your change caused a regression in KWin and now a unit test is failing. Please see:

D7274: Allow to only build the kauth-policy-gen code generator

vkrause added a task: T6716: Fix native kauth-policy-gen build for KAuth. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D7274 To: vkrause, #frameworks, cordlandwehr

D7274: Allow to only build the kauth-policy-gen code generator

vkrause created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This is primarily useful for cross-compilation, where e.g. with Yocto neither Qt5Widgets nor PolicyKit are easily available for the host build. REPOSITORY R283 KAuth BRANCH pending

D7272: [DropJob] Enable drag and drop in a read-only folder

chinmoyr added a task: T6561: Polkit support in KIO. REVISION DETAIL https://phabricator.kde.org/D7272 To: chinmoyr, #frameworks, dfaure

D7272: [DropJob] Enable drag and drop in a read-only folder

chinmoyr created this revision. REVISION SUMMARY This patch adds PrivilegeExecution and other relevant code to KIO::DropJob. With this DnD can be done in a read-only folder. BRANCH dropjob REVISION DETAIL https://phabricator.kde.org/D7272 AFFECTED FILES src/widgets/dropjob.cpp To:

D7270: [FileUndoManager] Enable undoing changes in read-only folders

chinmoyr updated this revision to Diff 18048. chinmoyr added a comment. - Check if m_currentJob is null before setting parent job. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7270?vs=18047=18048 BRANCH fileundomanger REVISION DETAIL https://phabricator.kde.org/D7270

D7270: [FileUndoManager] Enable undoing changes in read-only folders

chinmoyr updated this revision to Diff 18047. chinmoyr added a comment. - Removed redudant setParentJob calls CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7270?vs=18044=18047 BRANCH fileundomanger REVISION DETAIL https://phabricator.kde.org/D7270 AFFECTED FILES

D7270: [FileUndoManager] Enable undoing changes in read-only folders

chinmoyr added a task: T6561: Polkit support in KIO. REVISION DETAIL https://phabricator.kde.org/D7270 To: chinmoyr, #frameworks, dfaure

D7270: [FileUndoManager] Enable undoing changes in read-only folders

chinmoyr created this revision. REVISION SUMMARY This patch adds PrivilegeExecution flag to the jobs used by FileUndoManager thus allowing undo operation in a read-only folder. TODO: make this toggle'able from dolphin's settings. BRANCH fileundomanger REVISION DETAIL

D7253: Add build-flatpak target if there is a flatpak recipe around

elvisangelaccio added a comment. In https://phabricator.kde.org/D7253#134703, @apol wrote: > In https://phabricator.kde.org/D7253#134653, @elvisangelaccio wrote: > > > Main reason is having a simple way to run flatpak-builder with the proper arguments. Otherwise you have to

D7237: KIO/Mac : make kiod5 an "agent"

rjvbb set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7237 To: rjvbb, #frameworks, dfaure Cc: kde-mac, dfaure, #frameworks

D7237: KIO/Mac : make kiod5 an "agent"

rjvbb updated this revision to Diff 18037. rjvbb added a comment. I clearly didn't have my eyes aligned with their sockets ... this should finally be the complete patch. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7237?vs=17997=18037 REVISION DETAIL