On 30/08/2017 4:10 PM, "Friedrich W. H. Kossebau" wrote:
Hi Ben & all,
Hi Friedrich,
Am Samstag, 19. August 2017, 02:24:21 CEST schrieb Ben Cooksley:
> On Wed, Aug 16, 2017 at 3:17 AM, David Faure wrote:
> > Hi everyone,
>
> Hi David,
>
> > The documentation for how to do that is now up at
>
Hi Ben & all,
Am Samstag, 19. August 2017, 02:24:21 CEST schrieb Ben Cooksley:
> On Wed, Aug 16, 2017 at 3:17 AM, David Faure wrote:
> > Hi everyone,
>
> Hi David,
>
> > The documentation for how to do that is now up at
> >
> > https://blogs.kde.org/2017/08/15/running-applications-and-unittes
kossebau reopened this revision.
kossebau added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> KDECMakeSettings.cmake:46-47
> +#
> +# When find_package(ECM 5.38) or higher is called, this also selects
> +# a layout for the build dir that helps running executab
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128661/
---
(Updated Aug. 29, 2017, 8:57 nachm.)
Status
--
This change has been
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:1c97e1d9741f: Don't block starting notification service
(authored by davidedmundson).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6963?vs=18912&id=18933
vandenoever added a comment.
The patch looks clean, but I do not fully understand how is supposed to work.
Perhaps an explanation of the different scenarios would help future readers of
this code.
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
https://phabricator.kde.or
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6963
To: davidedmundson, mart
Cc: alexeymin, marten, vandenoever, mck182, dvratil, #frameworks
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
REPOSITORY
R237 KConfig
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7605
AFFECTED FILES
src/gui/kstandardshortcut.h
To: elvisangelaccio, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/71/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Tue, 29 Aug 2017 13:18:00 +
Build duration:
4 min 24 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/67/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 29 Aug 2017 13:18:00 +
Build duration:
59 sec and counting
JUnit Tests
Nam
On Sun, Aug 27, 2017 at 8:37 PM, Luigi Toscano wrote:
> Even without the if branch it would be still complicated.
Ah! I think I get the complexity now. At build time we need to run our
tools already and so the dtd/xsl need to be able to resolve the paths,
hence the initial configure_file with abs
broulik added a dependent revision: D7603: [Digital Clock] Show event plugin
configurations only if enabled.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7601
To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-m
broulik added a dependent revision: D7603: [Digital Clock] Show event plugin
configurations only if enabled.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7602
To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-m
broulik edited the test plan for this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7602
To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
The appendCategory(ConfigCategory*) allows to add a category created by e.g.
an Instantiator that can use bindings rathe
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
That's what digital clock stores in its config, allows us to do matching.
REPOSITORY
R242 Plasma Framework (Library)
On Thu, Aug 24, 2017 at 3:20 PM, Ralf Habacker wrote:
> 10. The conclusion of 9. is that it might also be a solution on windows
> to patch only all generated files after 3. and before 4.
Hm, I may be missing a piece of the puzzle in my mind, but it appears
to me this should be working with the cm
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a8ce2e85ecf5: [FrameSvgItem] Create margins/fixedMargins
object on demand (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7
This might be of interest to some of you.
-- Forwarded Message --
Subject: Change in qt/qtbase[dev]: Make QPlatformServices as a separated
plugin
Date: mardi 29 août 2017, 10:59:02 CEST
From: Jan Grulich (Code Review)
To: David Faure
CC: Qt Sanity Bot
Hello David Faure,
I'
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7582
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed
davidedmundson updated this revision to Diff 18912.
davidedmundson added a comment.
Remove startFdo flag
Keep windows away from DBus activation
Better handle the service owner changing on a potentially
DBus activated notification handler
REPOSITORY
R289 KNotifications
CHANGES S
dhaumann added a comment.
The changes to from QScriptValue to QJSValue look quite good (similar to the
ones done in KTextEditor). I cannot really comment on the FIXMEs you have
added, though.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D7033
To: carewolf, ilic
Cc:
22 matches
Mail list logo