BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/118/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Fri, 13 Oct 2017 02:59:56 +
Build duration:
15 min and counting
JUnit Tests
Name: (root)
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/119/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 13 Oct 2017 02:59:56 +
Build duration:
4 min 49 sec and counting
CONSOLE OUTPUT
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20AndroidQt5.9/1/
Project:
Frameworks kwidgetsaddons kf5-qt5 AndroidQt5.9
Date of build:
Thu, 12 Oct 2017 22:46:24 +
Build duration:
1 min 45 sec and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20AndroidQt5.9/1/
Project:
Frameworks threadweaver kf5-qt5 AndroidQt5.9
Date of build:
Thu, 12 Oct 2017 22:45:01 +
Build duration:
1 min 11 sec and counting
spoorun added a comment.
I support having the recently used option, perhaps by default in the
open/save dialogue, and also as an optional panel.
This would be highly useful for workflow for many, including using other
software as suggested, but also coming back to documents (in multiple
ngraham added a comment.
In https://phabricator.kde.org/D7446#154734, @anthonyfieroni wrote:
> You can add recent documents as an action like in Kate. Places model looks
in not correct destination.
I'm not sure exactly what this is referring to. Can you clarify?
REPOSITORY
mutlaqja added a comment.
This change causes a bug in loading previews, at least for KStars. Bug here:
https://bugs.kde.org/show_bug.cgi?id=385516
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7194
To: apol, leinir
Cc: mutlaqja, broulik, #frameworks
I still get email notifications on commits to a few repos.
How do I unsubscribe from the ones I no longer care about?
How do I subscribe to new repos I'm currently interested in?
searching the wiki isn't helping.
I see mention of CommitFilter, but that's dead.
I tried watching github mirrors,
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/2/
Project:
Frameworks breeze-icons kf5-qt5 AndroidQt5.9
Date of build:
Thu, 12 Oct 2017 20:00:42 +
Build duration:
3 min 53 sec and counting
CONSOLE
renatoo added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kfileplacesview.cpp:169
> Ok i understaind the workaround, but did you know what is the value of
> opt.index.row() ?
Humm I did not know about this opt.index property. Did some debug here and it
is always -1 .
Sorry
anthonyfieroni added inline comments.
INLINE COMMENTS
> renatoo wrote in kfileplacesview.cpp:169
> m_dragModeCount is used as workaround to draw items on floating window during
> the drag.
>
> When drag starts it save the number of selected items and until we draw all
> selected items once we
renatoo marked an inline comment as done.
renatoo added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kfileplacesview.cpp:169
> Why you are sure that m_dragModeCount is 0 when indexIsSectionHeader? Why not
> when index.row() == 0 we can paint section header?
m_dragModeCount is
anthonyfieroni added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kfileplacesview.cpp:1150
> This calculation makes no sense to me. We have ((x - (y/2) * rowCount) /
> rowCount so rowCount can be removed no?
Now i see i'm in wrong :)
REPOSITORY
R241 KIO
REVISION DETAIL
anthonyfieroni added inline comments.
INLINE COMMENTS
> kfileplacesview.cpp:169
> +// if is drawing the floating element used by drag/drop, does not
> draw the header
> +if (m_dragModeCount == 0) {
> +drawSectionHeader(painter, opt, index);
Why you are sure that
renatoo marked 2 inline comments as done.
renatoo added inline comments.
INLINE COMMENTS
> renatoo wrote in kfileplacesview.cpp:424
> I need a way query the header size height from "pointIsHeaderArea" to know if
> the user clicked on header or in the real item. Since I do not have access
>
renatoo updated this revision to Diff 20656.
renatoo added a comment.
Use QApplication::font() to determine the section header font size
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8243?vs=20650=20656
BRANCH
model-hide-row
REVISION DETAIL
renatoo added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kfileplacesview.cpp:424
> So you mean sizeHint have a right height ? This height store looks like a
> workaround.
I need a way query the header size height from "pointIsHeaderArea" to know if
the user clicked on header
anthonyfieroni added inline comments.
INLINE COMMENTS
> kfileplacesview.cpp:424
> +if (m_sectionHeaderHeight == -1) {
> +m_sectionHeaderHeight = option.fontMetrics.height();
> +}
So you mean sizeHint have a right height ? This height store looks like a
workaround.
REPOSITORY
markg requested changes to this revision.
markg added a comment.
This revision now requires changes to proceed.
In https://phabricator.kde.org/D7446#154720, @ngraham wrote:
> That said, it's not just me who wants this in Dolphin, too. There's a
Bugzilla ticket with one dupe and 32 votes:
anthonyfieroni added a comment.
You can add recent documents as an action like in Kate. Places model looks in
not correct destination.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7446
To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure,
ngraham added a comment.
That said, it's not just me who wants this in Dolphin, too. There's a
Bugzilla ticket with one dupe and 32 votes:
https://bugs.kde.org/show_bug.cgi?id=357542
Also, we have a semi-functional version of this already in the form of the
Places panel's Recently
ngraham added a comment.
I could get behind only adding it to Open File dialogs. Let me have a think
on that.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7446
To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure,
emmanuelp
Cc: andreaska,
markg added a comment.
In https://phabricator.kde.org/D7446#154617, @ngraham wrote:
> @markg, I strongly disagree that "recent files" are not useful in open/save
dialogs.
>
> As I've mentioned before, a common use case that this enables is when you
save an item from one program and
This revision was automatically updated to reflect the committed changes.
Closed by commit R303:b82ea5b8d7b3: Correct installation of start_kdeinit when
DESTDIR and libcap are used together (authored by graesslin).
REPOSITORY
R303 KInit
CHANGES SINCE LAST UPDATE
graesslin accepted this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7369
To: mart, #plasma, #kwin, davidedmundson, graesslin
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot,
alexeymin, progwolff, lesliezhai, ali-mohamed,
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
That comment could be a bit more verbose and better placed (i.e. move it next
to `set(BINARY_ICONS_RESOURCE_OPTION_DEFAULT OFF)` and make it something along
"When cross-compiling qrcAlias
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
renatoo updated this revision to Diff 20650.
renatoo marked an inline comment as done.
renatoo added a comment.
Optimize sectionsCount to not use a QSet
Use static_cast when possible
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8243?vs=20646=20650
BRANCH
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesview.cpp:997
> +{
> +KFilePlacesViewDelegate *delegate = dynamic_cast *>(itemDelegate());
> +
If you are sure that the delegate is a
apol updated this revision to Diff 20648.
apol added a comment.
Address Kevin's comments
REPOSITORY
R266 Breeze Icons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8264?vs=20641=20648
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8264
AFFECTED FILES
renatoo updated this revision to Diff 20646.
renatoo added a comment.
Fixed code style
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8243?vs=20645=20646
BRANCH
model-hide-row
REVISION DETAIL
https://phabricator.kde.org/D8243
AFFECTED FILES
renatoo marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin
Cc: mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
renatoo added a comment.
All problems fixed.
INLINE COMMENTS
> anthonyfieroni wrote in kfileplacesview.cpp:1065-1066
> So if second line is correct why not remove first one?
Sorry wrong operator it should be "+="
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
renatoo updated this revision to Diff 20645.
renatoo marked 9 inline comments as done.
renatoo added a comment.
Fix code syntax
Disable drag from item header
Does not show item header on floating preview during the drag
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:23
> +if (CMAKE_CROSSCOMPILING)
> +set(GENERATE_ICONS_DEFAULT OFF)
> +else()
Better: `GENERATE_ICONS_DEFAULT` ->
apol created this revision.
apol added reviewers: Frameworks, Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
At the moment we are compiling the tool against android then trying to
execute it, which
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20AndroidQt5.9/2/
Project:
Frameworks ki18n kf5-qt5 AndroidQt5.9
Date of build:
Thu, 12 Oct 2017 13:07:16 +
Build duration:
1 min 38 sec and counting
mart updated this revision to Diff 20639.
mart marked 7 inline comments as done.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- more documentation
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
ngraham added a comment.
@markg, I strongly disagree that "recent files" are not useful in open/save
dialogs.
As I've mentioned before, a common use case that this enables is when you
save an item from one program and need to open it in another without having a
Dolphin window open that
mart updated this revision to Diff 20638.
mart added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- documentation++
- name the methods exportTopLevel/importTopLevel
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesview.cpp:113
> +QColor baseColor(const QStyleOption ) const;
> +QColor mixedColor(const QColor& c1, const QColor& c2, int c1Percent)
> const;
> };
coding style const QColor , const QColor
REPOSITORY
R241 KIO
REVISION
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20AndroidQt5.9/1/
Project:
Frameworks kconfig kf5-qt5 AndroidQt5.9
Date of build:
Thu, 12 Oct 2017 11:52:33 +
Build duration:
1 min 9 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20AndroidQt5.9/1/
Project:
Frameworks ki18n kf5-qt5 AndroidQt5.9
Date of build:
Thu, 12 Oct 2017 11:49:14 +
Build duration:
3 min 26 sec and counting
CONSOLE OUTPUT
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kguiaddons%20kf5-qt5%20AndroidQt5.9/1/
Project:
Frameworks kguiaddons kf5-qt5 AndroidQt5.9
Date of build:
Thu, 12 Oct 2017 11:48:54 +
Build duration:
49 sec and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20AndroidQt5.9/1/
Project:
Frameworks karchive kf5-qt5 AndroidQt5.9
Date of build:
Thu, 12 Oct 2017 11:48:29 +
Build duration:
49 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kcodecs%20kf5-qt5%20AndroidQt5.9/1/
Project:
Frameworks kcodecs kf5-qt5 AndroidQt5.9
Date of build:
Thu, 12 Oct 2017 11:48:49 +
Build duration:
37 sec and counting
CONSOLE OUTPUT
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20XenialQt5.7/29/
Project:
Frameworks kpackage kf5-qt5 XenialQt5.7
Date of build:
Thu, 12 Oct 2017 10:37:04 +
Build duration:
1 min 22 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/35/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 12 Oct 2017 10:37:04 +
Build duration:
1 min 3 sec and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.9/1/
Project:
Frameworks breeze-icons kf5-qt5 AndroidQt5.9
Date of build:
Thu, 12 Oct 2017 10:24:00 +
Build duration:
4 min 1 sec and counting
CONSOLE
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20AndroidQt5.9/1/
Project:
Frameworks attica kf5-qt5 AndroidQt5.9
Date of build:
Thu, 12 Oct 2017 10:23:55 +
Build duration:
1 min 12 sec and counting
andreaska added a comment.
+1
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D7520
To: elvisangelaccio, #frameworks
Cc: andreaska, broulik
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/83/
Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 12 Oct 2017 09:33:00 +
Build duration:
2 min 17 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/118/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 12 Oct 2017 09:33:00 +
Build duration:
1 min 1 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/124/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Thu, 12 Oct 2017 09:33:00 +
Build duration:
1 min 58 sec and counting
JUnit Tests
elvisangelaccio updated this revision to Diff 20631.
elvisangelaccio added a comment.
- Switched from `user-trash` to `trash-empty` (discussed with @andreaska in
person).
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7520?vs=18688=20631
BRANCH
andreaska added a comment.
works for the VDG really good job. well done. I like it.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7446
To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure,
emmanuelp
Cc: andreaska, gregormi, markg, alexeymin,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/123/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Thu, 12 Oct 2017 09:04:55 +
Build duration:
1 min 33 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/117/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 12 Oct 2017 09:04:55 +
Build duration:
1 min 7 sec and counting
JUnit Tests
ervin added a comment.
One more thing, the way the sections are currently done, if I drag the first
item of a section the visual feedback I get also includes the section itself
giving the feeling that the section itself is being moved. Also I can drag from
the section title itself which is
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.
Note that the summary part of the commit is now wrong (it still refers to
KCategorizedView).
Also, KFilePlacesModelTest needs to be adjusted to take into account the new
anthonyfieroni added inline comments.
INLINE COMMENTS
> kfileplacesview.cpp:104
> +
> +int m_sectionRole;
> +
const
> kfileplacesview.cpp:1065-1066
> const int maxWidth = q->viewport()->width() - textWidth - 4 * margin - 1;
> -const int maxHeight = ((q->height() - (fm.height() /
61 matches
Mail list logo