graesslin added a comment.
Could you check which libsmbclient version is used and order the change?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8387
To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks
Cc: graesslin, z3ntu
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:76375dcd7c8a: Use KIO::PreviewJob::defaultPlugins()
(authored by ngraham).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8352?vs=20929&id=21032
REVISION DETAIL
ngraham added a reviewer: Frameworks.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8387
To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks
Cc: z3ntu
ngraham added a comment.
Yep, I have tested that in https://phabricator.kde.org/D7440.
REPOSITORY
R320 KIO Extras
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8352
To: ngraham, #frameworks, broulik, elvisangelaccio, markg
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
Please do make sure (just as a test before you push this) that the default
plugins (which now is all except for the text plugin if i recall correctly) are
enabled in Dolphin' settings (Genera
ngraham added reviewers: broulik, elvisangelaccio, markg.
ngraham added a comment.
The dependent revision is now merged. Anyone object to this?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8352
To: ngraham, #frameworks, broulik, elvisangelaccio, markg
graesslin created this revision.
graesslin added reviewers: Frameworks, KWin, Plasma on Wayland.
Restricted Application added a subscriber: plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.
REVISION SUMMARY
This is a preparation step to support idle_inhibit_unst
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/53/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 20 Oct 2017 13:45:50 +
Build duration:
12 min and counting
JUnit Tests
Nam
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/54/
Project:
Frameworks kwayland kf5-qt5 XenialQt5.7
Date of build:
Fri, 20 Oct 2017 13:45:50 +
Build duration:
11 min and counting
JUnit Tests
Name:
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:1203580ca069: [client] Drop the checks for platformName
being "wayland" (authored by graesslin).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8250?vs=20602&id=21
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/123/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 20 Oct 2017 12:56:05 +
Build duration:
25 min and counting
JUnit Tests
Name: (root)
graesslin added a comment.
In https://phabricator.kde.org/D8250#157282, @davidedmundson wrote:
> Meh.
> We're potentially gonna get some mental crashes.
Yes, but it should also be obvious. If it crashes with one of these methods
in the backtrace we can be sure someone didn't c
ngraham added a comment.
If there are no objections, can someone grudgingly mark it as approved? ;-)
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg
Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/122/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Fri, 20 Oct 2017 12:56:05 +
Build duration:
19 min and counting
JUnit Tests
Name: (root) F
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3042e12296db: KIO::PreviewJob::defaultPlugins() function
(authored by ngraham).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8347?vs=21004&id=21005#toc
REPOSITORY
R241 KIO
CHANGES SINCE L
ngraham updated this revision to Diff 21004.
ngraham added a comment.
Correcting the @since version number
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8347?vs=20975&id=21004
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8347
AFFECTED FILE
ngraham added a comment.
@markg
Ultimately I think everyone is in agreement in wanting the "single scrollbar"
approach for items in whatever you call the default list on Dolphin's left
side. Splitting everything into distinct panels and embedding all the panels in
a single scrollview is
markg added a comment.
In https://phabricator.kde.org/D8243#157346, @renatoo wrote:
> In https://phabricator.kde.org/D8243#157336, @markg wrote:
>
> > We have such a nice modular design with panels yet we keep cramming
everything in the places panel... Why?
> > It's not just here,
renatoo added a comment.
In https://phabricator.kde.org/D8243#157336, @markg wrote:
> We have such a nice modular design with panels yet we keep cramming
everything in the places panel... Why?
> It's not just here, I've seen patches like this for Dolphin as well.
>
> Imho, the plac
renatoo updated this revision to Diff 21003.
renatoo added a comment.
Fixed unit test
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=20987&id=21003
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
autotests/kfileplacesmodeltest.cpp
markg added a comment.
We have such a nice modular design with panels yet we keep cramming
everything in the places panel... Why?
It's not just here, I've seen patches like this for Dolphin as well.
Imho, the places panel should only contain the top places - favorites if you
will - tha
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Meh.
We're potentially gonna get some mental crashes.
Can't find a better option though :/
REPOSITORY
R127 KWayland
BRANCH
drop-platform-check
REVISION DETAIL
22 matches
Mail list logo
